All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH igt] igt/drv_hangman: Skip aliased I915_EXEC_BSD
@ 2017-10-20 22:36 Chris Wilson
  2017-10-20 22:54 ` ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2017-10-20 22:36 UTC (permalink / raw)
  To: intel-gfx

If the system has bsd2, we do not know which ring the kernel will alias
I915_EXEC_BSD onto and so we do not what the matching string should be.
Skip the unknown.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103324
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/drv_hangman.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
index de57e128..beefcabb 100644
--- a/tests/drv_hangman.c
+++ b/tests/drv_hangman.c
@@ -185,6 +185,15 @@ static void test_error_state_capture(unsigned ring_id,
 	uint64_t offset;
 
 	igt_require(gem_has_ring(device, ring_id));
+
+	/*
+	 * If the device has 2 BSD rings then due to obtuse aliasing in the
+	 * API, we can not determine which ring I915_EXEC_BSD will map to, and
+	 * so must skip the test; as the matching name may be either bsd or
+	 * bsd2 depending on the kernel/test ordering.
+	 */
+	igt_skip_on(ring_id == I915_EXEC_BSD && gem_has_bsd2(device));
+
 	clear_error_state();
 
 	hang = igt_hang_ctx(device, 0, ring_id, HANG_ALLOW_CAPTURE, &offset);
-- 
2.15.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for igt/drv_hangman: Skip aliased I915_EXEC_BSD
  2017-10-20 22:36 [PATCH igt] igt/drv_hangman: Skip aliased I915_EXEC_BSD Chris Wilson
@ 2017-10-20 22:54 ` Patchwork
  2017-10-25 15:13 ` [PATCH igt v2] " Chris Wilson
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-10-20 22:54 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/drv_hangman: Skip aliased I915_EXEC_BSD
URL   : https://patchwork.freedesktop.org/series/32395/
State : failure

== Summary ==

IGT patchset tested on top of latest successful build
9ba736aecc2a3cb34a2aeec8d417f66390e0c82b tools/intel_vbt_decode: abstract child devices printing more

with latest DRM-Tip kernel build CI_DRM_3271
0760516f3127 drm-tip: 2017y-10m-20d-18h-40m-36s UTC integration manifest

No testlist changes.

Test chamelium:
        Subgroup dp-hpd-fast:
                incomplete -> SKIP       (fi-bdw-gvtdvm) fdo#102332
        Subgroup dp-crc-fast:
                fail       -> PASS       (fi-kbl-7500u) fdo#102514
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a:
                pass       -> INCOMPLETE (fi-skl-6700hq)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (fi-byt-j1900) fdo#101705

fdo#102332 https://bugs.freedesktop.org/show_bug.cgi?id=102332
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:438s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:459s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:376s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:530s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:266s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:502s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:508s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:496s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:477s
fi-cfl-s         total:289  pass:253  dwarn:4   dfail:0   fail:0   skip:32  time:562s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:425s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:254s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:579s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:453s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:432s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:431s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:484s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:457s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:492s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:573s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:477s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:586s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:547s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:456s
fi-skl-6700hq    total:233  pass:208  dwarn:0   dfail:0   fail:0   skip:24 
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:521s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:501s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:462s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:418s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_397/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH igt v2] igt/drv_hangman: Skip aliased I915_EXEC_BSD
  2017-10-20 22:36 [PATCH igt] igt/drv_hangman: Skip aliased I915_EXEC_BSD Chris Wilson
  2017-10-20 22:54 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-10-25 15:13 ` Chris Wilson
  2017-10-25 15:16   ` Michał Winiarski
  2017-10-25 18:25 ` ✓ Fi.CI.BAT: success for igt/drv_hangman: Skip aliased I915_EXEC_BSD (rev2) Patchwork
  2017-10-25 19:45 ` ✗ Fi.CI.IGT: failure " Patchwork
  3 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2017-10-25 15:13 UTC (permalink / raw)
  To: intel-gfx

If the system has bsd2, we do not know which ring the kernel will alias
I915_EXEC_BSD onto and so we do not what the matching string should be.
Skip the unknown.

v2: Deny the aliased I915_EXEC_BSD exists at all; be specific!

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103324
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
CC: Michał Winiarski <michal.winiarski@intel.com>
---
 tests/drv_hangman.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
index 0551ec16..40c82257 100644
--- a/tests/drv_hangman.c
+++ b/tests/drv_hangman.c
@@ -184,6 +184,7 @@ static void test_error_state_capture(unsigned ring_id,
 	uint64_t offset;
 
 	igt_require(gem_has_ring(device, ring_id));
+
 	clear_error_state();
 
 	hang = igt_hang_ctx(device, 0, ring_id, HANG_ALLOW_CAPTURE, &offset);
@@ -254,6 +255,20 @@ igt_main
 		if (e->exec_id == 0)
 			continue;
 
+		/*
+		 * If the device has 2 BSD rings then due to obtuse aliasing
+		 * in the API, we can not determine which ring I915_EXEC_BSD
+		 * will map to, and so must skip the test; as the matching name
+		 * may be either bsd or bsd2 depending on the kernel/test
+		 * ordering.
+		 *
+		 * Here we are not checking that executing on every ABI engine
+		 * results in a detectable hang, but that a hang generated
+		 * from a specific HW engine gives an indentifiable result.
+		 */
+		if (e->exec_id == I915_EXEC_BSD && e->flags == 0)
+			continue;
+
 		igt_subtest_f("error-state-capture-%s", e->name)
 			test_error_state_capture(e->exec_id | e->flags,
 						 e->full_name);
-- 
2.15.0.rc2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH igt v2] igt/drv_hangman: Skip aliased I915_EXEC_BSD
  2017-10-25 15:13 ` [PATCH igt v2] " Chris Wilson
@ 2017-10-25 15:16   ` Michał Winiarski
  0 siblings, 0 replies; 6+ messages in thread
From: Michał Winiarski @ 2017-10-25 15:16 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Wed, Oct 25, 2017 at 04:13:58PM +0100, Chris Wilson wrote:
> If the system has bsd2, we do not know which ring the kernel will alias
> I915_EXEC_BSD onto and so we do not what the matching string should be.
> Skip the unknown.
> 
> v2: Deny the aliased I915_EXEC_BSD exists at all; be specific!
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103324
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> CC: Michał Winiarski <michal.winiarski@intel.com>

Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>

-Michał

> ---
>  tests/drv_hangman.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
> index 0551ec16..40c82257 100644
> --- a/tests/drv_hangman.c
> +++ b/tests/drv_hangman.c
> @@ -184,6 +184,7 @@ static void test_error_state_capture(unsigned ring_id,
>  	uint64_t offset;
>  
>  	igt_require(gem_has_ring(device, ring_id));
> +
>  	clear_error_state();
>  
>  	hang = igt_hang_ctx(device, 0, ring_id, HANG_ALLOW_CAPTURE, &offset);
> @@ -254,6 +255,20 @@ igt_main
>  		if (e->exec_id == 0)
>  			continue;
>  
> +		/*
> +		 * If the device has 2 BSD rings then due to obtuse aliasing
> +		 * in the API, we can not determine which ring I915_EXEC_BSD
> +		 * will map to, and so must skip the test; as the matching name
> +		 * may be either bsd or bsd2 depending on the kernel/test
> +		 * ordering.
> +		 *
> +		 * Here we are not checking that executing on every ABI engine
> +		 * results in a detectable hang, but that a hang generated
> +		 * from a specific HW engine gives an indentifiable result.
> +		 */
> +		if (e->exec_id == I915_EXEC_BSD && e->flags == 0)
> +			continue;
> +
>  		igt_subtest_f("error-state-capture-%s", e->name)
>  			test_error_state_capture(e->exec_id | e->flags,
>  						 e->full_name);
> -- 
> 2.15.0.rc2
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for igt/drv_hangman: Skip aliased I915_EXEC_BSD (rev2)
  2017-10-20 22:36 [PATCH igt] igt/drv_hangman: Skip aliased I915_EXEC_BSD Chris Wilson
  2017-10-20 22:54 ` ✗ Fi.CI.BAT: failure for " Patchwork
  2017-10-25 15:13 ` [PATCH igt v2] " Chris Wilson
@ 2017-10-25 18:25 ` Patchwork
  2017-10-25 19:45 ` ✗ Fi.CI.IGT: failure " Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-10-25 18:25 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/drv_hangman: Skip aliased I915_EXEC_BSD (rev2)
URL   : https://patchwork.freedesktop.org/series/32395/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
e7742ee1a8e1cdc00c799531bcd90a421405b888 igt/gem_exec_nop: Headless requires DRM_MASTER for modesetting

with latest DRM-Tip kernel build CI_DRM_3284
be67da218126 drm-tip: 2017y-10m-25d-17h-36m-48s UTC integration manifest

Testlist changes:
-igt@drv_hangman@error-state-capture-bsd

Test chamelium:
        Subgroup dp-crc-fast:
                fail       -> PASS       (fi-kbl-7500u) fdo#102514
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (fi-skl-6770hq)
Test kms_frontbuffer_tracking:
        Subgroup basic:
                pass       -> DMESG-WARN (fi-bdw-5557u) fdo#102473

fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#102473 https://bugs.freedesktop.org/show_bug.cgi?id=102473

fi-bdw-5557u     total:289  pass:267  dwarn:1   dfail:0   fail:0   skip:21  time:440s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:454s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:372s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:521s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:268s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:499s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:506s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:492s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:475s
fi-cfl-s         total:289  pass:253  dwarn:4   dfail:0   fail:0   skip:32  time:554s
fi-cnl-y         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:619s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:419s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:249s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:585s
fi-glk-dsi       total:289  pass:258  dwarn:0   dfail:0   fail:1   skip:30  time:488s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:432s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:430s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:432s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:494s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:461s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:493s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:571s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:481s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:586s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:546s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:451s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:595s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:645s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:519s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:500s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:457s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:561s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:424s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_421/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: failure for igt/drv_hangman: Skip aliased I915_EXEC_BSD (rev2)
  2017-10-20 22:36 [PATCH igt] igt/drv_hangman: Skip aliased I915_EXEC_BSD Chris Wilson
                   ` (2 preceding siblings ...)
  2017-10-25 18:25 ` ✓ Fi.CI.BAT: success for igt/drv_hangman: Skip aliased I915_EXEC_BSD (rev2) Patchwork
@ 2017-10-25 19:45 ` Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-10-25 19:45 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/drv_hangman: Skip aliased I915_EXEC_BSD (rev2)
URL   : https://patchwork.freedesktop.org/series/32395/
State : failure

== Summary ==

Test kms_busy:
        Subgroup extended-modeset-hang-oldfb-with-reset-render-C:
                pass       -> DMESG-WARN (shard-hsw) fdo#102249
        Subgroup extended-modeset-hang-newfb-with-reset-render-B:
                dmesg-warn -> PASS       (shard-hsw) fdo#103038
Test kms_vblank:
        Subgroup accuracy-idle:
                fail       -> PASS       (shard-hsw) fdo#102583
Test kms_plane:
        Subgroup plane-position-hole-dpms-pipe-B-planes:
                skip       -> PASS       (shard-hsw)
Test kms_flip:
        Subgroup blt-wf_vblank-vs-modeset-interruptible:
                pass       -> INCOMPLETE (shard-hsw)

fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
fdo#103038 https://bugs.freedesktop.org/show_bug.cgi?id=103038
fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583

shard-hsw        total:2539 pass:1432 dwarn:1   dfail:0   fail:8   skip:1097 time:8774s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_421/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-25 19:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-20 22:36 [PATCH igt] igt/drv_hangman: Skip aliased I915_EXEC_BSD Chris Wilson
2017-10-20 22:54 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-25 15:13 ` [PATCH igt v2] " Chris Wilson
2017-10-25 15:16   ` Michał Winiarski
2017-10-25 18:25 ` ✓ Fi.CI.BAT: success for igt/drv_hangman: Skip aliased I915_EXEC_BSD (rev2) Patchwork
2017-10-25 19:45 ` ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.