All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sam@mendozajonas.com
Cc: netdev@vger.kernel.org, gwshan@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 5/5] net/ncsi: Fix length of GVI response packet
Date: Sat, 21 Oct 2017 01:57:26 +0100 (WEST)	[thread overview]
Message-ID: <20171021.015726.910376579423539079.davem@davemloft.net> (raw)
In-Reply-To: <20171019024309.13628-5-sam@mendozajonas.com>

From: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Date: Thu, 19 Oct 2017 13:43:09 +1100

> From: Gavin Shan <gwshan@linux.vnet.ibm.com>
> 
> The length of GVI (GetVersionInfo) response packet should be 40 instead
> of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats.
> 
>  # ethtool --ncsi eth0 swstats
>      :
>  RESPONSE     OK       TIMEOUT  ERROR
>  =======================================
>  GVI          0        0        2
> 
> With this applied, no error reported on GVI response packets:
> 
>  # ethtool --ncsi eth0 swstats
>      :
>  RESPONSE     OK       TIMEOUT  ERROR
>  =======================================
>  GVI          2        0        0
> 
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
> Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>

Applied.

  reply	other threads:[~2017-10-21  0:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  2:43 [PATCH net 1/5] net/ncsi: Fix AEN HNCDSC packet length Samuel Mendoza-Jonas
2017-10-19  2:43 ` [PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive Samuel Mendoza-Jonas
2017-10-21  0:57   ` David Miller
2017-10-19  2:43 ` [PATCH net 3/5] net/ncsi: Disable HWA mode when no channels are found Samuel Mendoza-Jonas
2017-10-21  0:57   ` David Miller
2017-10-19  2:43 ` [PATCH net 4/5] net/ncsi: Enforce failover on link monitor timeout Samuel Mendoza-Jonas
2017-10-21  0:57   ` David Miller
2017-10-19  2:43 ` [PATCH net 5/5] net/ncsi: Fix length of GVI response packet Samuel Mendoza-Jonas
2017-10-21  0:57   ` David Miller [this message]
2017-10-21  0:56 ` [PATCH net 1/5] net/ncsi: Fix AEN HNCDSC packet length David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171021.015726.910376579423539079.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sam@mendozajonas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.