* [PATCH] net: core: rtnetlink: use BUG_ON instead of if condition followed by BUG
@ 2017-10-21 0:43 Gustavo A. R. Silva
2017-10-23 4:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-10-21 0:43 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux-kernel, Gustavo A. R. Silva
Use BUG_ON instead of if condition followed by BUG in do_setlink.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
This code was tested by compilation only.
net/core/rtnetlink.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 04680a5..df8dba9 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2274,8 +2274,7 @@ static int do_setlink(const struct sk_buff *skb,
rcu_read_lock();
- if (!(af_ops = rtnl_af_lookup(nla_type(af))))
- BUG();
+ BUG_ON(!(af_ops = rtnl_af_lookup(nla_type(af))));
err = af_ops->set_link_af(dev, af);
if (err < 0) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: core: rtnetlink: use BUG_ON instead of if condition followed by BUG
2017-10-21 0:43 [PATCH] net: core: rtnetlink: use BUG_ON instead of if condition followed by BUG Gustavo A. R. Silva
@ 2017-10-23 4:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-10-23 4:32 UTC (permalink / raw)
To: garsilva; +Cc: netdev, linux-kernel
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Fri, 20 Oct 2017 19:43:11 -0500
> Use BUG_ON instead of if condition followed by BUG in do_setlink.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-23 4:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-21 0:43 [PATCH] net: core: rtnetlink: use BUG_ON instead of if condition followed by BUG Gustavo A. R. Silva
2017-10-23 4:32 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.