* [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
@ 2017-10-21 8:53 Heiko Stuebner
2017-10-24 1:23 ` David.Wu
2017-10-31 9:14 ` [PATCH] " Linus Walleij
0 siblings, 2 replies; 14+ messages in thread
From: Heiko Stuebner @ 2017-10-21 8:53 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-gpio, linux-rockchip, hans.verkuil, Heiko Stuebner
The rk3288 also has one function that can be routed to one of two pins,
the hdmi cec functionality can use either gpio7c0 or gpio7c7.
So add the route switching support for it.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
---
drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index b5cb7858ffdc..8dd49e2e144b 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -884,6 +884,24 @@ static struct rockchip_mux_route_data rk3228_mux_route_data[] = {
},
};
+static struct rockchip_mux_route_data rk3288_mux_route_data[] = {
+ {
+ /* edphdmi_cecinoutt1 */
+ .bank_num = 7,
+ .pin = 16,
+ .func = 2,
+ .route_offset = 0x264,
+ .route_val = BIT(16 + 12) | BIT(12),
+ }, {
+ /* edphdmi_cecinout */
+ .bank_num = 7,
+ .pin = 23,
+ .func = 4,
+ .route_offset = 0x264,
+ .route_val = BIT(16 + 12),
+ },
+};
+
static struct rockchip_mux_route_data rk3328_mux_route_data[] = {
{
/* uart2dbg_rxm0 */
@@ -3391,6 +3409,8 @@ static struct rockchip_pin_ctrl rk3288_pin_ctrl = {
.type = RK3288,
.grf_mux_offset = 0x0,
.pmu_mux_offset = 0x84,
+ .iomux_routes = rk3288_mux_route_data,
+ .niomux_routes = ARRAY_SIZE(rk3288_mux_route_data),
.pull_calc_reg = rk3288_calc_pull_reg_and_bit,
.drv_calc_reg = rk3288_calc_drv_reg_and_bit,
};
--
2.14.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: pinctrl: rockchip: Add iomux-route switching support for rk3288
2017-10-21 8:53 [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288 Heiko Stuebner
@ 2017-10-24 1:23 ` David.Wu
2017-10-31 9:14 ` [PATCH] " Linus Walleij
1 sibling, 0 replies; 14+ messages in thread
From: David.Wu @ 2017-10-24 1:23 UTC (permalink / raw)
To: Heiko Stuebner, linus.walleij; +Cc: linux-gpio, hans.verkuil, linux-rockchip
Hi Heiko,
在 2017/10/21 16:53, Heiko Stuebner 写道:
> The rk3288 also has one function that can be routed to one of two pins,
> the hdmi cec functionality can use either gpio7c0 or gpio7c7.
> So add the route switching support for it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: David Wu <david.wu@rock-chips.com>
Thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
2017-10-21 8:53 [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288 Heiko Stuebner
2017-10-24 1:23 ` David.Wu
@ 2017-10-31 9:14 ` Linus Walleij
1 sibling, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2017-10-31 9:14 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-gpio, open list:ARM/Rockchip SoC..., Hans Verkuil
On Sat, Oct 21, 2017 at 10:53 AM, Heiko Stuebner <heiko@sntech.de> wrote:
> The rk3288 also has one function that can be routed to one of two pins,
> the hdmi cec functionality can use either gpio7c0 or gpio7c7.
> So add the route switching support for it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
Patch applied with David's review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 0/3] Enable CEC on rk3399
@ 2017-10-13 22:53 Pierre-Hugues Husson
2017-10-14 13:14 ` Pierre-Hugues Husson
0 siblings, 1 reply; 14+ messages in thread
From: Pierre-Hugues Husson @ 2017-10-13 22:53 UTC (permalink / raw)
To: linux-rockchip
Cc: heiko, linux-kernel, linux-arm-kernel, linux-media, Pierre-Hugues Husson
Enable CEC on firefly-rk3399.
Tested on a TV with cec-ctl --playback; cec-ctl -S
Pierre-Hugues Husson (3):
drm: bridge: synopsys/dw-hdmi: Enable cec clock
arm64: dts: rockchip: add the cec clk for dw-mipi-hdmi on rk3399
arm64: dts: rockchip: enable cec pin for rk3399 firefly
arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 2 ++
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 ++++++--
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 16 ++++++++++++++++
3 files changed, 24 insertions(+), 2 deletions(-)
--
2.14.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Enable CEC on rk3399
@ 2017-10-14 13:14 ` Pierre-Hugues Husson
2017-10-14 14:52 ` Heiko Stuebner
0 siblings, 1 reply; 14+ messages in thread
From: Pierre-Hugues Husson @ 2017-10-14 13:14 UTC (permalink / raw)
To: Hans Verkuil
Cc: linux-rockchip, Heiko Stuebner, linux-kernel, linux-arm-kernel,
linux-media
Hi Hans,
> Nice! I had a similar dw-hdmi.c patch pending but got around to posting it.
>
> I'll brush off my old rk3288 patches and see if I can get CEC enabled
> for my firefly-reload. I was close to getting it work, but I guess
> missed the "enable cec pin" change.
Please note that on rk3288, there are two CEC pins, and you must write
in RK3288_GRF_SOC_CON8 which pin you're using.
On the firefly-reload, the pin used is GPIO7C0, while the default pin
configuration is GPIO7C7.
Regards,
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Enable CEC on rk3399
2017-10-14 13:14 ` Pierre-Hugues Husson
@ 2017-10-14 14:52 ` Heiko Stuebner
2017-10-14 15:39 ` Heiko Stuebner
0 siblings, 1 reply; 14+ messages in thread
From: Heiko Stuebner @ 2017-10-14 14:52 UTC (permalink / raw)
To: Pierre-Hugues Husson
Cc: Hans Verkuil, linux-rockchip, linux-kernel, linux-arm-kernel,
linux-media
Am Samstag, 14. Oktober 2017, 15:14:40 CEST schrieb Pierre-Hugues Husson:
> Hi Hans,
>
> > Nice! I had a similar dw-hdmi.c patch pending but got around to posting it.
> >
> > I'll brush off my old rk3288 patches and see if I can get CEC enabled
> > for my firefly-reload. I was close to getting it work, but I guess
> > missed the "enable cec pin" change.
> Please note that on rk3288, there are two CEC pins, and you must write
> in RK3288_GRF_SOC_CON8 which pin you're using.
> On the firefly-reload, the pin used is GPIO7C0, while the default pin
> configuration is GPIO7C7.
And as an additional note, later socs have even more of these pin-routing
settings and we currently have infrastructure in the pinctrl driver to do
this automatically depending on the pinctrl settings.
So most likely this can also be added there for the rk3288.
Heiko
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
2017-10-14 14:52 ` Heiko Stuebner
@ 2017-10-14 15:39 ` Heiko Stuebner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2017-10-14 15:39 UTC (permalink / raw)
To: Pierre-Hugues Husson
Cc: Hans Verkuil, linux-rockchip, linux-kernel, linux-arm-kernel,
linux-media
So far only the hdmi cec supports using one of two different pins
as source, so add the route switching for it.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
If I didn't mess up any numbering, the pinctrl change should look like
the following patch.
Hope that helps
Heiko
drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index b5cb7858ffdc..8dd49e2e144b 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -884,6 +884,24 @@ static struct rockchip_mux_route_data rk3228_mux_route_data[] = {
},
};
+static struct rockchip_mux_route_data rk3288_mux_route_data[] = {
+ {
+ /* edphdmi_cecinoutt1 */
+ .bank_num = 7,
+ .pin = 16,
+ .func = 2,
+ .route_offset = 0x264,
+ .route_val = BIT(16 + 12) | BIT(12),
+ }, {
+ /* edphdmi_cecinout */
+ .bank_num = 7,
+ .pin = 23,
+ .func = 4,
+ .route_offset = 0x264,
+ .route_val = BIT(16 + 12),
+ },
+};
+
static struct rockchip_mux_route_data rk3328_mux_route_data[] = {
{
/* uart2dbg_rxm0 */
@@ -3391,6 +3409,8 @@ static struct rockchip_pin_ctrl rk3288_pin_ctrl = {
.type = RK3288,
.grf_mux_offset = 0x0,
.pmu_mux_offset = 0x84,
+ .iomux_routes = rk3288_mux_route_data,
+ .niomux_routes = ARRAY_SIZE(rk3288_mux_route_data),
.pull_calc_reg = rk3288_calc_pull_reg_and_bit,
.drv_calc_reg = rk3288_calc_drv_reg_and_bit,
};
--
2.14.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
@ 2017-10-14 15:39 ` Heiko Stuebner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2017-10-14 15:39 UTC (permalink / raw)
To: linux-arm-kernel
So far only the hdmi cec supports using one of two different pins
as source, so add the route switching for it.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
If I didn't mess up any numbering, the pinctrl change should look like
the following patch.
Hope that helps
Heiko
drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index b5cb7858ffdc..8dd49e2e144b 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -884,6 +884,24 @@ static struct rockchip_mux_route_data rk3228_mux_route_data[] = {
},
};
+static struct rockchip_mux_route_data rk3288_mux_route_data[] = {
+ {
+ /* edphdmi_cecinoutt1 */
+ .bank_num = 7,
+ .pin = 16,
+ .func = 2,
+ .route_offset = 0x264,
+ .route_val = BIT(16 + 12) | BIT(12),
+ }, {
+ /* edphdmi_cecinout */
+ .bank_num = 7,
+ .pin = 23,
+ .func = 4,
+ .route_offset = 0x264,
+ .route_val = BIT(16 + 12),
+ },
+};
+
static struct rockchip_mux_route_data rk3328_mux_route_data[] = {
{
/* uart2dbg_rxm0 */
@@ -3391,6 +3409,8 @@ static struct rockchip_pin_ctrl rk3288_pin_ctrl = {
.type = RK3288,
.grf_mux_offset = 0x0,
.pmu_mux_offset = 0x84,
+ .iomux_routes = rk3288_mux_route_data,
+ .niomux_routes = ARRAY_SIZE(rk3288_mux_route_data),
.pull_calc_reg = rk3288_calc_pull_reg_and_bit,
.drv_calc_reg = rk3288_calc_drv_reg_and_bit,
};
--
2.14.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
2017-10-14 15:39 ` Heiko Stuebner
@ 2017-10-20 7:28 ` Hans Verkuil
-1 siblings, 0 replies; 14+ messages in thread
From: Hans Verkuil @ 2017-10-20 7:28 UTC (permalink / raw)
To: Heiko Stuebner, Pierre-Hugues Husson
Cc: linux-rockchip, linux-kernel, linux-arm-kernel, linux-media
On 14/10/17 17:39, Heiko Stuebner wrote:
> So far only the hdmi cec supports using one of two different pins
> as source, so add the route switching for it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Just tested this on my firefly reload and it works great!
Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
I'll post some dts patches later today to fully bring up the first HDMI
output on the Firefly Reload.
Will you process this patch further to get it mainlined?
Regards,
Hans
> ---
> If I didn't mess up any numbering, the pinctrl change should look like
> the following patch.
>
> Hope that helps
> Heiko
>
> drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index b5cb7858ffdc..8dd49e2e144b 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -884,6 +884,24 @@ static struct rockchip_mux_route_data rk3228_mux_route_data[] = {
> },
> };
>
> +static struct rockchip_mux_route_data rk3288_mux_route_data[] = {
> + {
> + /* edphdmi_cecinoutt1 */
> + .bank_num = 7,
> + .pin = 16,
> + .func = 2,
> + .route_offset = 0x264,
> + .route_val = BIT(16 + 12) | BIT(12),
> + }, {
> + /* edphdmi_cecinout */
> + .bank_num = 7,
> + .pin = 23,
> + .func = 4,
> + .route_offset = 0x264,
> + .route_val = BIT(16 + 12),
> + },
> +};
> +
> static struct rockchip_mux_route_data rk3328_mux_route_data[] = {
> {
> /* uart2dbg_rxm0 */
> @@ -3391,6 +3409,8 @@ static struct rockchip_pin_ctrl rk3288_pin_ctrl = {
> .type = RK3288,
> .grf_mux_offset = 0x0,
> .pmu_mux_offset = 0x84,
> + .iomux_routes = rk3288_mux_route_data,
> + .niomux_routes = ARRAY_SIZE(rk3288_mux_route_data),
> .pull_calc_reg = rk3288_calc_pull_reg_and_bit,
> .drv_calc_reg = rk3288_calc_drv_reg_and_bit,
> };
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
@ 2017-10-20 7:28 ` Hans Verkuil
0 siblings, 0 replies; 14+ messages in thread
From: Hans Verkuil @ 2017-10-20 7:28 UTC (permalink / raw)
To: linux-arm-kernel
On 14/10/17 17:39, Heiko Stuebner wrote:
> So far only the hdmi cec supports using one of two different pins
> as source, so add the route switching for it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Just tested this on my firefly reload and it works great!
Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
I'll post some dts patches later today to fully bring up the first HDMI
output on the Firefly Reload.
Will you process this patch further to get it mainlined?
Regards,
Hans
> ---
> If I didn't mess up any numbering, the pinctrl change should look like
> the following patch.
>
> Hope that helps
> Heiko
>
> drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index b5cb7858ffdc..8dd49e2e144b 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -884,6 +884,24 @@ static struct rockchip_mux_route_data rk3228_mux_route_data[] = {
> },
> };
>
> +static struct rockchip_mux_route_data rk3288_mux_route_data[] = {
> + {
> + /* edphdmi_cecinoutt1 */
> + .bank_num = 7,
> + .pin = 16,
> + .func = 2,
> + .route_offset = 0x264,
> + .route_val = BIT(16 + 12) | BIT(12),
> + }, {
> + /* edphdmi_cecinout */
> + .bank_num = 7,
> + .pin = 23,
> + .func = 4,
> + .route_offset = 0x264,
> + .route_val = BIT(16 + 12),
> + },
> +};
> +
> static struct rockchip_mux_route_data rk3328_mux_route_data[] = {
> {
> /* uart2dbg_rxm0 */
> @@ -3391,6 +3409,8 @@ static struct rockchip_pin_ctrl rk3288_pin_ctrl = {
> .type = RK3288,
> .grf_mux_offset = 0x0,
> .pmu_mux_offset = 0x84,
> + .iomux_routes = rk3288_mux_route_data,
> + .niomux_routes = ARRAY_SIZE(rk3288_mux_route_data),
> .pull_calc_reg = rk3288_calc_pull_reg_and_bit,
> .drv_calc_reg = rk3288_calc_drv_reg_and_bit,
> };
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
2017-10-20 7:28 ` Hans Verkuil
@ 2017-10-20 7:38 ` Heiko Stübner
-1 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2017-10-20 7:38 UTC (permalink / raw)
To: Hans Verkuil
Cc: Pierre-Hugues Husson, linux-rockchip, linux-kernel,
linux-arm-kernel, linux-media
Hi Hans,
Am Freitag, 20. Oktober 2017, 09:28:58 CEST schrieb Hans Verkuil:
> On 14/10/17 17:39, Heiko Stuebner wrote:
> > So far only the hdmi cec supports using one of two different pins
> > as source, so add the route switching for it.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> Just tested this on my firefly reload and it works great!
>
> Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
oh cool. I really only wrote this based on the soc manual,
so it actually surprises me, that it works on the first try :-)
> I'll post some dts patches later today to fully bring up the first HDMI
> output on the Firefly Reload.
>
> Will you process this patch further to get it mainlined?
Yep, I'll do that.
Heiko
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
@ 2017-10-20 7:38 ` Heiko Stübner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2017-10-20 7:38 UTC (permalink / raw)
To: linux-arm-kernel
Hi Hans,
Am Freitag, 20. Oktober 2017, 09:28:58 CEST schrieb Hans Verkuil:
> On 14/10/17 17:39, Heiko Stuebner wrote:
> > So far only the hdmi cec supports using one of two different pins
> > as source, so add the route switching for it.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> Just tested this on my firefly reload and it works great!
>
> Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
oh cool. I really only wrote this based on the soc manual,
so it actually surprises me, that it works on the first try :-)
> I'll post some dts patches later today to fully bring up the first HDMI
> output on the Firefly Reload.
>
> Will you process this patch further to get it mainlined?
Yep, I'll do that.
Heiko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
2017-10-20 7:38 ` Heiko Stübner
@ 2017-10-20 7:44 ` Hans Verkuil
-1 siblings, 0 replies; 14+ messages in thread
From: Hans Verkuil @ 2017-10-20 7:44 UTC (permalink / raw)
To: Heiko Stübner
Cc: Pierre-Hugues Husson, linux-rockchip, linux-kernel,
linux-arm-kernel, linux-media
On 20/10/17 09:38, Heiko Stübner wrote:
> Hi Hans,
>
> Am Freitag, 20. Oktober 2017, 09:28:58 CEST schrieb Hans Verkuil:
>> On 14/10/17 17:39, Heiko Stuebner wrote:
>>> So far only the hdmi cec supports using one of two different pins
>>> as source, so add the route switching for it.
>>>
>>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>>
>> Just tested this on my firefly reload and it works great!
>>
>> Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> oh cool. I really only wrote this based on the soc manual,
> so it actually surprises me, that it works on the first try :-)
One note though: I've only tested it on my Firefly Reload. I don't have a
regular Firefly, so I can't be certain it works there. Just covering my ass
here :-)
>
>> I'll post some dts patches later today to fully bring up the first HDMI
>> output on the Firefly Reload.
>>
>> Will you process this patch further to get it mainlined?
>
> Yep, I'll do that.
Thanks!
Regards,
Hans
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
@ 2017-10-20 7:44 ` Hans Verkuil
0 siblings, 0 replies; 14+ messages in thread
From: Hans Verkuil @ 2017-10-20 7:44 UTC (permalink / raw)
To: linux-arm-kernel
On 20/10/17 09:38, Heiko St?bner wrote:
> Hi Hans,
>
> Am Freitag, 20. Oktober 2017, 09:28:58 CEST schrieb Hans Verkuil:
>> On 14/10/17 17:39, Heiko Stuebner wrote:
>>> So far only the hdmi cec supports using one of two different pins
>>> as source, so add the route switching for it.
>>>
>>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>>
>> Just tested this on my firefly reload and it works great!
>>
>> Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> oh cool. I really only wrote this based on the soc manual,
> so it actually surprises me, that it works on the first try :-)
One note though: I've only tested it on my Firefly Reload. I don't have a
regular Firefly, so I can't be certain it works there. Just covering my ass
here :-)
>
>> I'll post some dts patches later today to fully bring up the first HDMI
>> output on the Firefly Reload.
>>
>> Will you process this patch further to get it mainlined?
>
> Yep, I'll do that.
Thanks!
Regards,
Hans
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
@ 2017-10-20 16:58 ` Heiko Stübner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2017-10-20 16:58 UTC (permalink / raw)
To: Hans Verkuil
Cc: Pierre-Hugues Husson, linux-rockchip, linux-kernel,
linux-arm-kernel, linux-media
Am Freitag, 20. Oktober 2017, 09:44:55 CEST schrieb Hans Verkuil:
> On 20/10/17 09:38, Heiko Stübner wrote:
> > Hi Hans,
> >
> > Am Freitag, 20. Oktober 2017, 09:28:58 CEST schrieb Hans Verkuil:
> >> On 14/10/17 17:39, Heiko Stuebner wrote:
> >>> So far only the hdmi cec supports using one of two different pins
> >>> as source, so add the route switching for it.
> >>>
> >>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> >>
> >> Just tested this on my firefly reload and it works great!
> >>
> >> Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
> >
> > oh cool. I really only wrote this based on the soc manual,
> > so it actually surprises me, that it works on the first try :-)
>
> One note though: I've only tested it on my Firefly Reload. I don't have a
> regular Firefly, so I can't be certain it works there. Just covering my ass
> here :-)
Haha ... I guess the only thing I could have messed up would be the
ordering (valu0 -> gpio0, value1 -> gpio7 ... and reverse), so if it were
really wrong, you shouldn've have seen any results at all.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
@ 2017-10-20 16:58 ` Heiko Stübner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2017-10-20 16:58 UTC (permalink / raw)
To: linux-arm-kernel
Am Freitag, 20. Oktober 2017, 09:44:55 CEST schrieb Hans Verkuil:
> On 20/10/17 09:38, Heiko St?bner wrote:
> > Hi Hans,
> >
> > Am Freitag, 20. Oktober 2017, 09:28:58 CEST schrieb Hans Verkuil:
> >> On 14/10/17 17:39, Heiko Stuebner wrote:
> >>> So far only the hdmi cec supports using one of two different pins
> >>> as source, so add the route switching for it.
> >>>
> >>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> >>
> >> Just tested this on my firefly reload and it works great!
> >>
> >> Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
> >
> > oh cool. I really only wrote this based on the soc manual,
> > so it actually surprises me, that it works on the first try :-)
>
> One note though: I've only tested it on my Firefly Reload. I don't have a
> regular Firefly, so I can't be certain it works there. Just covering my ass
> here :-)
Haha ... I guess the only thing I could have messed up would be the
ordering (valu0 -> gpio0, value1 -> gpio7 ... and reverse), so if it were
really wrong, you shouldn've have seen any results at all.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288
@ 2017-10-20 16:58 ` Heiko Stübner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2017-10-20 16:58 UTC (permalink / raw)
To: Hans Verkuil
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Pierre-Hugues Husson, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-media-u79uwXL29TY76Z2rM5mHXA
Am Freitag, 20. Oktober 2017, 09:44:55 CEST schrieb Hans Verkuil:
> On 20/10/17 09:38, Heiko Stübner wrote:
> > Hi Hans,
> >
> > Am Freitag, 20. Oktober 2017, 09:28:58 CEST schrieb Hans Verkuil:
> >> On 14/10/17 17:39, Heiko Stuebner wrote:
> >>> So far only the hdmi cec supports using one of two different pins
> >>> as source, so add the route switching for it.
> >>>
> >>> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> >>
> >> Just tested this on my firefly reload and it works great!
> >>
> >> Tested-by: Hans Verkuil <hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
> >
> > oh cool. I really only wrote this based on the soc manual,
> > so it actually surprises me, that it works on the first try :-)
>
> One note though: I've only tested it on my Firefly Reload. I don't have a
> regular Firefly, so I can't be certain it works there. Just covering my ass
> here :-)
Haha ... I guess the only thing I could have messed up would be the
ordering (valu0 -> gpio0, value1 -> gpio7 ... and reverse), so if it were
really wrong, you shouldn've have seen any results at all.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-10-31 9:14 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-21 8:53 [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288 Heiko Stuebner
2017-10-24 1:23 ` David.Wu
2017-10-31 9:14 ` [PATCH] " Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2017-10-13 22:53 [PATCH 0/3] Enable CEC on rk3399 Pierre-Hugues Husson
2017-10-14 13:14 ` Pierre-Hugues Husson
2017-10-14 14:52 ` Heiko Stuebner
2017-10-14 15:39 ` [PATCH] pinctrl: rockchip: Add iomux-route switching support for rk3288 Heiko Stuebner
2017-10-14 15:39 ` Heiko Stuebner
2017-10-20 7:28 ` Hans Verkuil
2017-10-20 7:28 ` Hans Verkuil
2017-10-20 7:38 ` Heiko Stübner
2017-10-20 7:38 ` Heiko Stübner
2017-10-20 7:44 ` Hans Verkuil
2017-10-20 7:44 ` Hans Verkuil
2017-10-20 16:58 ` Heiko Stübner
2017-10-20 16:58 ` Heiko Stübner
2017-10-20 16:58 ` Heiko Stübner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.