From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
ALSA <alsa-devel@alsa-project.org>, Takashi <tiwai@suse.de>,
Pierre <pierre-louis.bossart@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
Shreyas NC <shreyas.nc@intel.com>,
patches.audio@intel.com, alan@linux.intel.com,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Sagar Dharia <sdharia@codeaurora.org>,
srinivas.kandagatla@linaro.org, plai@codeaurora.org,
Sudheer Papothi <spapothi@codeaurora.org>
Subject: Re: [PATCH 10/14] soundwire: Add sysfs for SoundWire DisCo properties
Date: Sat, 21 Oct 2017 10:42:53 +0100 [thread overview]
Message-ID: <20171021094253.45qbp6wzyhifw5vc@sirena.org.uk> (raw)
In-Reply-To: <1508382211-3154-11-git-send-email-vinod.koul@intel.com>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Thu, Oct 19, 2017 at 08:33:26AM +0530, Vinod Koul wrote:
> +static ssize_t clock_frequencies_show(struct sdw_bus *bus,
> + struct sdw_prop_attribute *attr, char *buf)
> +{
> + ssize_t size = 0;
> + int i;
> +
> + for (i = 0; i < bus->prop.num_freq; i++)
> + size += sprintf(buf + size, "%8d\n", bus->prop.freq[i]);
> +
> + return size;
> +}
sysfs is supposed to be one value per file...
> +int sdw_sysfs_slave_init(struct sdw_slave *slave)
> +{
> + /* TODO: Initialize dp0 and dpn kobject and attribute */
> + return 0;
> +}
> +
> +void sdw_sysfs_slave_exit(struct sdw_slave *slave)
> +{
> +}
Seems like an important TODO?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: ALSA <alsa-devel@alsa-project.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Sudheer Papothi <spapothi@codeaurora.org>,
Takashi <tiwai@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
plai@codeaurora.org, LKML <linux-kernel@vger.kernel.org>,
Pierre <pierre-louis.bossart@linux.intel.com>,
patches.audio@intel.com, srinivas.kandagatla@linaro.org,
Shreyas NC <shreyas.nc@intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
Sagar Dharia <sdharia@codeaurora.org>,
alan@linux.intel.com
Subject: Re: [PATCH 10/14] soundwire: Add sysfs for SoundWire DisCo properties
Date: Sat, 21 Oct 2017 10:42:53 +0100 [thread overview]
Message-ID: <20171021094253.45qbp6wzyhifw5vc@sirena.org.uk> (raw)
In-Reply-To: <1508382211-3154-11-git-send-email-vinod.koul@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 633 bytes --]
On Thu, Oct 19, 2017 at 08:33:26AM +0530, Vinod Koul wrote:
> +static ssize_t clock_frequencies_show(struct sdw_bus *bus,
> + struct sdw_prop_attribute *attr, char *buf)
> +{
> + ssize_t size = 0;
> + int i;
> +
> + for (i = 0; i < bus->prop.num_freq; i++)
> + size += sprintf(buf + size, "%8d\n", bus->prop.freq[i]);
> +
> + return size;
> +}
sysfs is supposed to be one value per file...
> +int sdw_sysfs_slave_init(struct sdw_slave *slave)
> +{
> + /* TODO: Initialize dp0 and dpn kobject and attribute */
> + return 0;
> +}
> +
> +void sdw_sysfs_slave_exit(struct sdw_slave *slave)
> +{
> +}
Seems like an important TODO?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-10-21 9:43 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 3:03 [PATCH 00/14] soundwire: Add a new SoundWire subsystem Vinod Koul
2017-10-19 3:03 ` Vinod Koul
2017-10-19 3:03 ` [PATCH 01/14] Documentation: Add SoundWire summary Vinod Koul
2017-10-19 3:33 ` Randy Dunlap
2017-10-19 3:33 ` Randy Dunlap
2017-10-19 4:44 ` Vinod Koul
2017-10-19 4:44 ` Vinod Koul
2017-10-20 10:39 ` Greg Kroah-Hartman
2017-10-20 10:39 ` Greg Kroah-Hartman
2017-10-20 15:49 ` Vinod Koul
2017-10-20 15:49 ` Vinod Koul
2017-10-20 16:22 ` Greg Kroah-Hartman
2017-10-20 16:22 ` Greg Kroah-Hartman
2017-10-20 17:09 ` Vinod Koul
2017-10-20 17:09 ` Vinod Koul
2017-10-21 8:57 ` Mark Brown
2017-10-21 8:57 ` Mark Brown
2017-10-21 11:28 ` Vinod Koul
2017-10-21 11:28 ` Vinod Koul
2017-10-22 10:06 ` [alsa-devel] " Pierre-Louis Bossart
2017-10-23 8:21 ` Mark Brown
2017-10-23 7:50 ` Mark Brown
2017-10-23 7:50 ` Mark Brown
2017-10-23 11:18 ` [alsa-devel] " Vinod Koul
2017-10-19 3:03 ` [PATCH 02/14] soundwire: Add SoundWire bus type Vinod Koul
2017-10-19 7:40 ` Takashi Iwai
2017-10-19 8:32 ` [alsa-devel] " Takashi Iwai
2017-10-19 8:32 ` Takashi Iwai
2017-10-20 5:11 ` Vinod Koul
2017-10-20 5:11 ` Vinod Koul
2017-10-20 6:59 ` Takashi Iwai
2017-10-20 15:46 ` Vinod Koul
2017-10-20 15:50 ` Takashi Iwai
2017-10-20 15:50 ` Takashi Iwai
2017-10-20 16:11 ` Vinod Koul
2017-10-20 10:41 ` Greg Kroah-Hartman
2017-10-20 10:41 ` Greg Kroah-Hartman
2017-10-20 15:52 ` Vinod Koul
2017-10-20 10:45 ` Greg Kroah-Hartman
2017-10-20 16:01 ` Vinod Koul
2017-10-20 16:21 ` Greg Kroah-Hartman
2017-10-20 16:21 ` Greg Kroah-Hartman
2017-10-20 17:10 ` Vinod Koul
2017-10-23 11:46 ` Alan Cox
2017-10-23 11:46 ` Alan Cox
2017-10-26 8:33 ` Vinod Koul
2017-10-26 8:33 ` Vinod Koul
2017-10-27 8:57 ` Greg Kroah-Hartman
2017-10-30 13:11 ` Vinod Koul
2017-10-20 16:03 ` Philippe Ombredanne
2017-10-20 16:20 ` Vinod Koul
2017-10-20 16:20 ` Vinod Koul
2017-10-20 16:27 ` Greg Kroah-Hartman
2017-10-20 17:13 ` Vinod Koul
2017-10-20 17:13 ` Vinod Koul
2017-10-23 11:52 ` Alan Cox
2017-10-23 11:52 ` Alan Cox
2017-10-21 9:03 ` Mark Brown
2017-10-21 11:29 ` Vinod Koul
2017-10-21 11:29 ` Vinod Koul
2017-11-09 21:14 ` Srinivas Kandagatla
2017-11-09 21:14 ` Srinivas Kandagatla
2017-11-10 4:59 ` Vinod Koul
2017-11-10 4:59 ` Vinod Koul
2017-11-10 8:55 ` Vinod Koul
2017-11-10 10:50 ` Srinivas Kandagatla
2017-11-10 10:42 ` Srinivas Kandagatla
2017-11-10 10:42 ` Srinivas Kandagatla
2017-11-10 10:58 ` Vinod Koul
2017-10-19 3:03 ` [PATCH 03/14] soundwire: Add Master registration Vinod Koul
2017-10-19 3:03 ` Vinod Koul
2017-10-19 8:54 ` [alsa-devel] " Takashi Iwai
2017-10-19 8:54 ` Takashi Iwai
2017-10-20 5:19 ` [alsa-devel] " Vinod Koul
2017-10-20 5:19 ` Vinod Koul
2017-10-20 10:47 ` Greg Kroah-Hartman
2017-10-20 16:05 ` Vinod Koul
2017-10-21 9:12 ` Mark Brown
2017-10-21 9:12 ` Mark Brown
2017-10-21 11:35 ` Vinod Koul
2017-10-21 11:35 ` Vinod Koul
2017-10-23 8:24 ` Mark Brown
2017-10-23 8:24 ` Mark Brown
2017-10-23 11:19 ` Vinod Koul
2017-11-09 21:14 ` Srinivas Kandagatla
2017-11-10 5:02 ` Vinod Koul
2017-11-10 5:02 ` Vinod Koul
2017-10-19 3:03 ` [PATCH 04/14] soundwire: Add MIPI DisCo property helpers Vinod Koul
2017-10-19 9:02 ` [alsa-devel] " Takashi Iwai
2017-10-20 5:25 ` Vinod Koul
2017-10-21 9:20 ` Mark Brown
2017-10-21 9:20 ` Mark Brown
2017-10-21 11:37 ` Vinod Koul
2017-10-22 10:14 ` [alsa-devel] " Pierre-Louis Bossart
2017-10-22 10:14 ` Pierre-Louis Bossart
2017-10-19 3:03 ` [PATCH 05/14] soundwire: Add SoundWire MIPI defined registers Vinod Koul
2017-10-19 3:03 ` [PATCH 06/14] soundwire: Add IO transfer Vinod Koul
2017-10-19 3:03 ` Vinod Koul
2017-10-19 9:13 ` [alsa-devel] " Takashi Iwai
2017-10-20 5:30 ` Vinod Koul
2017-10-20 5:30 ` Vinod Koul
2017-10-20 7:06 ` [alsa-devel] " Takashi Iwai
2017-10-20 7:06 ` Takashi Iwai
2017-10-20 15:48 ` [alsa-devel] " Vinod Koul
2017-10-21 9:29 ` Mark Brown
2017-10-21 9:29 ` Mark Brown
2017-10-21 11:40 ` Vinod Koul
2017-10-19 3:03 ` [PATCH 07/14] regmap: Add SoundWire bus support Vinod Koul
2017-10-21 9:34 ` Mark Brown
2017-10-21 9:34 ` Mark Brown
2017-10-21 11:44 ` Vinod Koul
2017-10-23 11:56 ` Alan Cox
2017-10-23 13:16 ` Mark Brown
2017-10-19 3:03 ` [PATCH 08/14] soundwire: Add Slave status handling helpers Vinod Koul
2017-10-19 13:44 ` [alsa-devel] " Takashi Iwai
2017-10-31 13:04 ` Vinod Koul
2017-10-31 13:04 ` Vinod Koul
2017-10-31 21:19 ` [alsa-devel] " Pierre-Louis Bossart
2017-10-31 21:19 ` Pierre-Louis Bossart
2017-11-01 9:08 ` [alsa-devel] " Vinod Koul
2017-11-01 9:08 ` Vinod Koul
2017-11-01 21:10 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-02 3:28 ` Vinod Koul
2017-10-19 3:03 ` [PATCH 09/14] soundwire: Add slave status handling Vinod Koul
2017-10-19 3:03 ` [PATCH 10/14] soundwire: Add sysfs for SoundWire DisCo properties Vinod Koul
2017-10-21 9:42 ` Mark Brown [this message]
2017-10-21 9:42 ` Mark Brown
2017-10-21 11:53 ` Vinod Koul
2017-10-21 11:53 ` Vinod Koul
2017-11-09 21:14 ` Srinivas Kandagatla
2017-11-10 4:52 ` Vinod Koul
2017-10-19 3:03 ` [PATCH 11/14] soundwire: cdns: Add cadence module Vinod Koul
2017-10-21 9:52 ` Mark Brown
2017-10-21 9:52 ` Mark Brown
2017-10-21 11:54 ` Vinod Koul
2017-10-21 11:54 ` Vinod Koul
2017-10-19 3:03 ` [PATCH 12/14] soundwire: cdns: Add sdw_master_ops and IO transfer support Vinod Koul
2017-10-19 3:03 ` [PATCH 13/14] soundwire: intel: Add Intel Master driver Vinod Koul
2017-10-19 3:03 ` [PATCH 14/14] soundwire: intel: Add Intel init module Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021094253.45qbp6wzyhifw5vc@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=plai@codeaurora.org \
--cc=sanyog.r.kale@intel.com \
--cc=sdharia@codeaurora.org \
--cc=shreyas.nc@intel.com \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.