[PATCH v1] mempool/octeontx: remove dead code from gpool2handle

[PATCH v1] mempool/octeontx: remove dead code from gpool2handle

[Santosh Shukla]

Coverity Issue: 195000
Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")

Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
 drivers/mempool/octeontx/octeontx_fpavf.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
index 6bdfc0339..cd36a195d 100644
--- a/drivers/mempool/octeontx/octeontx_fpavf.c
+++ b/drivers/mempool/octeontx/octeontx_fpavf.c
@@ -176,9 +176,6 @@ octeontx_fpa_gpool2handle(uint16_t gpool)
 	RTE_ASSERT(gpool < FPA_VF_MAX);
 
 	res = &fpadev.pool[gpool];
-	if (unlikely(res == NULL))
-		return 0;
-
 	return (uintptr_t)res->bar0 | gpool;
 }
 
-- 
2.13.0

Re: [PATCH v1] mempool/octeontx: remove dead code from gpool2handle

[Jerin Jacob]

-----Original Message-----
> Date: Fri, 20 Oct 2017 15:39:58 +0000
> From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> To: dev@dpdk.org
> Cc: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, Santosh Shukla
>  <santosh.shukla@caviumnetworks.com>
> Subject: [PATCH v1] mempool/octeontx: remove dead code from gpool2handle
> X-Mailer: git-send-email 2.13.0
> 
> Coverity Issue: 195000
> Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")
> 
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/mempool/octeontx/octeontx_fpavf.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
> index 6bdfc0339..cd36a195d 100644
> --- a/drivers/mempool/octeontx/octeontx_fpavf.c
> +++ b/drivers/mempool/octeontx/octeontx_fpavf.c
> @@ -176,9 +176,6 @@ octeontx_fpa_gpool2handle(uint16_t gpool)
>  	RTE_ASSERT(gpool < FPA_VF_MAX);
>  
>  	res = &fpadev.pool[gpool];
> -	if (unlikely(res == NULL))
> -		return 0;
> -
>  	return (uintptr_t)res->bar0 | gpool;
>  }
>  
> -- 
> 2.13.0
> 

Re: [PATCH v1] mempool/octeontx: remove dead code from gpool2handle

[Thomas Monjalon]

> > Coverity Issue: 195000
> > Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")
> > 
> > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied, thanks