Re: [PATCH] eventdev: add API to map file

Re: [PATCH] eventdev: add API to map file

[De Lara Guarch, Pablo]

Hi Nikhil,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nikhil Rao
> Sent: Monday, October 16, 2017 8:37 PM
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] eventdev: add API to map file
> 
> Add rte_event_eth_rx_adapter_service_id_get to map file
> 
> Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>  lib/librte_eventdev/rte_eventdev_version.map | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map
> b/lib/librte_eventdev/rte_eventdev_version.map
> index 828b9a3..8ce2641 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -64,5 +64,5 @@ DPDK_17.11 {
>  	rte_event_eth_rx_adapter_stop;
>  	rte_event_eth_rx_adapter_stats_get;
>  	rte_event_eth_rx_adapter_stats_reset;
> -
> +	rte_event_eth_rx_adapter_service_id_get;

Do not remove the blank line after the functions.
Also, the functions should be listed in alphabetical order.

Thanks,
Pablo

Re: [PATCH] eventdev: add API to map file

[Pavan Nikhilesh Bhagavatula]

On Tue, Oct 17, 2017 at 01:07:26AM +0530, Nikhil Rao wrote:
> Add rte_event_eth_rx_adapter_service_id_get to map file
>
> Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>  lib/librte_eventdev/rte_eventdev_version.map | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
> index 828b9a3..8ce2641 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -64,5 +64,5 @@ DPDK_17.11 {
>  	rte_event_eth_rx_adapter_stop;
>  	rte_event_eth_rx_adapter_stats_get;
>  	rte_event_eth_rx_adapter_stats_reset;
> -
> +	rte_event_eth_rx_adapter_service_id_get;
>  } DPDK_17.08;
> --
> 2.7.4
>

Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

[PATCH] eventdev: add API to map file

[Nikhil Rao]

Add rte_event_eth_rx_adapter_service_id_get to map file

Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
 lib/librte_eventdev/rte_eventdev_version.map | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
index 828b9a3..8ce2641 100644
--- a/lib/librte_eventdev/rte_eventdev_version.map
+++ b/lib/librte_eventdev/rte_eventdev_version.map
@@ -64,5 +64,5 @@ DPDK_17.11 {
 	rte_event_eth_rx_adapter_stop;
 	rte_event_eth_rx_adapter_stats_get;
 	rte_event_eth_rx_adapter_stats_reset;
-
+	rte_event_eth_rx_adapter_service_id_get;
 } DPDK_17.08;
-- 
2.7.4

[PATCH v2] eventdev: add API to map file

[Nikhil Rao]

Add rte_event_eth_rx_adapter_service_id_get to map file. Also order
function names alphabetically.

Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---

v2:
* Re-insert newline after function name list
* Order function names alphabetically

 lib/librte_eventdev/rte_eventdev_version.map | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
index 828b9a340..800ca6e92 100644
--- a/lib/librte_eventdev/rte_eventdev_version.map
+++ b/lib/librte_eventdev/rte_eventdev_version.map
@@ -60,9 +60,10 @@ DPDK_17.11 {
 	rte_event_eth_rx_adapter_free;
 	rte_event_eth_rx_adapter_queue_add;
 	rte_event_eth_rx_adapter_queue_del;
+	rte_event_eth_rx_adapter_service_id_get;
 	rte_event_eth_rx_adapter_start;
-	rte_event_eth_rx_adapter_stop;
 	rte_event_eth_rx_adapter_stats_get;
 	rte_event_eth_rx_adapter_stats_reset;
+	rte_event_eth_rx_adapter_stop;
 
 } DPDK_17.08;
-- 
2.14.1.145.gb3622a4

Re: [PATCH v2] eventdev: add API to map file

[Jerin Jacob]

-----Original Message-----
> Date: Tue, 17 Oct 2017 23:17:45 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org
> Subject: [PATCH v2] eventdev: add API to map file
> X-Mailer: git-send-email 2.7.4
> 
> Add rte_event_eth_rx_adapter_service_id_get to map file. Also order
> function names alphabetically.
> 
> Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>

Please keep the exiting ACKs got earlier in the new revision.

Changed the title to: eventdev: add service get id API to map file

Applied to dpdk-next-eventdev/master. Thanks.

> ---
> 
> v2:
> * Re-insert newline after function name list
> * Order function names alphabetically
> 
>  lib/librte_eventdev/rte_eventdev_version.map | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
> index 828b9a340..800ca6e92 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -60,9 +60,10 @@ DPDK_17.11 {
>  	rte_event_eth_rx_adapter_free;
>  	rte_event_eth_rx_adapter_queue_add;
>  	rte_event_eth_rx_adapter_queue_del;
> +	rte_event_eth_rx_adapter_service_id_get;
>  	rte_event_eth_rx_adapter_start;
> -	rte_event_eth_rx_adapter_stop;
>  	rte_event_eth_rx_adapter_stats_get;
>  	rte_event_eth_rx_adapter_stats_reset;
> +	rte_event_eth_rx_adapter_stop;
>  
>  } DPDK_17.08;
> -- 
> 2.14.1.145.gb3622a4
> 

[PATCH] doc: add event eth Rx adapter library

[Nikhil Rao]

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
 doc/guides/rel_notes/release_17_11.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index 8db35f5..b767da4 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -165,6 +165,11 @@ New Features
   checksums, and doesn't update checksums for output packets.
   Additionally, the GSO library doesn't process IP fragmented packets.
 
+* **Added the Event Ethernet Adapter Library.**
+
+  Added the Event Ethernet Adapter Library library. It provices APIs for
+  eventdev applications to configure the ethdev to eventdev packet flow.
+
 
 Resolved Issues
 ---------------
-- 
2.7.4

Re: [PATCH] doc: add event eth Rx adapter library

[Jerin Jacob]

-----Original Message-----
> Date: Wed, 18 Oct 2017 14:51:41 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org
> Subject: [PATCH] doc: add event eth Rx adapter library
> X-Mailer: git-send-email 2.7.4
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>  doc/guides/rel_notes/release_17_11.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
> index 8db35f5..b767da4 100644
> --- a/doc/guides/rel_notes/release_17_11.rst
> +++ b/doc/guides/rel_notes/release_17_11.rst
> @@ -165,6 +165,11 @@ New Features
>    checksums, and doesn't update checksums for output packets.
>    Additionally, the GSO library doesn't process IP fragmented packets.
>  
> +* **Added the Event Ethernet Adapter Library.**
> +
> +  Added the Event Ethernet Adapter Library library. It provices APIs for

The word Library used twice.

Please add John in all the documentation patches:
CC: John McNamara <john.mcnamara@intel.com>

With above change:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> +  eventdev applications to configure the ethdev to eventdev packet flow.
> +
>  
>  Resolved Issues
>  ---------------
> -- 
> 2.7.4
>