* [PATCH net] net: bridge: fix returning of vlan range op errors
@ 2017-10-19 17:17 ` Nikolay Aleksandrov
0 siblings, 0 replies; 6+ messages in thread
From: Nikolay Aleksandrov @ 2017-10-19 17:17 UTC (permalink / raw)
To: netdev; +Cc: bridge, roopa, stephen, Nikolay Aleksandrov
When vlan tunnels were introduced, vlan range errors got silently
dropped and instead 0 was returned always. Restore the previous
behaviour and return errors to user-space.
Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
---
err should be always set because we have a check for the vid range above
the loop and it must ensure we will go through the loop at least once
net/bridge/br_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 3bc890716c89..de2152730809 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -573,7 +573,7 @@ static int br_process_vlan_info(struct net_bridge *br,
}
*vinfo_last = NULL;
- return 0;
+ return err;
}
return br_vlan_info(br, p, cmd, vinfo_curr);
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Bridge] [PATCH net] net: bridge: fix returning of vlan range op errors
@ 2017-10-19 17:17 ` Nikolay Aleksandrov
0 siblings, 0 replies; 6+ messages in thread
From: Nikolay Aleksandrov @ 2017-10-19 17:17 UTC (permalink / raw)
To: netdev; +Cc: Nikolay Aleksandrov, roopa, bridge
When vlan tunnels were introduced, vlan range errors got silently
dropped and instead 0 was returned always. Restore the previous
behaviour and return errors to user-space.
Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
---
err should be always set because we have a check for the vid range above
the loop and it must ensure we will go through the loop at least once
net/bridge/br_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 3bc890716c89..de2152730809 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -573,7 +573,7 @@ static int br_process_vlan_info(struct net_bridge *br,
}
*vinfo_last = NULL;
- return 0;
+ return err;
}
return br_vlan_info(br, p, cmd, vinfo_curr);
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: bridge: fix returning of vlan range op errors
2017-10-19 17:17 ` [Bridge] " Nikolay Aleksandrov
@ 2017-10-19 22:22 ` Roopa Prabhu
-1 siblings, 0 replies; 6+ messages in thread
From: Roopa Prabhu @ 2017-10-19 22:22 UTC (permalink / raw)
To: Nikolay Aleksandrov; +Cc: netdev, bridge, stephen
On Thu, Oct 19, 2017 at 10:17 AM, Nikolay Aleksandrov
<nikolay@cumulusnetworks.com> wrote:
> When vlan tunnels were introduced, vlan range errors got silently
> dropped and instead 0 was returned always. Restore the previous
> behaviour and return errors to user-space.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bridge] [PATCH net] net: bridge: fix returning of vlan range op errors
@ 2017-10-19 22:22 ` Roopa Prabhu
0 siblings, 0 replies; 6+ messages in thread
From: Roopa Prabhu @ 2017-10-19 22:22 UTC (permalink / raw)
To: Nikolay Aleksandrov; +Cc: netdev, bridge
On Thu, Oct 19, 2017 at 10:17 AM, Nikolay Aleksandrov
<nikolay@cumulusnetworks.com> wrote:
> When vlan tunnels were introduced, vlan range errors got silently
> dropped and instead 0 was returned always. Restore the previous
> behaviour and return errors to user-space.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net: bridge: fix returning of vlan range op errors
2017-10-19 17:17 ` [Bridge] " Nikolay Aleksandrov
@ 2017-10-22 0:52 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2017-10-22 0:52 UTC (permalink / raw)
To: nikolay; +Cc: netdev, bridge, roopa, stephen
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Thu, 19 Oct 2017 20:17:32 +0300
> When vlan tunnels were introduced, vlan range errors got silently
> dropped and instead 0 was returned always. Restore the previous
> behaviour and return errors to user-space.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bridge] [PATCH net] net: bridge: fix returning of vlan range op errors
@ 2017-10-22 0:52 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2017-10-22 0:52 UTC (permalink / raw)
To: nikolay; +Cc: netdev, roopa, bridge
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Thu, 19 Oct 2017 20:17:32 +0300
> When vlan tunnels were introduced, vlan range errors got silently
> dropped and instead 0 was returned always. Restore the previous
> behaviour and return errors to user-space.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-22 0:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-19 17:17 [PATCH net] net: bridge: fix returning of vlan range op errors Nikolay Aleksandrov
2017-10-19 17:17 ` [Bridge] " Nikolay Aleksandrov
2017-10-19 22:22 ` Roopa Prabhu
2017-10-19 22:22 ` [Bridge] " Roopa Prabhu
2017-10-22 0:52 ` David Miller
2017-10-22 0:52 ` [Bridge] " David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.