All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Lee Jones <lee.jones@linaro.org>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Johan Hovold <johan@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Chris Healy <cphealy@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [RESEND PATCH v7 1/1] platform: Add driver for RAVE Supervisory Processor
Date: Mon, 23 Oct 2017 11:31:04 +0200	[thread overview]
Message-ID: <20171023093104.GH32228@amd> (raw)
In-Reply-To: <20171013161700.2anaqwthq4rnco6f@dell>

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Hi!

> > >>  drivers/platform/Kconfig        |   2 +
> > >>  drivers/platform/Makefile       |   1 +
> > >>  drivers/platform/rave/Kconfig   |  26 ++
> > >>  drivers/platform/rave/Makefile  |   1 +
> > >>  drivers/platform/rave/rave-sp.c | 677 ++++++++++++++++++++++++++++++++++++++++
> > >
> > > First of all, why do these live in drivers/platform and why don't use
> > > the mfd subsystem to implement this driver (instead of rolling your own
> > > mfd-implementation)?
> > >
> > 
> > Because when I submitted this driver to MFD Lee Jones told me that it
> > didn't belong to that subsystem and should be added to the kernel in
> > "drivers/platform".
> 
> When I first reviewed this driver, it looked far too complex to be an
> MFD driver.  Most of the code doesn't deal with what I'd expect to be
> handled in MFD.  Why do you have ~600 lines of protocol handling?

Some drivers are more complex than other ones... I don't think that's
unexpected.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2017-10-23  9:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13  6:13 [RESEND PATCH v7 0/1] ZII RAVE platform driver Andrey Smirnov
2017-10-13  6:13 ` [RESEND PATCH v7 1/1] platform: Add driver for RAVE Supervisory Processor Andrey Smirnov
2017-10-13  7:27   ` Johan Hovold
2017-10-13 15:56     ` Andrey Smirnov
2017-10-13 16:17       ` Lee Jones
2017-10-13 16:34         ` Andrey Smirnov
2017-10-24 10:28           ` Lee Jones
2017-10-24 18:34             ` Andrey Smirnov
2017-10-23  9:31         ` Pavel Machek [this message]
2017-10-16 14:14       ` Johan Hovold
2017-10-16 16:45         ` Andrey Smirnov
2017-10-18  7:27           ` Johan Hovold
2017-10-23  9:30     ` Pavel Machek
2017-10-24 15:13       ` Johan Hovold
2017-10-24 18:40         ` Andrey Smirnov
2017-10-25  7:17           ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171023093104.GH32228@amd \
    --to=pavel@ucw.cz \
    --cc=andrew.smirnov@gmail.com \
    --cc=cphealy@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikita.yoush@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.