All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto/qat: fix HMAC supported digest sizes
@ 2017-10-23 10:37 Pablo de Lara
  2017-10-25 11:40 ` Kusztal, ArkadiuszX
  0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2017-10-23 10:37 UTC (permalink / raw)
  To: fiona.trahe, deepak.k.jain, john.griffin; +Cc: dev, Pablo de Lara, stable

For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
digest sizes are not a fixed value, but a range between
1 and the maximum digest size for those algorithms.

Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
Cc: stable@dpdk.org

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 drivers/crypto/qat/qat_crypto_capabilities.h | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/crypto/qat/qat_crypto_capabilities.h b/drivers/crypto/qat/qat_crypto_capabilities.h
index d8d3fa1..89ba27d 100644
--- a/drivers/crypto/qat/qat_crypto_capabilities.h
+++ b/drivers/crypto/qat/qat_crypto_capabilities.h
@@ -48,9 +48,9 @@
 					.increment = 1			\
 				},					\
 				.digest_size = {			\
-					.min = 20,			\
+					.min = 1,			\
 					.max = 20,			\
-					.increment = 0			\
+					.increment = 1			\
 				},					\
 				.iv_size = { 0 }			\
 			}, }						\
@@ -69,9 +69,9 @@
 					.increment = 1			\
 				},					\
 				.digest_size = {			\
-					.min = 28,			\
+					.min = 1,			\
 					.max = 28,			\
-					.increment = 0			\
+					.increment = 1			\
 				},					\
 				.iv_size = { 0 }			\
 			}, }						\
@@ -90,9 +90,9 @@
 					.increment = 1			\
 				},					\
 				.digest_size = {			\
-					.min = 32,			\
+					.min = 1,			\
 					.max = 32,			\
-					.increment = 0			\
+					.increment = 1			\
 				},					\
 				.iv_size = { 0 }			\
 			}, }						\
@@ -111,9 +111,9 @@
 					.increment = 1			\
 				},					\
 				.digest_size = {			\
-					.min = 48,			\
+					.min = 1,			\
 					.max = 48,			\
-					.increment = 0			\
+					.increment = 1			\
 				},					\
 				.iv_size = { 0 }			\
 			}, }						\
@@ -132,9 +132,9 @@
 					.increment = 1			\
 				},					\
 				.digest_size = {			\
-					.min = 64,			\
+					.min = 1,			\
 					.max = 64,			\
-					.increment = 0			\
+					.increment = 1			\
 				},					\
 				.iv_size = { 0 }			\
 			}, }						\
@@ -153,9 +153,9 @@
 					.increment = 1			\
 				},					\
 				.digest_size = {			\
-					.min = 16,			\
+					.min = 1,			\
 					.max = 16,			\
-					.increment = 0			\
+					.increment = 1			\
 				},					\
 				.iv_size = { 0 }			\
 			}, }						\
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto/qat: fix HMAC supported digest sizes
  2017-10-23 10:37 [PATCH] crypto/qat: fix HMAC supported digest sizes Pablo de Lara
@ 2017-10-25 11:40 ` Kusztal, ArkadiuszX
  2017-10-25 16:06   ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 3+ messages in thread
From: Kusztal, ArkadiuszX @ 2017-10-25 11:40 UTC (permalink / raw)
  To: De Lara Guarch, Pablo, Trahe, Fiona, Jain, Deepak K, Griffin, John
  Cc: dev, De Lara Guarch, Pablo, stable



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Monday, October 23, 2017 11:37 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; Griffin, John <john.griffin@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] crypto/qat: fix HMAC supported digest sizes
> 
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported digest sizes are
> not a fixed value, but a range between
> 1 and the maximum digest size for those algorithms.
> 
> Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto/qat: fix HMAC supported digest sizes
  2017-10-25 11:40 ` Kusztal, ArkadiuszX
@ 2017-10-25 16:06   ` De Lara Guarch, Pablo
  0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2017-10-25 16:06 UTC (permalink / raw)
  To: Kusztal, ArkadiuszX, Trahe, Fiona, Jain, Deepak K, Griffin, John
  Cc: dev, stable



> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, October 25, 2017 12:41 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> Griffin, John <john.griffin@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] crypto/qat: fix HMAC supported digest
> sizes
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Monday, October 23, 2017 11:37 AM
> > To: Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> > <deepak.k.jain@intel.com>; Griffin, John <john.griffin@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] crypto/qat: fix HMAC supported digest
> > sizes
> >
> > For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported digest
> sizes
> > are not a fixed value, but a range between
> > 1 and the maximum digest size for those algorithms.
> >
> > Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>

Applied to dpdk-next-crypto.

Pablo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-25 16:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-23 10:37 [PATCH] crypto/qat: fix HMAC supported digest sizes Pablo de Lara
2017-10-25 11:40 ` Kusztal, ArkadiuszX
2017-10-25 16:06   ` De Lara Guarch, Pablo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.