* [PATCH] drm_hwcomposer: remove unnecessary external includes
@ 2017-10-25 0:06 Rob Herring
2017-10-25 2:21 ` Chih-Wei Huang
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2017-10-25 0:06 UTC (permalink / raw)
To: dri-devel
Linking to libraries will add necessary include paths, so we don't need to
list them explicitly.
Still need libsync for sw_sync.h until this dependency is removed.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Android.mk | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/Android.mk b/Android.mk
index 109e352f2a0e..8b11e375adde 100644
--- a/Android.mk
+++ b/Android.mk
@@ -48,11 +48,7 @@ LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
LOCAL_C_INCLUDES := \
external/drm_gralloc \
- external/libdrm \
- external/libdrm/include/drm \
- system/core/include/utils \
- system/core/libsync \
- system/core/libsync/include \
+ system/core/libsync
LOCAL_SRC_FILES := \
autolock.cpp \
--
2.14.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm_hwcomposer: remove unnecessary external includes
2017-10-25 0:06 [PATCH] drm_hwcomposer: remove unnecessary external includes Rob Herring
@ 2017-10-25 2:21 ` Chih-Wei Huang
2017-10-25 7:28 ` Sean Paul
0 siblings, 1 reply; 3+ messages in thread
From: Chih-Wei Huang @ 2017-10-25 2:21 UTC (permalink / raw)
To: Rob Herring; +Cc: ML dri-devel
2017-10-25 8:06 GMT+08:00 Rob Herring <robh@kernel.org>:
> Linking to libraries will add necessary include paths, so we don't need to
> list them explicitly.
>
> Still need libsync for sw_sync.h until this dependency is removed.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Android.mk | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Android.mk b/Android.mk
> index 109e352f2a0e..8b11e375adde 100644
> --- a/Android.mk
> +++ b/Android.mk
> @@ -48,11 +48,7 @@ LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
>
> LOCAL_C_INCLUDES := \
> external/drm_gralloc \
> - external/libdrm \
> - external/libdrm/include/drm \
> - system/core/include/utils \
> - system/core/libsync \
> - system/core/libsync/include \
> + system/core/libsync
>
> LOCAL_SRC_FILES := \
> autolock.cpp \
> --
Looks good to me
Reviewed-and-tested-by: Chih-Wei Huang <cwhuang@linux.org.tw>
--
Chih-Wei
Android-x86 project
http://www.android-x86.org
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm_hwcomposer: remove unnecessary external includes
2017-10-25 2:21 ` Chih-Wei Huang
@ 2017-10-25 7:28 ` Sean Paul
0 siblings, 0 replies; 3+ messages in thread
From: Sean Paul @ 2017-10-25 7:28 UTC (permalink / raw)
To: Chih-Wei Huang; +Cc: ML dri-devel
On Wed, Oct 25, 2017 at 10:21:14AM +0800, Chih-Wei Huang wrote:
> 2017-10-25 8:06 GMT+08:00 Rob Herring <robh@kernel.org>:
> > Linking to libraries will add necessary include paths, so we don't need to
> > list them explicitly.
> >
> > Still need libsync for sw_sync.h until this dependency is removed.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Android.mk | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/Android.mk b/Android.mk
> > index 109e352f2a0e..8b11e375adde 100644
> > --- a/Android.mk
> > +++ b/Android.mk
> > @@ -48,11 +48,7 @@ LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
> >
> > LOCAL_C_INCLUDES := \
> > external/drm_gralloc \
> > - external/libdrm \
> > - external/libdrm/include/drm \
> > - system/core/include/utils \
> > - system/core/libsync \
> > - system/core/libsync/include \
> > + system/core/libsync
> >
> > LOCAL_SRC_FILES := \
> > autolock.cpp \
> > --
>
> Looks good to me
> Reviewed-and-tested-by: Chih-Wei Huang <cwhuang@linux.org.tw>
Applied, thanks for the patch & review.
Sean
>
> --
> Chih-Wei
> Android-x86 project
> http://www.android-x86.org
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-25 7:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-25 0:06 [PATCH] drm_hwcomposer: remove unnecessary external includes Rob Herring
2017-10-25 2:21 ` Chih-Wei Huang
2017-10-25 7:28 ` Sean Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.