From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
David Safford <safford@us.ibm.com>,
David Howells <dhowells@redhat.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
"open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)"
<linux-ima-devel@lists.sourceforge.net>,
"open list:INTEGRITY MEASURE
Subject: Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()
Date: Thu, 26 Oct 2017 16:08:41 +0200 [thread overview]
Message-ID: <20171026140841.6x2lplwijnhwzkqc@linux.intel.com> (raw)
In-Reply-To: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com>
On Thu, Oct 26, 2017 at 03:54:50PM +0200, Jarkko Sakkinen wrote:
> Device number (the character device index) is not a stable identifier
> for a TPM chip. That is the reason why every call site passes
> TPM_ANY_NUM to tpm_chip_find_get().
>
> This commit changes the API in a way that instead a struct tpm_chip
> instance is given and NULL means the default chip. In addition, this
> commit refines the documentation to be up to date with the
> implementation.
>
> Suggested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> (@chip_num -> @chip)
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Jason, once you have given this reviewed-by can you do a patch set that
includes this and your and PrasannaKumar's change? It could be a while
before keyring and IMA maintainers have reviewed my change.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
David Safford <safford@us.ibm.com>,
David Howells <dhowells@redhat.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
"open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)"
<linux-ima-devel@lists.sourceforge.net>open list:INTEGRITY
MEASURE
Subject: Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()
Date: Thu, 26 Oct 2017 14:08:41 +0000 [thread overview]
Message-ID: <20171026140841.6x2lplwijnhwzkqc@linux.intel.com> (raw)
In-Reply-To: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com>
On Thu, Oct 26, 2017 at 03:54:50PM +0200, Jarkko Sakkinen wrote:
> Device number (the character device index) is not a stable identifier
> for a TPM chip. That is the reason why every call site passes
> TPM_ANY_NUM to tpm_chip_find_get().
>
> This commit changes the API in a way that instead a struct tpm_chip
> instance is given and NULL means the default chip. In addition, this
> commit refines the documentation to be up to date with the
> implementation.
>
> Suggested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> (@chip_num -> @chip)
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Jason, once you have given this reviewed-by can you do a patch set that
includes this and your and PrasannaKumar's change? It could be a while
before keyring and IMA maintainers have reviewed my change.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
David Safford <safford@us.ibm.com>,
David Howells <dhowells@redhat.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
"open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)"
<linux-ima-devel@lists.sourceforge.net>,
"open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)"
<linux-ima-user@lists.sourceforge.net>,
"open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)"
<linux-security-module@vger.kernel.org>,
"open list:KEYS-TRUSTED" <keyrings@vger.kernel.org>
Subject: Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()
Date: Thu, 26 Oct 2017 16:08:41 +0200 [thread overview]
Message-ID: <20171026140841.6x2lplwijnhwzkqc@linux.intel.com> (raw)
In-Reply-To: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com>
On Thu, Oct 26, 2017 at 03:54:50PM +0200, Jarkko Sakkinen wrote:
> Device number (the character device index) is not a stable identifier
> for a TPM chip. That is the reason why every call site passes
> TPM_ANY_NUM to tpm_chip_find_get().
>
> This commit changes the API in a way that instead a struct tpm_chip
> instance is given and NULL means the default chip. In addition, this
> commit refines the documentation to be up to date with the
> implementation.
>
> Suggested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> (@chip_num -> @chip)
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Jason, once you have given this reviewed-by can you do a patch set that
includes this and your and PrasannaKumar's change? It could be a while
before keyring and IMA maintainers have reviewed my change.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()
Date: Thu, 26 Oct 2017 16:08:41 +0200 [thread overview]
Message-ID: <20171026140841.6x2lplwijnhwzkqc@linux.intel.com> (raw)
In-Reply-To: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com>
On Thu, Oct 26, 2017 at 03:54:50PM +0200, Jarkko Sakkinen wrote:
> Device number (the character device index) is not a stable identifier
> for a TPM chip. That is the reason why every call site passes
> TPM_ANY_NUM to tpm_chip_find_get().
>
> This commit changes the API in a way that instead a struct tpm_chip
> instance is given and NULL means the default chip. In addition, this
> commit refines the documentation to be up to date with the
> implementation.
>
> Suggested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> (@chip_num -> @chip)
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Jason, once you have given this reviewed-by can you do a patch set that
includes this and your and PrasannaKumar's change? It could be a while
before keyring and IMA maintainers have reviewed my change.
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
David Safford <safford@us.ibm.com>,
David Howells <dhowells@redhat.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
"open list:INTEGRITY MEASUREMENT ARCHITECTURE (IMA)"
<linux-ima-devel@lists.sourceforge.net>open list:INTEGRITY
MEASURE
Subject: Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()
Date: Thu, 26 Oct 2017 16:08:41 +0200 [thread overview]
Message-ID: <20171026140841.6x2lplwijnhwzkqc@linux.intel.com> (raw)
In-Reply-To: <20171026135453.24672-1-jarkko.sakkinen@linux.intel.com>
On Thu, Oct 26, 2017 at 03:54:50PM +0200, Jarkko Sakkinen wrote:
> Device number (the character device index) is not a stable identifier
> for a TPM chip. That is the reason why every call site passes
> TPM_ANY_NUM to tpm_chip_find_get().
>
> This commit changes the API in a way that instead a struct tpm_chip
> instance is given and NULL means the default chip. In addition, this
> commit refines the documentation to be up to date with the
> implementation.
>
> Suggested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> (@chip_num -> @chip)
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Jason, once you have given this reviewed-by can you do a patch set that
includes this and your and PrasannaKumar's change? It could be a while
before keyring and IMA maintainers have reviewed my change.
/Jarkko
next prev parent reply other threads:[~2017-10-26 14:08 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 13:54 [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get() Jarkko Sakkinen
2017-10-26 13:54 ` Jarkko Sakkinen
2017-10-26 13:54 ` Jarkko Sakkinen
2017-10-26 13:54 ` Jarkko Sakkinen
2017-10-26 13:54 ` Jarkko Sakkinen
2017-10-26 14:08 ` Jarkko Sakkinen [this message]
2017-10-26 14:08 ` Jarkko Sakkinen
2017-10-26 14:08 ` Jarkko Sakkinen
2017-10-26 14:08 ` Jarkko Sakkinen
2017-10-26 14:08 ` Jarkko Sakkinen
2017-10-26 14:10 ` PrasannaKumar Muralidharan
2017-10-26 14:22 ` PrasannaKumar Muralidharan
2017-10-26 14:10 ` PrasannaKumar Muralidharan
2017-10-26 14:10 ` PrasannaKumar Muralidharan
2017-10-26 14:10 ` PrasannaKumar Muralidharan
2017-10-26 16:09 ` Jarkko Sakkinen
2017-10-26 16:09 ` Jarkko Sakkinen
2017-10-26 16:09 ` Jarkko Sakkinen
2017-10-26 16:09 ` Jarkko Sakkinen
2017-10-26 16:09 ` Jarkko Sakkinen
[not found] ` <20171026160759.bycrmywqqxtjzpqk-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-26 16:27 ` PrasannaKumar Muralidharan
2017-10-26 16:39 ` PrasannaKumar Muralidharan
2017-10-26 16:27 ` PrasannaKumar Muralidharan
2017-10-26 16:27 ` PrasannaKumar Muralidharan
2017-10-26 16:27 ` PrasannaKumar Muralidharan
2017-10-26 16:50 ` Jason Gunthorpe
2017-10-26 16:50 ` Jason Gunthorpe
2017-10-26 16:50 ` Jason Gunthorpe
2017-10-26 16:50 ` Jason Gunthorpe
2017-10-26 16:50 ` Jason Gunthorpe
2017-10-31 20:03 ` Jason Gunthorpe
2017-10-31 20:03 ` Jason Gunthorpe
2017-10-31 20:03 ` Jason Gunthorpe
2017-10-31 20:03 ` Jason Gunthorpe
2017-11-12 5:23 ` PrasannaKumar Muralidharan
2017-11-12 5:35 ` PrasannaKumar Muralidharan
2017-11-12 5:23 ` PrasannaKumar Muralidharan
2017-11-12 5:23 ` PrasannaKumar Muralidharan
2017-11-14 14:32 ` Jarkko Sakkinen
2017-11-14 14:32 ` Jarkko Sakkinen
2017-11-14 14:32 ` Jarkko Sakkinen
2017-11-14 14:32 ` Jarkko Sakkinen
2018-01-17 14:13 ` PrasannaKumar Muralidharan
2018-01-17 14:25 ` PrasannaKumar Muralidharan
2018-01-17 14:13 ` PrasannaKumar Muralidharan
2018-01-17 14:13 ` PrasannaKumar Muralidharan
2018-01-18 16:20 ` Jarkko Sakkinen
2018-01-18 16:20 ` Jarkko Sakkinen
2018-01-18 16:20 ` Jarkko Sakkinen
2018-01-20 8:00 ` PrasannaKumar Muralidharan
2018-01-20 8:12 ` PrasannaKumar Muralidharan
2018-01-20 8:00 ` PrasannaKumar Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026140841.6x2lplwijnhwzkqc@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=james.l.morris@oracle.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jsnitsel@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=peterhuewe@gmx.de \
--cc=safford@us.ibm.com \
--cc=serge@hallyn.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.