From: Christoffer Dall <cdall@linaro.org> To: Marc Zyngier <marc.zyngier@arm.com> Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara <Andre.Przywara@arm.com> Subject: Re: [PATCH v4 23/26] KVM: arm/arm64: GICv4: Prevent a VM using GICv4 from being saved Date: Thu, 26 Oct 2017 17:28:28 +0200 [thread overview] Message-ID: <20171026152828.GD2166@lvm> (raw) In-Reply-To: <20171006153401.5481-24-marc.zyngier@arm.com> On Fri, Oct 06, 2017 at 04:33:58PM +0100, Marc Zyngier wrote: > The GICv4 architecture doesn't make it easy for save/restore to > work, as it doesn't give any guarantee that the pending state > is written into the pending table. > > So let's not take any chance, and let's return an error if > we encounter any LPI that has the HW bit set. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > --- > virt/kvm/arm/vgic/vgic-its.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c > index f434748439ee..01aa4d9d405e 100644 > --- a/virt/kvm/arm/vgic/vgic-its.c > +++ b/virt/kvm/arm/vgic/vgic-its.c > @@ -1987,6 +1987,15 @@ static int vgic_its_save_itt(struct vgic_its *its, struct its_device *device) > list_for_each_entry(ite, &device->itt_head, ite_list) { > gpa_t gpa = base + ite->event_id * ite_esz; > > + /* > + * If an LPI carries the HW bit, this means that this > + * interrupt is controlled by GICv4, and we do not > + * have direct access to that state. Let's simply fail > + * the save operation... > + */ > + if (ite->irq->hw) > + return -EINVAL; Will this conflict with other error messages, and will QEMU have a reasonable way to tell the user what's going on? Perhaps we shoul document the return code in the ITS device doc and choose something unique, like -EBUSY? Thanks, -Christoffer > + > ret = vgic_its_save_ite(its, device, ite, gpa, ite_esz); > if (ret) > return ret; > -- > 2.14.1 > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: cdall@linaro.org (Christoffer Dall) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 23/26] KVM: arm/arm64: GICv4: Prevent a VM using GICv4 from being saved Date: Thu, 26 Oct 2017 17:28:28 +0200 [thread overview] Message-ID: <20171026152828.GD2166@lvm> (raw) In-Reply-To: <20171006153401.5481-24-marc.zyngier@arm.com> On Fri, Oct 06, 2017 at 04:33:58PM +0100, Marc Zyngier wrote: > The GICv4 architecture doesn't make it easy for save/restore to > work, as it doesn't give any guarantee that the pending state > is written into the pending table. > > So let's not take any chance, and let's return an error if > we encounter any LPI that has the HW bit set. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > --- > virt/kvm/arm/vgic/vgic-its.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c > index f434748439ee..01aa4d9d405e 100644 > --- a/virt/kvm/arm/vgic/vgic-its.c > +++ b/virt/kvm/arm/vgic/vgic-its.c > @@ -1987,6 +1987,15 @@ static int vgic_its_save_itt(struct vgic_its *its, struct its_device *device) > list_for_each_entry(ite, &device->itt_head, ite_list) { > gpa_t gpa = base + ite->event_id * ite_esz; > > + /* > + * If an LPI carries the HW bit, this means that this > + * interrupt is controlled by GICv4, and we do not > + * have direct access to that state. Let's simply fail > + * the save operation... > + */ > + if (ite->irq->hw) > + return -EINVAL; Will this conflict with other error messages, and will QEMU have a reasonable way to tell the user what's going on? Perhaps we shoul document the return code in the ITS device doc and choose something unique, like -EBUSY? Thanks, -Christoffer > + > ret = vgic_its_save_ite(its, device, ite, gpa, ite_esz); > if (ret) > return ret; > -- > 2.14.1 > > _______________________________________________ > kvmarm mailing list > kvmarm at lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2017-10-26 15:28 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-06 15:33 [PATCH v4 00/26] KVM/ARM: Add support for GICv4 Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 01/26] KVM: arm/arm64: register irq bypass consumer on ARM/ARM64 Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 02/26] KVM: arm/arm64: vgic: restructure kvm_vgic_(un)map_phys_irq Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-25 14:44 ` Christoffer Dall 2017-10-25 14:44 ` Christoffer Dall 2017-10-26 13:05 ` Marc Zyngier 2017-10-26 13:05 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 03/26] KVM: arm: Select ARM_GIC_V3 and ARM_GIC_V3_ITS Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 04/26] KVM: arm/arm64: vgic: Move kvm_vgic_destroy call around Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 05/26] KVM: arm/arm64: vITS: Add MSI translation helpers Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 06/26] KVM: arm/arm64: vITS: Add a helper to update the affinity of an LPI Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-25 14:50 ` Christoffer Dall 2017-10-25 14:50 ` Christoffer Dall 2017-10-06 15:33 ` [PATCH v4 07/26] KVM: arm/arm64: GICv4: Add property field and per-VM predicate Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-25 14:54 ` Christoffer Dall 2017-10-25 14:54 ` Christoffer Dall 2017-10-06 15:33 ` [PATCH v4 08/26] KVM: arm/arm64: GICv4: Add init/teardown of the per-VM vPE irq domain Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-25 15:46 ` Christoffer Dall 2017-10-25 15:46 ` Christoffer Dall 2017-10-06 15:33 ` [PATCH v4 09/26] KVM: arm/arm64: GICv4: Wire mapping/unmapping of VLPIs in VFIO irq bypass Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-25 15:58 ` Christoffer Dall 2017-10-25 15:58 ` Christoffer Dall 2017-10-06 15:33 ` [PATCH v4 10/26] KVM: arm/arm64: GICv4: Handle INT command applied to a VLPI Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 11/26] KVM: arm/arm64: GICv4: Unmap VLPI when freeing an LPI Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 12/26] KVM: arm/arm64: GICv4: Propagate affinity changes to the physical ITS Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-25 16:22 ` Christoffer Dall 2017-10-25 16:22 ` Christoffer Dall 2017-10-06 15:33 ` [PATCH v4 13/26] KVM: arm/arm64: GICv4: Handle CLEAR applied to a VLPI Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 14/26] KVM: arm/arm64: GICv4: Handle MOVALL applied to a vPE Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-25 16:27 ` Christoffer Dall 2017-10-25 16:27 ` Christoffer Dall 2017-10-06 15:33 ` [PATCH v4 15/26] KVM: arm/arm64: GICv4: Propagate property updates to VLPIs Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 16/26] KVM: arm/arm64: GICv4: Handle INVALL applied to a vPE Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 17/26] KVM: arm/arm64: GICv4: Propagate VLPI properties at map time Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-25 16:48 ` Christoffer Dall 2017-10-25 16:48 ` Christoffer Dall 2017-10-25 17:01 ` Marc Zyngier 2017-10-25 17:01 ` Marc Zyngier 2017-10-26 8:21 ` Marc Zyngier 2017-10-26 8:21 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 18/26] KVM: arm/arm64: GICv4: Use pending_last as a scheduling hint Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 19/26] KVM: arm/arm64: GICv4: Add doorbell interrupt handling Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-26 14:28 ` Christoffer Dall 2017-10-26 14:28 ` Christoffer Dall 2017-10-26 15:25 ` Christoffer Dall 2017-10-26 15:25 ` Christoffer Dall 2017-10-06 15:33 ` [PATCH v4 20/26] KVM: arm/arm64: GICv4: Use the doorbell interrupt as an unblocking source Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 21/26] KVM: arm/arm64: GICv4: Hook vPE scheduling into vgic flush/sync Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-26 15:24 ` Christoffer Dall 2017-10-26 15:24 ` Christoffer Dall 2017-10-06 15:33 ` [PATCH v4 22/26] KVM: arm/arm64: GICv4: Enable virtual cpuif if VLPIs can be delivered Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:33 ` [PATCH v4 23/26] KVM: arm/arm64: GICv4: Prevent a VM using GICv4 from being saved Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-26 15:28 ` Christoffer Dall [this message] 2017-10-26 15:28 ` Christoffer Dall 2017-10-27 13:56 ` Marc Zyngier 2017-10-27 13:56 ` Marc Zyngier 2017-10-30 6:48 ` Christoffer Dall 2017-10-30 6:48 ` Christoffer Dall 2017-10-06 15:33 ` [PATCH v4 24/26] KVM: arm/arm64: GICv4: Enable VLPI support Marc Zyngier 2017-10-06 15:33 ` Marc Zyngier 2017-10-06 15:34 ` [PATCH v4 25/26] KVM: arm/arm64: GICv4: Prevent heterogenous systems from using GICv4 Marc Zyngier 2017-10-06 15:34 ` Marc Zyngier 2017-10-26 15:31 ` Christoffer Dall 2017-10-26 15:31 ` Christoffer Dall 2017-10-26 15:48 ` Mark Rutland 2017-10-26 15:48 ` Mark Rutland 2017-10-27 6:57 ` Marc Zyngier 2017-10-27 6:57 ` Marc Zyngier 2017-10-27 6:57 ` Marc Zyngier 2017-10-27 7:37 ` Mark Rutland 2017-10-27 7:37 ` Mark Rutland 2017-10-27 7:59 ` Marc Zyngier 2017-10-27 7:59 ` Marc Zyngier 2017-10-27 7:59 ` Marc Zyngier 2017-10-27 8:04 ` Mark Rutland 2017-10-27 8:04 ` Mark Rutland 2017-10-27 8:31 ` Marc Zyngier 2017-10-27 8:31 ` Marc Zyngier 2017-10-27 8:31 ` Marc Zyngier 2017-10-29 2:16 ` Christoffer Dall 2017-10-29 2:16 ` Christoffer Dall 2017-10-06 15:34 ` [PATCH v4 26/26] KVM: arm/arm64: GICv4: Theory of operations Marc Zyngier 2017-10-06 15:34 ` Marc Zyngier 2017-10-26 15:32 ` Christoffer Dall 2017-10-26 15:32 ` Christoffer Dall 2017-10-08 16:45 ` [PATCH v4 00/26] KVM/ARM: Add support for GICv4 Shanker Donthineni 2017-10-08 16:45 ` Shanker Donthineni 2017-10-09 17:52 ` Konrad Rzeszutek Wilk 2017-10-09 17:52 ` Konrad Rzeszutek Wilk 2017-10-09 18:02 ` Marc Zyngier 2017-10-09 18:02 ` Marc Zyngier 2017-10-19 15:48 ` [PATCH v4 27/26] KVM: arm/arm64: GICv4: Prevent userspace from changing doorbell affinity Marc Zyngier 2017-10-19 15:48 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171026152828.GD2166@lvm \ --to=cdall@linaro.org \ --cc=Andre.Przywara@arm.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.