From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: David Ranch <linux-hams@trinnet.net>
Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Ralf Baechle <ralf@linux-mips.org>, walter harms <wharms@bfs.de>,
Kevin Dawson <hal@kd.net.au>, "Bernard, f6bvp" <f6bvp@free.fr>,
Thomas Osterried <thomas@osterried.de>
Subject: Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs
Date: Fri, 27 Oct 2017 14:48:53 -0500 [thread overview]
Message-ID: <20171027144853.Horde.ExzHfROE4gaCiHalihXFClP@gator4166.hostgator.com> (raw)
In-Reply-To: <b0e6de21-b258-dc78-4710-a61b81ec419c@trinnet.net>
Hi David,
Quoting David Ranch <linux-hams@trinnet.net>:
> Hello Gustavo,
>
> I appreciate you working on keeping up the kernel and maintaining
> some of the older feature areas like AX.25, Netrom, etc. Other than
> auditing your code changes, can you tell me what you're changing?
> I've been attempting to find who / where does regression tests for
> the Linus kernel to potentially ADD test suites for this area. In
> the recent past, we have seen a lot of toxicity creep into the
> kernel because no one is testing their changes and backing out this
> toxic code out of released Linux distributions takes a VERY long time.
>
Here you can see the patch I'm proposing to refactor some code:
https://patchwork.kernel.org/patch/10029119/
It does not add any new functionality. It's just a small function that
helps to modularize and reduce the size of the code in the
nr_add_node() function.
The function I'm proposing (re_sort_routes) re-sort the routes in
quality order. It takes as arguments a pointer to the nr_node
structure which contains the routes within and the indexes of the
routes to re-sort.
This function also replaces a "manual" swap of the routes with a call
to the swap macro.
Thanks
--
Gustavo A. R. Silva
> I'm willing to try and help here but I really would like to follow
> some team's guidelines of how they would like tests to be created,
> supported, etc. Be it in VMs, containers, specific automation
> languages, etc.
>
> --David
> KI6ZHD
>
>
>
>
> On 10/26/2017 10:50 PM, Gustavo A. R. Silva wrote:
>> The aim of this patchset is firstly to refactor code in nr_route.c
>> in order to make it
>> easier to read and maintain and, secondly, to mark some expected
>> switch fall-throughs
>> in preparation to enabling -Wimplicit-fallthrough.
>>
>> I have to mention that I did not implement any unit test.
>> If someone has any suggestions on how I could test this piece of code
>> it'd be greatly appreciated.
>>
>> Thanks
>>
>> Changes in v2:
>> - Make use of the swap macro and remove inline keyword as suggested by
>> Walter Harms and Kevin Dawson.
>>
>> Changes in v3:
>> - Update subject for both patches.
>> - Add this cover letter as suggested by David Miller.
>>
>> Gustavo A. R. Silva (2):
>> net: netrom: nr_route: refactor code in nr_add_node
>> net: netrom: nr_route: mark expected switch fall-throughs
>>
>> net/netrom/nr_route.c | 62
>> ++++++++++++++++-----------------------------------
>> 1 file changed, 19 insertions(+), 43 deletions(-)
>>
next prev parent reply other threads:[~2017-10-27 20:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 17:21 [PATCH 1/2] net: netrom: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-19 17:27 ` [PATCH 2/2] net: netrom: refactor code in nr_add_node Gustavo A. R. Silva
2017-10-20 8:57 ` walter harms
2017-10-20 8:57 ` walter harms
2017-10-20 16:06 ` Gustavo A. R. Silva
2017-10-20 16:54 ` walter harms
2017-10-20 23:09 ` Kevin Dawson
2017-10-23 0:41 ` Gustavo A. R. Silva
2017-10-23 1:08 ` [PATCH v2 " Gustavo A. R. Silva
2017-10-23 1:18 ` David Miller
2017-10-23 1:39 ` Gustavo A. R. Silva
2017-10-27 5:50 ` [PATCH v3 0/2] refactor code and mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-27 5:51 ` [PATCH v3 1/2] net: netrom: nr_route: refactor code in nr_add_node Gustavo A. R. Silva
2017-10-27 5:51 ` [PATCH v3 2/2] net: netrom: nr_route: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-27 14:47 ` [PATCH v3 0/2] refactor code and " David Ranch
2017-10-27 19:48 ` Gustavo A. R. Silva [this message]
2017-10-28 17:53 ` David Ranch
2017-10-29 1:45 ` David Miller
2017-10-29 4:15 ` David Ranch
2017-11-08 22:02 ` f6bvp
2017-11-08 22:02 ` f6bvp
2017-11-01 11:46 ` David Miller
2017-11-01 17:34 ` Gustavo A. R. Silva
2017-10-23 16:19 ` Fwd: [PATCH v2 2/2] net: netrom: refactor code in nr_add_node David Ranch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027144853.Horde.ExzHfROE4gaCiHalihXFClP@gator4166.hostgator.com \
--to=garsilva@embeddedor.com \
--cc=davem@davemloft.net \
--cc=f6bvp@free.fr \
--cc=hal@kd.net.au \
--cc=linux-hams@trinnet.net \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=thomas@osterried.de \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.