* [Buildroot] [PATCH v1] qt5base: remove nostrip qmake.conf config option
@ 2017-10-27 16:05 Peter Seiderer
2017-10-27 16:34 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Peter Seiderer @ 2017-10-27 16:05 UTC (permalink / raw)
To: buildroot
Re-enables the qmake default behaviour for qmake projects living
out-side of buildroot (debug build with-out strip, release build with
strip).
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/qt5/qt5base/qmake.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/package/qt5/qt5base/qmake.conf b/package/qt5/qt5base/qmake.conf
index 8b6debe583..b8699ac1f4 100644
--- a/package/qt5/qt5base/qmake.conf
+++ b/package/qt5/qt5base/qmake.conf
@@ -16,7 +16,6 @@ QMAKE_CXX = $${CROSS_COMPILE}g++
QMAKE_CFLAGS += $${BR_COMPILER_CFLAGS}
QMAKE_CXXFLAGS += $${BR_COMPILER_CXXFLAGS}
QMAKE_CXXFLAGS_RELEASE += -O3
-CONFIG += nostrip
QMAKE_LIBS += -lrt -lpthread -ldl
QMAKE_CFLAGS_ISYSTEM =
--
2.14.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] qt5base: remove nostrip qmake.conf config option
2017-10-27 16:05 [Buildroot] [PATCH v1] qt5base: remove nostrip qmake.conf config option Peter Seiderer
@ 2017-10-27 16:34 ` Thomas Petazzoni
2017-10-27 17:30 ` Peter Seiderer
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2017-10-27 16:34 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 27 Oct 2017 18:05:22 +0200, Peter Seiderer wrote:
> Re-enables the qmake default behaviour for qmake projects living
> out-side of buildroot (debug build with-out strip, release build with
> strip).
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
What is the reasoning for this?
I think we do want qmake to *not* strip anything, and leave it to
Buildroot's BR2_STRIP_strip option to decide whether stripping should
happen or not.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] qt5base: remove nostrip qmake.conf config option
2017-10-27 16:34 ` Thomas Petazzoni
@ 2017-10-27 17:30 ` Peter Seiderer
2017-10-27 17:49 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Peter Seiderer @ 2017-10-27 17:30 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Fri, 27 Oct 2017 18:34:41 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 27 Oct 2017 18:05:22 +0200, Peter Seiderer wrote:
> > Re-enables the qmake default behaviour for qmake projects living
> > out-side of buildroot (debug build with-out strip, release build with
> > strip).
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> What is the reasoning for this?
>
> I think we do want qmake to *not* strip anything, and leave it to
> Buildroot's BR2_STRIP_strip option to decide whether stripping should
> happen or not.
Mhhh, I see the reason for the in-buildroot usage of qmake, but still a bit
annoying for out-of-buildroot usage (but maybe a 'qmake CONIFG-=nostrip'
works here), would still prefer to keep the simple/original qmake
default and (maybe) add an additional 'CONFIG+=nostrip' to all in-buildroot
qmake usages?
Regards,
Peter
>
> Thanks!
>
> Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] qt5base: remove nostrip qmake.conf config option
2017-10-27 17:30 ` Peter Seiderer
@ 2017-10-27 17:49 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-10-27 17:49 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 27 Oct 2017 19:30:47 +0200, Peter Seiderer wrote:
> > I think we do want qmake to *not* strip anything, and leave it to
> > Buildroot's BR2_STRIP_strip option to decide whether stripping should
> > happen or not.
>
> Mhhh, I see the reason for the in-buildroot usage of qmake, but still a bit
> annoying for out-of-buildroot usage (but maybe a 'qmake CONIFG-=nostrip'
> works here),
Hum, OK, I see the problem.
> would still prefer to keep the simple/original qmake default and
> (maybe) add an additional 'CONFIG+=nostrip' to all in-buildroot qmake
> usages?
Having to explicitly specify CONFIG+=nostrip to each and every qmake
based package is not going to be very nice. Can we have a Buildroot
specific qmake.conf that inherits a common one, and is used by
Buildroot when building qmake packages ?
Or is it enough to just specify CONFIG+=nostrip in $(QT_QMAKE) and
$(QT5_QMAKE) ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-27 17:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27 16:05 [Buildroot] [PATCH v1] qt5base: remove nostrip qmake.conf config option Peter Seiderer
2017-10-27 16:34 ` Thomas Petazzoni
2017-10-27 17:30 ` Peter Seiderer
2017-10-27 17:49 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.