All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] HAX: kernel/swsusp: Show invalid swap signature
@ 2017-10-27 20:50 Chris Wilson
  2017-10-27 21:46 ` ✗ Fi.CI.BAT: warning for HAX: kernel/swsusp: Show invalid swap signature (rev3) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2017-10-27 20:50 UTC (permalink / raw)
  To: intel-gfx

---
 kernel/power/swap.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index d7cdc426ee38..1eed3fa04e21 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -306,9 +306,12 @@ static int mark_swapfiles(struct swap_map_handle *handle, unsigned int flags)
 {
 	int error;
 
-	hib_submit_io(REQ_OP_READ, 0, swsusp_resume_block,
-		      swsusp_header, NULL);
-	if (!memcmp("SWAP-SPACE",swsusp_header->sig, 10) ||
+	error = hib_submit_io(REQ_OP_READ, 0, swsusp_resume_block,
+			      swsusp_header, NULL);
+	if (error) {
+		printk(KERN_ERR "PM: Unable to read Swap header, error %d.\n",
+		       error);
+	} else if (!memcmp("SWAP-SPACE",swsusp_header->sig, 10) ||
 	    !memcmp("SWAPSPACE2",swsusp_header->sig, 10)) {
 		memcpy(swsusp_header->orig_sig,swsusp_header->sig, 10);
 		memcpy(swsusp_header->sig, HIBERNATE_SIG, 10);
@@ -319,7 +322,8 @@ static int mark_swapfiles(struct swap_map_handle *handle, unsigned int flags)
 		error = hib_submit_io(REQ_OP_WRITE, REQ_SYNC,
 				      swsusp_resume_block, swsusp_header, NULL);
 	} else {
-		printk(KERN_ERR "PM: Swap header not found!\n");
+		printk(KERN_ERR "PM: Swap header not found! Found %10s instead.\n",
+		       swsusp_header->sig);
 		error = -ENODEV;
 	}
 	return error;
-- 
2.15.0.rc2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: warning for HAX: kernel/swsusp: Show invalid swap signature (rev3)
  2017-10-27 20:50 [PATCH] HAX: kernel/swsusp: Show invalid swap signature Chris Wilson
@ 2017-10-27 21:46 ` Patchwork
  2017-10-28  8:47 ` [PATCH] HAX: kernel/swsusp: Show invalid swap signature Chris Wilson
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-27 21:46 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: HAX: kernel/swsusp: Show invalid swap signature (rev3)
URL   : https://patchwork.freedesktop.org/series/32130/
State : warning

== Summary ==

Series 32130v3 HAX: kernel/swsusp: Show invalid swap signature
https://patchwork.freedesktop.org/api/1.0/series/32130/revisions/3/mbox/

Test gem_exec_parallel:
        Subgroup basic:
                pass       -> DMESG-WARN (fi-glk-dsi)
Test gem_exec_reloc:
        Subgroup basic-cpu:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-gtt:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-cpu-gtt:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-gtt-cpu:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-cpu-read:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-gtt-read:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-write-cpu:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-write-gtt:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-write-read:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-cpu-noreloc:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-gtt-noreloc:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-cpu-gtt-noreloc:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-gtt-cpu-noreloc:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-cpu-read-noreloc:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-gtt-read-noreloc:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-write-cpu-noreloc:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-write-gtt-noreloc:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-write-read-noreloc:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-cpu-active:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-gtt-active:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-cpu-gtt-active:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-gtt-cpu-active:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-cpu-read-active:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-gtt-read-active:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-write-cpu-active:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-write-gtt-active:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-write-read-active:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-softpin:
                pass       -> DMESG-WARN (fi-glk-dsi)
Test gem_exec_store:
        Subgroup basic-all:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-blt:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-bsd:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-default:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-render:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-vebox:
                pass       -> DMESG-WARN (fi-glk-dsi)
Test gem_exec_suspend:
        Subgroup basic:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-s3:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic-s4-devices:
                pass       -> DMESG-WARN (fi-glk-dsi)
Test gem_flink_basic:
        Subgroup bad-flink:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup bad-open:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup basic:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup double-flink:
                pass       -> DMESG-WARN (fi-glk-dsi)
        Subgroup flink-lifetime:
                pass       -> DMESG-WARN (fi-glk-dsi)
Test gem_linear_blits:
        Subgroup basic:
                pass       -> DMESG-WARN (fi-glk-dsi)
Test gem_mmap:
        Subgroup basic:
                pass       -> DMESG-WARN (fi-glk-dsi)
WARNING: Long output truncated

d0582552491e17f5e386747f82147c1f2d9158c9 drm-tip: 2017y-10m-27d-19h-16m-21s UTC integration manifest
d1553d2ea2fc HAX: kernel/swsusp: Show invalid swap signature

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6251/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] HAX: kernel/swsusp: Show invalid swap signature
  2017-10-27 20:50 [PATCH] HAX: kernel/swsusp: Show invalid swap signature Chris Wilson
  2017-10-27 21:46 ` ✗ Fi.CI.BAT: warning for HAX: kernel/swsusp: Show invalid swap signature (rev3) Patchwork
@ 2017-10-28  8:47 ` Chris Wilson
  2017-10-28  9:07 ` ✓ Fi.CI.BAT: success for HAX: kernel/swsusp: Show invalid swap signature (rev4) Patchwork
  2017-10-28 10:05 ` ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-10-28  8:47 UTC (permalink / raw)
  To: intel-gfx

---
 kernel/power/swap.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index d7cdc426ee38..1eed3fa04e21 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -306,9 +306,12 @@ static int mark_swapfiles(struct swap_map_handle *handle, unsigned int flags)
 {
 	int error;
 
-	hib_submit_io(REQ_OP_READ, 0, swsusp_resume_block,
-		      swsusp_header, NULL);
-	if (!memcmp("SWAP-SPACE",swsusp_header->sig, 10) ||
+	error = hib_submit_io(REQ_OP_READ, 0, swsusp_resume_block,
+			      swsusp_header, NULL);
+	if (error) {
+		printk(KERN_ERR "PM: Unable to read Swap header, error %d.\n",
+		       error);
+	} else if (!memcmp("SWAP-SPACE",swsusp_header->sig, 10) ||
 	    !memcmp("SWAPSPACE2",swsusp_header->sig, 10)) {
 		memcpy(swsusp_header->orig_sig,swsusp_header->sig, 10);
 		memcpy(swsusp_header->sig, HIBERNATE_SIG, 10);
@@ -319,7 +322,8 @@ static int mark_swapfiles(struct swap_map_handle *handle, unsigned int flags)
 		error = hib_submit_io(REQ_OP_WRITE, REQ_SYNC,
 				      swsusp_resume_block, swsusp_header, NULL);
 	} else {
-		printk(KERN_ERR "PM: Swap header not found!\n");
+		printk(KERN_ERR "PM: Swap header not found! Found %10s instead.\n",
+		       swsusp_header->sig);
 		error = -ENODEV;
 	}
 	return error;
-- 
2.15.0.rc2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for HAX: kernel/swsusp: Show invalid swap signature (rev4)
  2017-10-27 20:50 [PATCH] HAX: kernel/swsusp: Show invalid swap signature Chris Wilson
  2017-10-27 21:46 ` ✗ Fi.CI.BAT: warning for HAX: kernel/swsusp: Show invalid swap signature (rev3) Patchwork
  2017-10-28  8:47 ` [PATCH] HAX: kernel/swsusp: Show invalid swap signature Chris Wilson
@ 2017-10-28  9:07 ` Patchwork
  2017-10-28 10:05 ` ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-28  9:07 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: HAX: kernel/swsusp: Show invalid swap signature (rev4)
URL   : https://patchwork.freedesktop.org/series/32130/
State : success

== Summary ==

Series 32130v4 HAX: kernel/swsusp: Show invalid swap signature
https://patchwork.freedesktop.org/api/1.0/series/32130/revisions/4/mbox/

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:437s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:446s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:370s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:529s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:264s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:493s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:496s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:491s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:477s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:421s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:252s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:580s
fi-glk-dsi       total:289  pass:258  dwarn:0   dfail:0   fail:1   skip:30  time:482s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:427s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:429s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:422s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:493s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:456s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:492s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:571s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:479s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:580s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:545s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:453s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:591s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:645s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:511s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:497s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:455s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:557s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:415s

d0582552491e17f5e386747f82147c1f2d9158c9 drm-tip: 2017y-10m-27d-19h-16m-21s UTC integration manifest
723134d197a9 HAX: kernel/swsusp: Show invalid swap signature

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6255/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for HAX: kernel/swsusp: Show invalid swap signature (rev4)
  2017-10-27 20:50 [PATCH] HAX: kernel/swsusp: Show invalid swap signature Chris Wilson
                   ` (2 preceding siblings ...)
  2017-10-28  9:07 ` ✓ Fi.CI.BAT: success for HAX: kernel/swsusp: Show invalid swap signature (rev4) Patchwork
@ 2017-10-28 10:05 ` Patchwork
  3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-28 10:05 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: HAX: kernel/swsusp: Show invalid swap signature (rev4)
URL   : https://patchwork.freedesktop.org/series/32130/
State : success

== Summary ==

Test kms_busy:
        Subgroup extended-modeset-hang-newfb-with-reset-render-C:
                pass       -> DMESG-WARN (shard-hsw) fdo#102249
Test perf:
        Subgroup oa-exponents:
                fail       -> PASS       (shard-hsw) fdo#102254
Test kms_flip:
        Subgroup dpms-vs-vblank-race:
                pass       -> FAIL       (shard-hsw) fdo#103060 +1
        Subgroup plain-flip-fb-recreate:
                pass       -> FAIL       (shard-hsw) fdo#102504
Test drv_suspend:
        Subgroup fence-restore-untiled:
                skip       -> PASS       (shard-hsw)

fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#102504 https://bugs.freedesktop.org/show_bug.cgi?id=102504

shard-hsw        total:2539 pass:1431 dwarn:1   dfail:0   fail:10  skip:1097 time:9213s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6255/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-28 10:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27 20:50 [PATCH] HAX: kernel/swsusp: Show invalid swap signature Chris Wilson
2017-10-27 21:46 ` ✗ Fi.CI.BAT: warning for HAX: kernel/swsusp: Show invalid swap signature (rev3) Patchwork
2017-10-28  8:47 ` [PATCH] HAX: kernel/swsusp: Show invalid swap signature Chris Wilson
2017-10-28  9:07 ` ✓ Fi.CI.BAT: success for HAX: kernel/swsusp: Show invalid swap signature (rev4) Patchwork
2017-10-28 10:05 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.