* [meta-networking][PATCH] arptables: Fix do_install task
@ 2017-10-30 17:32 Fabio Berton
2017-10-30 23:18 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Berton @ 2017-10-30 17:32 UTC (permalink / raw)
To: openembedded-devel
We need to set DESTDIR variable and run eo_runmake install to install all
arptables files. Without this the only file installed in package is
systemd unit.
Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
---
meta-networking/recipes-support/arptables/arptables_git.bb | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta-networking/recipes-support/arptables/arptables_git.bb b/meta-networking/recipes-support/arptables/arptables_git.bb
index 274a55d91..55903e450 100644
--- a/meta-networking/recipes-support/arptables/arptables_git.bb
+++ b/meta-networking/recipes-support/arptables/arptables_git.bb
@@ -21,9 +21,10 @@ SYSTEMD_SERVICE_${PN} = "arptables.service"
inherit systemd
-EXTRA_OEMAKE = "'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
+EXTRA_OEMAKE += "'DESTDIR=${D}' 'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
-do_install_append() {
+do_install() {
+ oe_runmake install
if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}; then
install -d ${D}${systemd_unitdir}/system
install -m 644 ${WORKDIR}/arptables.service ${D}${systemd_unitdir}/system
--
2.14.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-networking][PATCH] arptables: Fix do_install task
2017-10-30 17:32 [meta-networking][PATCH] arptables: Fix do_install task Fabio Berton
@ 2017-10-30 23:18 ` Khem Raj
2017-10-31 11:24 ` Fabio Berton
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2017-10-30 23:18 UTC (permalink / raw)
To: Fabio Berton; +Cc: openembeded-devel
On Mon, Oct 30, 2017 at 10:32 AM, Fabio Berton
<fabio.berton@ossystems.com.br> wrote:
> We need to set DESTDIR variable and run eo_runmake install to install all
^^
typo
> arptables files. Without this the only file installed in package is
> systemd unit.
>
> Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> ---
> meta-networking/recipes-support/arptables/arptables_git.bb | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta-networking/recipes-support/arptables/arptables_git.bb b/meta-networking/recipes-support/arptables/arptables_git.bb
> index 274a55d91..55903e450 100644
> --- a/meta-networking/recipes-support/arptables/arptables_git.bb
> +++ b/meta-networking/recipes-support/arptables/arptables_git.bb
> @@ -21,9 +21,10 @@ SYSTEMD_SERVICE_${PN} = "arptables.service"
>
> inherit systemd
>
> -EXTRA_OEMAKE = "'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
> +EXTRA_OEMAKE += "'DESTDIR=${D}' 'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
>
if its needed just during install then we could pass it directly in
oe_runmake in do_install below
> -do_install_append() {
> +do_install() {
> + oe_runmake install
> if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}; then
> install -d ${D}${systemd_unitdir}/system
> install -m 644 ${WORKDIR}/arptables.service ${D}${systemd_unitdir}/system
> --
> 2.14.2
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-networking][PATCH] arptables: Fix do_install task
2017-10-30 23:18 ` Khem Raj
@ 2017-10-31 11:24 ` Fabio Berton
2017-10-31 19:07 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Berton @ 2017-10-31 11:24 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
Hi Khem,
do_compile task uses these EXTRA_OEMAKE variables too.
On Mon, Oct 30, 2017 at 9:18 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Mon, Oct 30, 2017 at 10:32 AM, Fabio Berton
> <fabio.berton@ossystems.com.br> wrote:
> > We need to set DESTDIR variable and run eo_runmake install to install all
> ^^
> typo
>
> > arptables files. Without this the only file installed in package is
> > systemd unit.
> >
> > Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> > ---
> > meta-networking/recipes-support/arptables/arptables_git.bb | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-networking/recipes-support/arptables/arptables_git.bb
> b/meta-networking/recipes-support/arptables/arptables_git.bb
> > index 274a55d91..55903e450 100644
> > --- a/meta-networking/recipes-support/arptables/arptables_git.bb
> > +++ b/meta-networking/recipes-support/arptables/arptables_git.bb
> > @@ -21,9 +21,10 @@ SYSTEMD_SERVICE_${PN} = "arptables.service"
> >
> > inherit systemd
> >
> > -EXTRA_OEMAKE = "'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
> > +EXTRA_OEMAKE += "'DESTDIR=${D}' 'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
> >
>
> if its needed just during install then we could pass it directly in
> oe_runmake in do_install below
>
> > -do_install_append() {
> > +do_install() {
> > + oe_runmake install
> > if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true',
> 'false', d)}; then
> > install -d ${D}${systemd_unitdir}/system
> > install -m 644 ${WORKDIR}/arptables.service
> ${D}${systemd_unitdir}/system
> > --
> > 2.14.2
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-networking][PATCH] arptables: Fix do_install task
2017-10-31 11:24 ` Fabio Berton
@ 2017-10-31 19:07 ` Khem Raj
2017-10-31 19:51 ` Fabio Berton
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2017-10-31 19:07 UTC (permalink / raw)
To: Fabio Berton; +Cc: openembeded-devel
On Tue, Oct 31, 2017 at 4:24 AM Fabio Berton <fabio.berton@ossystems.com.br>
wrote:
> Hi Khem,
>
> do_compile task uses these EXTRA_OEMAKE variables too.
>
Yes, however the question is do we use DESTDIR when compiling
>
> On Mon, Oct 30, 2017 at 9:18 PM, Khem Raj <raj.khem@gmail.com> wrote:
>
>> On Mon, Oct 30, 2017 at 10:32 AM, Fabio Berton
>> <fabio.berton@ossystems.com.br> wrote:
>> > We need to set DESTDIR variable and run eo_runmake install to install
>> all
>> ^^
>> typo
>>
>> > arptables files. Without this the only file installed in package is
>> > systemd unit.
>> >
>> > Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
>> > ---
>> > meta-networking/recipes-support/arptables/arptables_git.bb | 5 +++--
>> > 1 file changed, 3 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/meta-networking/recipes-support/arptables/arptables_git.bb
>> b/meta-networking/recipes-support/arptables/arptables_git.bb
>> > index 274a55d91..55903e450 100644
>> > --- a/meta-networking/recipes-support/arptables/arptables_git.bb
>> > +++ b/meta-networking/recipes-support/arptables/arptables_git.bb
>> > @@ -21,9 +21,10 @@ SYSTEMD_SERVICE_${PN} = "arptables.service"
>> >
>> > inherit systemd
>> >
>> > -EXTRA_OEMAKE = "'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
>> > +EXTRA_OEMAKE += "'DESTDIR=${D}' 'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
>> >
>>
>> if its needed just during install then we could pass it directly in
>> oe_runmake in do_install below
>>
>> > -do_install_append() {
>> > +do_install() {
>> > + oe_runmake install
>> > if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true',
>> 'false', d)}; then
>> > install -d ${D}${systemd_unitdir}/system
>> > install -m 644 ${WORKDIR}/arptables.service
>> ${D}${systemd_unitdir}/system
>> > --
>> > 2.14.2
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-devel mailing list
>> > Openembedded-devel@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-networking][PATCH] arptables: Fix do_install task
2017-10-31 19:07 ` Khem Raj
@ 2017-10-31 19:51 ` Fabio Berton
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Berton @ 2017-10-31 19:51 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
You right, work using oe_runmake install DESTDIR=${D} and DESTDIR is not
using when compiling.
Thanks
On Tue, Oct 31, 2017 at 5:07 PM, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Tue, Oct 31, 2017 at 4:24 AM Fabio Berton <
> fabio.berton@ossystems.com.br> wrote:
>
>> Hi Khem,
>>
>> do_compile task uses these EXTRA_OEMAKE variables too.
>>
>
> Yes, however the question is do we use DESTDIR when compiling
>
>>
>> On Mon, Oct 30, 2017 at 9:18 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>
>>> On Mon, Oct 30, 2017 at 10:32 AM, Fabio Berton
>>> <fabio.berton@ossystems.com.br> wrote:
>>> > We need to set DESTDIR variable and run eo_runmake install to install
>>> all
>>>
>>> ^^
>>> typo
>>>
>>> > arptables files. Without this the only file installed in package is
>>> > systemd unit.
>>> >
>>> > Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
>>> > ---
>>> > meta-networking/recipes-support/arptables/arptables_git.bb | 5 +++--
>>> > 1 file changed, 3 insertions(+), 2 deletions(-)
>>> >
>>> > diff --git a/meta-networking/recipes-support/arptables/arptables_
>>> git.bb b/meta-networking/recipes-support/arptables/arptables_git.bb
>>> > index 274a55d91..55903e450 100644
>>> > --- a/meta-networking/recipes-support/arptables/arptables_git.bb
>>> > +++ b/meta-networking/recipes-support/arptables/arptables_git.bb
>>> > @@ -21,9 +21,10 @@ SYSTEMD_SERVICE_${PN} = "arptables.service"
>>> >
>>> > inherit systemd
>>> >
>>> > -EXTRA_OEMAKE = "'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
>>> > +EXTRA_OEMAKE += "'DESTDIR=${D}' 'BINDIR=${sbindir}'
>>> 'MANDIR=${mandir}'"
>>> >
>>>
>>> if its needed just during install then we could pass it directly in
>>> oe_runmake in do_install below
>>>
>>> > -do_install_append() {
>>> > +do_install() {
>>> > + oe_runmake install
>>> > if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true',
>>> 'false', d)}; then
>>> > install -d ${D}${systemd_unitdir}/system
>>> > install -m 644 ${WORKDIR}/arptables.service
>>> ${D}${systemd_unitdir}/system
>>> > --
>>> > 2.14.2
>>> >
>>> > --
>>> > _______________________________________________
>>> > Openembedded-devel mailing list
>>> > Openembedded-devel@lists.openembedded.org
>>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-31 19:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30 17:32 [meta-networking][PATCH] arptables: Fix do_install task Fabio Berton
2017-10-30 23:18 ` Khem Raj
2017-10-31 11:24 ` Fabio Berton
2017-10-31 19:07 ` Khem Raj
2017-10-31 19:51 ` Fabio Berton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.