* [PATCH 0/2] remoteproc: increase debug capabilities @ 2017-10-27 12:41 ` Loic Pallardy 0 siblings, 0 replies; 12+ messages in thread From: Loic Pallardy @ 2017-10-27 12:41 UTC (permalink / raw) To: bjorn.andersson, ohad Cc: linux-remoteproc, linux-kernel, arnaud.pouliquen, Loic Pallardy This series increases remoteproc debug capabilities by adding: - associated resource table dump feature - registered carveouts list dump feature Loic Pallardy (2): remoteproc: debug: add resource table dump feature remoteproc: debug: add carveouts list dump feature drivers/remoteproc/remoteproc_debugfs.c | 130 ++++++++++++++++++++++++++++++++ 1 file changed, 130 insertions(+) -- 1.9.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] remoteproc: increase debug capabilities @ 2017-10-27 12:41 ` Loic Pallardy 0 siblings, 0 replies; 12+ messages in thread From: Loic Pallardy @ 2017-10-27 12:41 UTC (permalink / raw) To: bjorn.andersson, ohad Cc: linux-remoteproc, linux-kernel, arnaud.pouliquen, Loic Pallardy This series increases remoteproc debug capabilities by adding: - associated resource table dump feature - registered carveouts list dump feature Loic Pallardy (2): remoteproc: debug: add resource table dump feature remoteproc: debug: add carveouts list dump feature drivers/remoteproc/remoteproc_debugfs.c | 130 ++++++++++++++++++++++++++++++++ 1 file changed, 130 insertions(+) -- 1.9.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] remoteproc: debug: add resource table dump feature 2017-10-27 12:41 ` Loic Pallardy @ 2017-10-27 12:41 ` Loic Pallardy -1 siblings, 0 replies; 12+ messages in thread From: Loic Pallardy @ 2017-10-27 12:41 UTC (permalink / raw) To: bjorn.andersson, ohad Cc: linux-remoteproc, linux-kernel, arnaud.pouliquen, Loic Pallardy This patch adds the capability to display the content of the resource table associated to a remote processor firmware. Signed-off-by: Loic Pallardy <loic.pallardy@st.com> --- drivers/remoteproc/remoteproc_debugfs.c | 99 +++++++++++++++++++++++++++++++++ 1 file changed, 99 insertions(+) diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c index 1c122e2..c1c9f58 100644 --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -155,6 +155,103 @@ static ssize_t rproc_recovery_read(struct file *filp, char __user *userbuf, .llseek = generic_file_llseek, }; +/* Expose resource table content via debugfs */ +static int rproc_rsc_table_show(struct seq_file *seq, void *p) +{ + static const char * const types[] = {"carveout", "devmem", "trace", "vdev"}; + struct rproc *rproc = seq->private; + struct resource_table *table = rproc->table_ptr; + struct fw_rsc_carveout *c; + struct fw_rsc_devmem *d; + struct fw_rsc_trace *t; + struct fw_rsc_vdev *v; + int i, j; + + if (!table) { + seq_puts(seq, "No resource table found\n"); + return 0; + } + + for (i = 0; i < table->num; i++) { + int offset = table->offset[i]; + struct fw_rsc_hdr *hdr = (void *)table + offset; + void *rsc = (void *)hdr + sizeof(*hdr); + + switch (hdr->type) { + case RSC_CARVEOUT: + c = rsc; + seq_printf(seq, "Entry %d is of type %s\n", i, types[hdr->type]); + seq_printf(seq, " Device Address 0x%x\n", c->da); + seq_printf(seq, " Physical Address 0x%x\n", c->pa); + seq_printf(seq, " Length 0x%x Bytes\n", c->len); + seq_printf(seq, " Flags 0x%x\n", c->flags); + seq_printf(seq, " Reserved (should be zero) [%d]\n", c->reserved); + seq_printf(seq, " Name %s\n\n", c->name); + break; + case RSC_DEVMEM: + d = rsc; + seq_printf(seq, "Entry %d is of type %s\n", i, types[hdr->type]); + seq_printf(seq, " Device Address 0x%x\n", d->da); + seq_printf(seq, " Physical Address 0x%x\n", d->pa); + seq_printf(seq, " Length 0x%x Bytes\n", d->len); + seq_printf(seq, " Flags 0x%x\n", d->flags); + seq_printf(seq, " Reserved (should be zero) [%d]\n", d->reserved); + seq_printf(seq, " Name %s\n\n", d->name); + break; + case RSC_TRACE: + t = rsc; + seq_printf(seq, "Entry %d is of type %s\n", i, types[hdr->type]); + seq_printf(seq, " Device Address 0x%x\n", t->da); + seq_printf(seq, " Length 0x%x Bytes\n", t->len); + seq_printf(seq, " Reserved (should be zero) [%d]\n", t->reserved); + seq_printf(seq, " Name %s\n\n", t->name); + break; + case RSC_VDEV: + v = rsc; + seq_printf(seq, "Entry %d is of type %s\n", i, types[hdr->type]); + + seq_printf(seq, " ID %d\n", v->id); + seq_printf(seq, " Notify ID %d\n", v->notifyid); + seq_printf(seq, " Device features 0x%x\n", v->dfeatures); + seq_printf(seq, " Guest features 0x%x\n", v->gfeatures); + seq_printf(seq, " Config length 0x%x\n", v->config_len); + seq_printf(seq, " Status 0x%x\n", v->status); + seq_printf(seq, " Number of vrings %d\n", v->num_of_vrings); + seq_printf(seq, " Reserved (should be zero) [%d][%d]\n\n", + v->reserved[0], v->reserved[1]); + + for (j = 0; j < v->num_of_vrings; j++) { + seq_printf(seq, " Vring %d\n", j); + seq_printf(seq, " Device Address 0x%x\n", v->vring[j].da); + seq_printf(seq, " Alignment %d\n", v->vring[j].align); + seq_printf(seq, " Number of buffers %d\n", v->vring[j].num); + seq_printf(seq, " Notify ID %d\n", v->vring[j].notifyid); + seq_printf(seq, " Physical Address 0x%x\n\n", + v->vring[j].pa); + } + break; + default: + seq_printf(seq, "Unknown resource type found: %d [hdr: %p]\n", + hdr->type, hdr); + break; + } + } + + return 0; +} + +static ssize_t rproc_rsc_table_open(struct inode *inode, struct file *file) +{ + return single_open(file, rproc_rsc_table_show, inode->i_private); +} + +static const struct file_operations rproc_rsc_table_ops = { + .open = rproc_rsc_table_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + void rproc_remove_trace_file(struct dentry *tfile) { debugfs_remove(tfile); @@ -198,6 +295,8 @@ void rproc_create_debug_dir(struct rproc *rproc) rproc, &rproc_name_ops); debugfs_create_file("recovery", 0400, rproc->dbg_dir, rproc, &rproc_recovery_ops); + debugfs_create_file("resource_table", 0400, rproc->dbg_dir, + rproc, &rproc_rsc_table_ops); } void __init rproc_init_debugfs(void) -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] remoteproc: debug: add resource table dump feature @ 2017-10-27 12:41 ` Loic Pallardy 0 siblings, 0 replies; 12+ messages in thread From: Loic Pallardy @ 2017-10-27 12:41 UTC (permalink / raw) To: bjorn.andersson, ohad Cc: linux-remoteproc, linux-kernel, arnaud.pouliquen, Loic Pallardy This patch adds the capability to display the content of the resource table associated to a remote processor firmware. Signed-off-by: Loic Pallardy <loic.pallardy@st.com> --- drivers/remoteproc/remoteproc_debugfs.c | 99 +++++++++++++++++++++++++++++++++ 1 file changed, 99 insertions(+) diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c index 1c122e2..c1c9f58 100644 --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -155,6 +155,103 @@ static ssize_t rproc_recovery_read(struct file *filp, char __user *userbuf, .llseek = generic_file_llseek, }; +/* Expose resource table content via debugfs */ +static int rproc_rsc_table_show(struct seq_file *seq, void *p) +{ + static const char * const types[] = {"carveout", "devmem", "trace", "vdev"}; + struct rproc *rproc = seq->private; + struct resource_table *table = rproc->table_ptr; + struct fw_rsc_carveout *c; + struct fw_rsc_devmem *d; + struct fw_rsc_trace *t; + struct fw_rsc_vdev *v; + int i, j; + + if (!table) { + seq_puts(seq, "No resource table found\n"); + return 0; + } + + for (i = 0; i < table->num; i++) { + int offset = table->offset[i]; + struct fw_rsc_hdr *hdr = (void *)table + offset; + void *rsc = (void *)hdr + sizeof(*hdr); + + switch (hdr->type) { + case RSC_CARVEOUT: + c = rsc; + seq_printf(seq, "Entry %d is of type %s\n", i, types[hdr->type]); + seq_printf(seq, " Device Address 0x%x\n", c->da); + seq_printf(seq, " Physical Address 0x%x\n", c->pa); + seq_printf(seq, " Length 0x%x Bytes\n", c->len); + seq_printf(seq, " Flags 0x%x\n", c->flags); + seq_printf(seq, " Reserved (should be zero) [%d]\n", c->reserved); + seq_printf(seq, " Name %s\n\n", c->name); + break; + case RSC_DEVMEM: + d = rsc; + seq_printf(seq, "Entry %d is of type %s\n", i, types[hdr->type]); + seq_printf(seq, " Device Address 0x%x\n", d->da); + seq_printf(seq, " Physical Address 0x%x\n", d->pa); + seq_printf(seq, " Length 0x%x Bytes\n", d->len); + seq_printf(seq, " Flags 0x%x\n", d->flags); + seq_printf(seq, " Reserved (should be zero) [%d]\n", d->reserved); + seq_printf(seq, " Name %s\n\n", d->name); + break; + case RSC_TRACE: + t = rsc; + seq_printf(seq, "Entry %d is of type %s\n", i, types[hdr->type]); + seq_printf(seq, " Device Address 0x%x\n", t->da); + seq_printf(seq, " Length 0x%x Bytes\n", t->len); + seq_printf(seq, " Reserved (should be zero) [%d]\n", t->reserved); + seq_printf(seq, " Name %s\n\n", t->name); + break; + case RSC_VDEV: + v = rsc; + seq_printf(seq, "Entry %d is of type %s\n", i, types[hdr->type]); + + seq_printf(seq, " ID %d\n", v->id); + seq_printf(seq, " Notify ID %d\n", v->notifyid); + seq_printf(seq, " Device features 0x%x\n", v->dfeatures); + seq_printf(seq, " Guest features 0x%x\n", v->gfeatures); + seq_printf(seq, " Config length 0x%x\n", v->config_len); + seq_printf(seq, " Status 0x%x\n", v->status); + seq_printf(seq, " Number of vrings %d\n", v->num_of_vrings); + seq_printf(seq, " Reserved (should be zero) [%d][%d]\n\n", + v->reserved[0], v->reserved[1]); + + for (j = 0; j < v->num_of_vrings; j++) { + seq_printf(seq, " Vring %d\n", j); + seq_printf(seq, " Device Address 0x%x\n", v->vring[j].da); + seq_printf(seq, " Alignment %d\n", v->vring[j].align); + seq_printf(seq, " Number of buffers %d\n", v->vring[j].num); + seq_printf(seq, " Notify ID %d\n", v->vring[j].notifyid); + seq_printf(seq, " Physical Address 0x%x\n\n", + v->vring[j].pa); + } + break; + default: + seq_printf(seq, "Unknown resource type found: %d [hdr: %p]\n", + hdr->type, hdr); + break; + } + } + + return 0; +} + +static ssize_t rproc_rsc_table_open(struct inode *inode, struct file *file) +{ + return single_open(file, rproc_rsc_table_show, inode->i_private); +} + +static const struct file_operations rproc_rsc_table_ops = { + .open = rproc_rsc_table_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + void rproc_remove_trace_file(struct dentry *tfile) { debugfs_remove(tfile); @@ -198,6 +295,8 @@ void rproc_create_debug_dir(struct rproc *rproc) rproc, &rproc_name_ops); debugfs_create_file("recovery", 0400, rproc->dbg_dir, rproc, &rproc_recovery_ops); + debugfs_create_file("resource_table", 0400, rproc->dbg_dir, + rproc, &rproc_rsc_table_ops); } void __init rproc_init_debugfs(void) -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] remoteproc: debug: add resource table dump feature 2017-10-27 12:41 ` Loic Pallardy @ 2017-10-30 10:35 ` kbuild test robot -1 siblings, 0 replies; 12+ messages in thread From: kbuild test robot @ 2017-10-30 10:35 UTC (permalink / raw) To: Loic Pallardy Cc: kbuild-all, bjorn.andersson, ohad, linux-remoteproc, linux-kernel, arnaud.pouliquen [-- Attachment #1: Type: text/plain, Size: 1406 bytes --] Hi Loic, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.14-rc6] [also build test ERROR on next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Loic-Pallardy/remoteproc-increase-debug-capabilities/20171030-174235 config: x86_64-randconfig-x018-201744 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers//remoteproc/remoteproc_debugfs.c:249:11: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .open = rproc_rsc_table_open, ^~~~~~~~~~~~~~~~~~~~ drivers//remoteproc/remoteproc_debugfs.c:249:11: note: (near initialization for 'rproc_rsc_table_ops.open') cc1: some warnings being treated as errors vim +249 drivers//remoteproc/remoteproc_debugfs.c 247 248 static const struct file_operations rproc_rsc_table_ops = { > 249 .open = rproc_rsc_table_open, 250 .read = seq_read, 251 .llseek = seq_lseek, 252 .release = single_release, 253 }; 254 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 31066 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] remoteproc: debug: add resource table dump feature @ 2017-10-30 10:35 ` kbuild test robot 0 siblings, 0 replies; 12+ messages in thread From: kbuild test robot @ 2017-10-30 10:35 UTC (permalink / raw) To: Loic Pallardy Cc: kbuild-all, bjorn.andersson, ohad, linux-remoteproc, linux-kernel, arnaud.pouliquen, Loic Pallardy [-- Attachment #1: Type: text/plain, Size: 1406 bytes --] Hi Loic, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.14-rc6] [also build test ERROR on next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Loic-Pallardy/remoteproc-increase-debug-capabilities/20171030-174235 config: x86_64-randconfig-x018-201744 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers//remoteproc/remoteproc_debugfs.c:249:11: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .open = rproc_rsc_table_open, ^~~~~~~~~~~~~~~~~~~~ drivers//remoteproc/remoteproc_debugfs.c:249:11: note: (near initialization for 'rproc_rsc_table_ops.open') cc1: some warnings being treated as errors vim +249 drivers//remoteproc/remoteproc_debugfs.c 247 248 static const struct file_operations rproc_rsc_table_ops = { > 249 .open = rproc_rsc_table_open, 250 .read = seq_read, 251 .llseek = seq_lseek, 252 .release = single_release, 253 }; 254 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 31066 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] remoteproc: debug: add resource table dump feature 2017-10-27 12:41 ` Loic Pallardy @ 2017-10-30 11:46 ` kbuild test robot -1 siblings, 0 replies; 12+ messages in thread From: kbuild test robot @ 2017-10-30 11:46 UTC (permalink / raw) To: Loic Pallardy Cc: kbuild-all, bjorn.andersson, ohad, linux-remoteproc, linux-kernel, arnaud.pouliquen [-- Attachment #1: Type: text/plain, Size: 1427 bytes --] Hi Loic, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.14-rc6] [also build test WARNING on next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Loic-Pallardy/remoteproc-increase-debug-capabilities/20171030-174235 config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=tile All warnings (new ones prefixed by >>): >> drivers/remoteproc/remoteproc_debugfs.c:249:2: warning: initialization from incompatible pointer type [enabled by default] drivers/remoteproc/remoteproc_debugfs.c:249:2: warning: (near initialization for 'rproc_rsc_table_ops.open') [enabled by default] vim +249 drivers/remoteproc/remoteproc_debugfs.c 247 248 static const struct file_operations rproc_rsc_table_ops = { > 249 .open = rproc_rsc_table_open, 250 .read = seq_read, 251 .llseek = seq_lseek, 252 .release = single_release, 253 }; 254 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 50480 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] remoteproc: debug: add resource table dump feature @ 2017-10-30 11:46 ` kbuild test robot 0 siblings, 0 replies; 12+ messages in thread From: kbuild test robot @ 2017-10-30 11:46 UTC (permalink / raw) To: Loic Pallardy Cc: kbuild-all, bjorn.andersson, ohad, linux-remoteproc, linux-kernel, arnaud.pouliquen, Loic Pallardy [-- Attachment #1: Type: text/plain, Size: 1427 bytes --] Hi Loic, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.14-rc6] [also build test WARNING on next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Loic-Pallardy/remoteproc-increase-debug-capabilities/20171030-174235 config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=tile All warnings (new ones prefixed by >>): >> drivers/remoteproc/remoteproc_debugfs.c:249:2: warning: initialization from incompatible pointer type [enabled by default] drivers/remoteproc/remoteproc_debugfs.c:249:2: warning: (near initialization for 'rproc_rsc_table_ops.open') [enabled by default] vim +249 drivers/remoteproc/remoteproc_debugfs.c 247 248 static const struct file_operations rproc_rsc_table_ops = { > 249 .open = rproc_rsc_table_open, 250 .read = seq_read, 251 .llseek = seq_lseek, 252 .release = single_release, 253 }; 254 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 50480 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] remoteproc: debug: add carveouts list dump feature 2017-10-27 12:41 ` Loic Pallardy @ 2017-10-27 12:41 ` Loic Pallardy -1 siblings, 0 replies; 12+ messages in thread From: Loic Pallardy @ 2017-10-27 12:41 UTC (permalink / raw) To: bjorn.andersson, ohad Cc: linux-remoteproc, linux-kernel, arnaud.pouliquen, Loic Pallardy This patch offers the capability to dump memory carveouts associated to one remoteprocessor. Signed-off-by: Loic Pallardy <loic.pallardy@st.com> --- drivers/remoteproc/remoteproc_debugfs.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c index c1c9f58..982e6a7 100644 --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -252,6 +252,35 @@ static ssize_t rproc_rsc_table_open(struct inode *inode, struct file *file) .release = single_release, }; +/* Expose carveout content via debugfs */ +static int rproc_carveouts_show(struct seq_file *seq, void *p) +{ + struct rproc *rproc = seq->private; + struct rproc_mem_entry *carveout; + + list_for_each_entry(carveout, &rproc->carveouts, node) { + seq_puts(seq, "Carveout memory entry:\n"); + seq_printf(seq, "\tVirtual address: %p\n", carveout->va); + seq_printf(seq, "\tDMA address: %pad\n", &carveout->dma); + seq_printf(seq, "\tDevice address: 0x%x\n", carveout->da); + seq_printf(seq, "\tLength: 0x%x Bytes\n\n", carveout->len); + } + + return 0; +} + +static ssize_t rproc_carveouts_open(struct inode *inode, struct file *file) +{ + return single_open(file, rproc_carveouts_show, inode->i_private); +} + +static const struct file_operations rproc_carveouts_ops = { + .open = rproc_carveouts_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + void rproc_remove_trace_file(struct dentry *tfile) { debugfs_remove(tfile); @@ -297,6 +326,8 @@ void rproc_create_debug_dir(struct rproc *rproc) rproc, &rproc_recovery_ops); debugfs_create_file("resource_table", 0400, rproc->dbg_dir, rproc, &rproc_rsc_table_ops); + debugfs_create_file("carveout_memories", 0400, rproc->dbg_dir, + rproc, &rproc_carveouts_ops); } void __init rproc_init_debugfs(void) -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] remoteproc: debug: add carveouts list dump feature @ 2017-10-27 12:41 ` Loic Pallardy 0 siblings, 0 replies; 12+ messages in thread From: Loic Pallardy @ 2017-10-27 12:41 UTC (permalink / raw) To: bjorn.andersson, ohad Cc: linux-remoteproc, linux-kernel, arnaud.pouliquen, Loic Pallardy This patch offers the capability to dump memory carveouts associated to one remoteprocessor. Signed-off-by: Loic Pallardy <loic.pallardy@st.com> --- drivers/remoteproc/remoteproc_debugfs.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c index c1c9f58..982e6a7 100644 --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -252,6 +252,35 @@ static ssize_t rproc_rsc_table_open(struct inode *inode, struct file *file) .release = single_release, }; +/* Expose carveout content via debugfs */ +static int rproc_carveouts_show(struct seq_file *seq, void *p) +{ + struct rproc *rproc = seq->private; + struct rproc_mem_entry *carveout; + + list_for_each_entry(carveout, &rproc->carveouts, node) { + seq_puts(seq, "Carveout memory entry:\n"); + seq_printf(seq, "\tVirtual address: %p\n", carveout->va); + seq_printf(seq, "\tDMA address: %pad\n", &carveout->dma); + seq_printf(seq, "\tDevice address: 0x%x\n", carveout->da); + seq_printf(seq, "\tLength: 0x%x Bytes\n\n", carveout->len); + } + + return 0; +} + +static ssize_t rproc_carveouts_open(struct inode *inode, struct file *file) +{ + return single_open(file, rproc_carveouts_show, inode->i_private); +} + +static const struct file_operations rproc_carveouts_ops = { + .open = rproc_carveouts_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + void rproc_remove_trace_file(struct dentry *tfile) { debugfs_remove(tfile); @@ -297,6 +326,8 @@ void rproc_create_debug_dir(struct rproc *rproc) rproc, &rproc_recovery_ops); debugfs_create_file("resource_table", 0400, rproc->dbg_dir, rproc, &rproc_rsc_table_ops); + debugfs_create_file("carveout_memories", 0400, rproc->dbg_dir, + rproc, &rproc_carveouts_ops); } void __init rproc_init_debugfs(void) -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] remoteproc: increase debug capabilities 2017-10-27 12:41 ` Loic Pallardy ` (2 preceding siblings ...) (?) @ 2017-10-31 4:21 ` Bjorn Andersson 2017-11-06 16:51 ` Loic PALLARDY -1 siblings, 1 reply; 12+ messages in thread From: Bjorn Andersson @ 2017-10-31 4:21 UTC (permalink / raw) To: Loic Pallardy; +Cc: ohad, linux-remoteproc, linux-kernel, arnaud.pouliquen On Fri 27 Oct 05:41 PDT 2017, Loic Pallardy wrote: > This series increases remoteproc debug capabilities by adding: > - associated resource table dump feature > - registered carveouts list dump feature > This looks very reasonable, can you please fix the problem reported by 0-day? Regards, Bjorn > Loic Pallardy (2): > remoteproc: debug: add resource table dump feature > remoteproc: debug: add carveouts list dump feature > > drivers/remoteproc/remoteproc_debugfs.c | 130 ++++++++++++++++++++++++++++++++ > 1 file changed, 130 insertions(+) > > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 0/2] remoteproc: increase debug capabilities 2017-10-31 4:21 ` [PATCH 0/2] remoteproc: increase debug capabilities Bjorn Andersson @ 2017-11-06 16:51 ` Loic PALLARDY 0 siblings, 0 replies; 12+ messages in thread From: Loic PALLARDY @ 2017-11-06 16:51 UTC (permalink / raw) To: Bjorn Andersson; +Cc: ohad, linux-remoteproc, linux-kernel, Arnaud POULIQUEN > -----Original Message----- > From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org] > Sent: Tuesday, October 31, 2017 5:22 AM > To: Loic PALLARDY <loic.pallardy@st.com> > Cc: ohad@wizery.com; linux-remoteproc@vger.kernel.org; linux- > kernel@vger.kernel.org; Arnaud POULIQUEN <arnaud.pouliquen@st.com> > Subject: Re: [PATCH 0/2] remoteproc: increase debug capabilities > > On Fri 27 Oct 05:41 PDT 2017, Loic Pallardy wrote: > > > This series increases remoteproc debug capabilities by adding: > > - associated resource table dump feature > > - registered carveouts list dump feature > > > > This looks very reasonable, can you please fix the problem reported by > 0-day? Hi Bjorn, I'll send a v2 fixing reported issues. Regards, Loic > > Regards, > Bjorn > > > Loic Pallardy (2): > > remoteproc: debug: add resource table dump feature > > remoteproc: debug: add carveouts list dump feature > > > > drivers/remoteproc/remoteproc_debugfs.c | 130 > ++++++++++++++++++++++++++++++++ > > 1 file changed, 130 insertions(+) > > > > -- > > 1.9.1 > > ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-11-06 16:51 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-10-27 12:41 [PATCH 0/2] remoteproc: increase debug capabilities Loic Pallardy 2017-10-27 12:41 ` Loic Pallardy 2017-10-27 12:41 ` [PATCH 1/2] remoteproc: debug: add resource table dump feature Loic Pallardy 2017-10-27 12:41 ` Loic Pallardy 2017-10-30 10:35 ` kbuild test robot 2017-10-30 10:35 ` kbuild test robot 2017-10-30 11:46 ` kbuild test robot 2017-10-30 11:46 ` kbuild test robot 2017-10-27 12:41 ` [PATCH 2/2] remoteproc: debug: add carveouts list " Loic Pallardy 2017-10-27 12:41 ` Loic Pallardy 2017-10-31 4:21 ` [PATCH 0/2] remoteproc: increase debug capabilities Bjorn Andersson 2017-11-06 16:51 ` Loic PALLARDY
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.