* [Buildroot] [PATCH] quagga: add upstream security fix for CVE-2017-16227
@ 2017-10-30 21:53 Peter Korsgaard
2017-11-01 9:47 ` Thomas Petazzoni
2017-11-26 9:13 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-10-30 21:53 UTC (permalink / raw)
To: buildroot
From the advisory:
http://www.openwall.com/lists/oss-security/2017/10/30/4
It was discovered that the bgpd daemon in the Quagga routing suite does
not properly calculate the length of multi-segment AS_PATH UPDATE
messages, causing bgpd to drop a session and potentially resulting in
loss of network connectivity.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
...x-AS_PATH-size-calculation-for-long-paths.patch | 33 ++++++++++++++++++++++
1 file changed, 33 insertions(+)
create mode 100644 package/quagga/0004-bgpd-Fix-AS_PATH-size-calculation-for-long-paths.patch
diff --git a/package/quagga/0004-bgpd-Fix-AS_PATH-size-calculation-for-long-paths.patch b/package/quagga/0004-bgpd-Fix-AS_PATH-size-calculation-for-long-paths.patch
new file mode 100644
index 0000000000..1425cf0426
--- /dev/null
+++ b/package/quagga/0004-bgpd-Fix-AS_PATH-size-calculation-for-long-paths.patch
@@ -0,0 +1,33 @@
+From 7a42b78be9a4108d98833069a88e6fddb9285008 Mon Sep 17 00:00:00 2001
+From: Andreas Jaggi <aj@open.ch>
+Date: Mon, 2 Oct 2017 19:38:43 +0530
+Subject: [PATCH] bgpd: Fix AS_PATH size calculation for long paths
+
+If you have an AS_PATH with more entries than
+what can be written into a single AS_SEGMENT_MAX
+it needs to be broken up. The code that noticed
+that the AS_PATH needs to be broken up was not
+correctly calculating the size of the resulting
+message. This patch addresses this issue.
+
+Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
+---
+ bgpd/bgp_aspath.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/bgpd/bgp_aspath.c b/bgpd/bgp_aspath.c
+index b7af5e88..d813bfba 100644
+--- a/bgpd/bgp_aspath.c
++++ b/bgpd/bgp_aspath.c
+@@ -903,7 +903,7 @@ aspath_put (struct stream *s, struct aspath *as, int use32bit )
+ assegment_header_put (s, seg->type, AS_SEGMENT_MAX);
+ assegment_data_put (s, seg->as, AS_SEGMENT_MAX, use32bit);
+ written += AS_SEGMENT_MAX;
+- bytes += ASSEGMENT_SIZE (written, use32bit);
++ bytes += ASSEGMENT_SIZE (AS_SEGMENT_MAX, use32bit);
+ }
+
+ /* write the final segment, probably is also the first */
+--
+2.11.0
+
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] quagga: add upstream security fix for CVE-2017-16227
2017-10-30 21:53 [Buildroot] [PATCH] quagga: add upstream security fix for CVE-2017-16227 Peter Korsgaard
@ 2017-11-01 9:47 ` Thomas Petazzoni
2017-11-26 9:13 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-11-01 9:47 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 30 Oct 2017 22:53:09 +0100, Peter Korsgaard wrote:
> From the advisory:
> http://www.openwall.com/lists/oss-security/2017/10/30/4
>
> It was discovered that the bgpd daemon in the Quagga routing suite does
> not properly calculate the length of multi-segment AS_PATH UPDATE
> messages, causing bgpd to drop a session and potentially resulting in
> loss of network connectivity.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> ...x-AS_PATH-size-calculation-for-long-paths.patch | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 package/quagga/0004-bgpd-Fix-AS_PATH-size-calculation-for-long-paths.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] quagga: add upstream security fix for CVE-2017-16227
2017-10-30 21:53 [Buildroot] [PATCH] quagga: add upstream security fix for CVE-2017-16227 Peter Korsgaard
2017-11-01 9:47 ` Thomas Petazzoni
@ 2017-11-26 9:13 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-11-26 9:13 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> From the advisory:
> http://www.openwall.com/lists/oss-security/2017/10/30/4
> It was discovered that the bgpd daemon in the Quagga routing suite does
> not properly calculate the length of multi-segment AS_PATH UPDATE
> messages, causing bgpd to drop a session and potentially resulting in
> loss of network connectivity.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed to 2017.02.x and 2017.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-26 9:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30 21:53 [Buildroot] [PATCH] quagga: add upstream security fix for CVE-2017-16227 Peter Korsgaard
2017-11-01 9:47 ` Thomas Petazzoni
2017-11-26 9:13 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.