* [PATCH] drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too.
@ 2017-10-30 22:21 Dhinakaran Pandiyan
2017-10-30 23:43 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-31 2:15 ` ✗ Fi.CI.IGT: warning " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Dhinakaran Pandiyan @ 2017-10-30 22:21 UTC (permalink / raw)
To: dri-devel; +Cc: Jani Nikula, intel-gfx, Dhinakaran Pandiyan
Updating the mask is needed to clear all the three power state bits before
setting the required power state. Also add a comment documenting that
D3 Aux-On state has been available DPCD v1.2 onwards. Thanks to Ville for
pointing this out.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
include/drm/drm_dp_helper.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 9049ef133d69..aea10f85dd4c 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -617,8 +617,8 @@
#define DP_SET_POWER 0x600
# define DP_SET_POWER_D0 0x1
# define DP_SET_POWER_D3 0x2
-# define DP_SET_POWER_MASK 0x3
-# define DP_SET_POWER_D3_AUX_ON 0x5
+# define DP_SET_POWER_D3_AUX_ON 0x5 /* DPCD >= 1.2 */
+# define DP_SET_POWER_MASK 0x7
#define DP_EDP_DPCD_REV 0x700 /* eDP 1.2 */
# define DP_EDP_11 0x00
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✓ Fi.CI.BAT: success for drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too.
2017-10-30 22:21 [PATCH] drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too Dhinakaran Pandiyan
@ 2017-10-30 23:43 ` Patchwork
2017-10-31 2:15 ` ✗ Fi.CI.IGT: warning " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-10-30 23:43 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too.
URL : https://patchwork.freedesktop.org/series/32867/
State : success
== Summary ==
Series 32867v1 drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too.
https://patchwork.freedesktop.org/api/1.0/series/32867/revisions/1/mbox/
fi-bdw-5557u total:289 pass:266 dwarn:0 dfail:0 fail:2 skip:21 time:462s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:453s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:374s
fi-bsw-n3050 total:289 pass:241 dwarn:0 dfail:0 fail:2 skip:46 time:541s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:265s
fi-bxt-j4205 total:289 pass:258 dwarn:0 dfail:0 fail:2 skip:29 time:515s
fi-byt-j1900 total:289 pass:251 dwarn:1 dfail:0 fail:2 skip:35 time:511s
fi-byt-n2820 total:289 pass:247 dwarn:1 dfail:0 fail:2 skip:39 time:494s
fi-cfl-s total:289 pass:251 dwarn:4 dfail:0 fail:2 skip:32 time:559s
fi-cnl-y total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:599s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:418s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:248s
fi-glk-1 total:289 pass:259 dwarn:0 dfail:0 fail:2 skip:28 time:597s
fi-hsw-4770 total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:442s
fi-hsw-4770r total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:443s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:418s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:494s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:461s
fi-kbl-7500u total:289 pass:262 dwarn:1 dfail:0 fail:2 skip:24 time:510s
fi-kbl-7560u total:289 pass:268 dwarn:0 dfail:0 fail:2 skip:19 time:576s
fi-kbl-7567u total:289 pass:267 dwarn:0 dfail:0 fail:2 skip:20 time:491s
fi-kbl-r total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:592s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:533s
fi-skl-6260u total:289 pass:267 dwarn:0 dfail:0 fail:2 skip:20 time:467s
fi-skl-6600u total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:595s
fi-skl-6700hq total:289 pass:261 dwarn:0 dfail:0 fail:2 skip:26 time:657s
fi-skl-6700k total:289 pass:263 dwarn:0 dfail:0 fail:2 skip:24 time:533s
fi-skl-6770hq total:289 pass:267 dwarn:0 dfail:0 fail:2 skip:20 time:525s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:457s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:556s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:414s
e069b70ce83d85a235bb2f0d52327c30a2a1370c drm-tip: 2017y-10m-30d-21h-18m-56s UTC integration manifest
41c0e7480920 drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6271/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* ✗ Fi.CI.IGT: warning for drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too.
2017-10-30 22:21 [PATCH] drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too Dhinakaran Pandiyan
2017-10-30 23:43 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-31 2:15 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-10-31 2:15 UTC (permalink / raw)
To: Pandiyan, Dhinakaran; +Cc: intel-gfx
== Series Details ==
Series: drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too.
URL : https://patchwork.freedesktop.org/series/32867/
State : warning
== Summary ==
Test perf:
Subgroup oa-exponents:
fail -> PASS (shard-hsw) fdo#102254
Test kms_flip:
Subgroup vblank-vs-dpms-suspend:
pass -> SKIP (shard-hsw)
Test drv_suspend:
Subgroup forcewake:
skip -> PASS (shard-hsw)
Test kms_plane:
Subgroup plane-panning-top-left-pipe-A-planes:
skip -> PASS (shard-hsw)
Test kms_atomic:
Subgroup atomic_invalid_params:
skip -> PASS (shard-hsw)
Test kms_cursor_crc:
Subgroup cursor-64x64-onscreen:
skip -> PASS (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-cur-indfb-move:
skip -> PASS (shard-hsw)
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
shard-hsw total:2539 pass:1393 dwarn:1 dfail:0 fail:51 skip:1094 time:9193s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6271/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-31 2:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30 22:21 [PATCH] drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too Dhinakaran Pandiyan
2017-10-30 23:43 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-31 2:15 ` ✗ Fi.CI.IGT: warning " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.