* [PATCH] pinctrl: ti-iodelay: remove redundant unused variable dev
@ 2017-10-31 11:20 Colin King
2017-10-31 13:28 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-10-31 11:20 UTC (permalink / raw)
To: Linus Walleij, Tony Lindgren, Nishanth Menon, linux-gpio
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer dev is being assigned but is never used, hence it is
redundant and can be removed. Cleans up clang warnings:
drivers/pinctrl/ti/pinctrl-ti-iodelay.c:582:2: warning: Value stored
to 'dev' is never read
drivers/pinctrl/ti/pinctrl-ti-iodelay.c:701:2: warning: Value stored
to 'dev' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
index 5c1b6325d80d..a8a6510183b6 100644
--- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
+++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
@@ -575,11 +575,9 @@ static int ti_iodelay_pinconf_group_get(struct pinctrl_dev *pctldev,
unsigned long *config)
{
struct ti_iodelay_device *iod;
- struct device *dev;
struct ti_iodelay_pingroup *group;
iod = pinctrl_dev_get_drvdata(pctldev);
- dev = iod->dev;
group = ti_iodelay_get_pingroup(iod, selector);
if (!group)
@@ -693,12 +691,10 @@ static void ti_iodelay_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
unsigned int selector)
{
struct ti_iodelay_device *iod;
- struct device *dev;
struct ti_iodelay_pingroup *group;
int i;
iod = pinctrl_dev_get_drvdata(pctldev);
- dev = iod->dev;
group = ti_iodelay_get_pingroup(iod, selector);
if (!group)
return;
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: ti-iodelay: remove redundant unused variable dev
2017-10-31 11:20 [PATCH] pinctrl: ti-iodelay: remove redundant unused variable dev Colin King
@ 2017-10-31 13:28 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-10-31 13:28 UTC (permalink / raw)
To: Colin King
Cc: Tony Lindgren, Nishanth Menon, linux-gpio, kernel-janitors, linux-kernel
On Tue, Oct 31, 2017 at 12:20 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer dev is being assigned but is never used, hence it is
> redundant and can be removed. Cleans up clang warnings:
>
> drivers/pinctrl/ti/pinctrl-ti-iodelay.c:582:2: warning: Value stored
> to 'dev' is never read
> drivers/pinctrl/ti/pinctrl-ti-iodelay.c:701:2: warning: Value stored
> to 'dev' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: ti-iodelay: remove redundant unused variable dev
@ 2017-10-31 13:28 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-10-31 13:28 UTC (permalink / raw)
To: Colin King
Cc: Tony Lindgren, Nishanth Menon, linux-gpio, kernel-janitors, linux-kernel
On Tue, Oct 31, 2017 at 12:20 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer dev is being assigned but is never used, hence it is
> redundant and can be removed. Cleans up clang warnings:
>
> drivers/pinctrl/ti/pinctrl-ti-iodelay.c:582:2: warning: Value stored
> to 'dev' is never read
> drivers/pinctrl/ti/pinctrl-ti-iodelay.c:701:2: warning: Value stored
> to 'dev' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-31 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 11:20 [PATCH] pinctrl: ti-iodelay: remove redundant unused variable dev Colin King
2017-10-31 13:28 ` Linus Walleij
2017-10-31 13:28 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.