From: Johan Hovold <johan@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hso: remove redundant unused variable dev
Date: Tue, 31 Oct 2017 14:22:44 +0100 [thread overview]
Message-ID: <20171031132244.GP7223@localhost> (raw)
In-Reply-To: <20171031120147.22348-1-colin.king@canonical.com>
On Tue, Oct 31, 2017 at 12:01:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer dev is being assigned but is never used, hence it is
> redundant and can be removed. Cleans up clang warning:
>
> drivers/net/usb/hso.c:2280:2: warning: Value stored to 'dev' is
> never read
You could also have mentioned that it was a leftover since commit
4134069f3ea6 ("hso: Use static attribute groups for sysfs entry").
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Thanks,
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hso: remove redundant unused variable dev
Date: Tue, 31 Oct 2017 13:22:44 +0000 [thread overview]
Message-ID: <20171031132244.GP7223@localhost> (raw)
In-Reply-To: <20171031120147.22348-1-colin.king@canonical.com>
On Tue, Oct 31, 2017 at 12:01:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer dev is being assigned but is never used, hence it is
> redundant and can be removed. Cleans up clang warning:
>
> drivers/net/usb/hso.c:2280:2: warning: Value stored to 'dev' is
> never read
You could also have mentioned that it was a leftover since commit
4134069f3ea6 ("hso: Use static attribute groups for sysfs entry").
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Thanks,
Johan
next prev parent reply other threads:[~2017-10-31 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 12:01 [PATCH] net: hso: remove redundant unused variable dev Colin King
2017-10-31 13:22 ` Johan Hovold [this message]
2017-10-31 13:22 ` Johan Hovold
2017-11-01 12:24 ` David Miller
2017-11-01 12:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031132244.GP7223@localhost \
--to=johan@kernel.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.