* [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0
@ 2017-11-01 16:37 Rob Herring
2017-11-01 17:50 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2017-11-01 16:37 UTC (permalink / raw)
To: dri-devel
If the rotation property is supported for a plane, then the rotation
value must be non-zero. For the case of 0 degree rotation,
DRM_MODE_ROTATE_0 needs to be set.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drmdisplaycompositor.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drmdisplaycompositor.cpp b/drmdisplaycompositor.cpp
index 8225726df5cd..dceb78d452c4 100644
--- a/drmdisplaycompositor.cpp
+++ b/drmdisplaycompositor.cpp
@@ -581,6 +581,8 @@ int DrmDisplayCompositor::CommitFrame(DrmDisplayComposition *display_comp,
rotation |= DRM_MODE_ROTATE_180;
else if (layer.transform & DrmHwcTransform::kRotate270)
rotation |= DRM_MODE_ROTATE_270;
+ else
+ rotation |= DRM_MODE_ROTATE_0;
if (fence_fd < 0) {
int prop_id = plane->in_fence_fd_property().id();
@@ -610,7 +612,7 @@ int DrmDisplayCompositor::CommitFrame(DrmDisplayComposition *display_comp,
}
// TODO: Once we have atomic test, this should fall back to GL
- if (rotation && plane->rotation_property().id() == 0) {
+ if (rotation != DRM_MODE_ROTATE_0 && plane->rotation_property().id() == 0) {
ALOGE("Rotation is not supported on plane %d", plane->id());
ret = -EINVAL;
break;
--
2.14.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0
2017-11-01 16:37 [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0 Rob Herring
@ 2017-11-01 17:50 ` Rob Herring
2017-11-01 18:02 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2017-11-01 17:50 UTC (permalink / raw)
To: dri-devel
On Wed, Nov 1, 2017 at 11:37 AM, Rob Herring <robh@kernel.org> wrote:
> If the rotation property is supported for a plane, then the rotation
> value must be non-zero. For the case of 0 degree rotation,
> DRM_MODE_ROTATE_0 needs to be set.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drmdisplaycompositor.cpp | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Pushed to master.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0
2017-11-01 17:50 ` Rob Herring
@ 2017-11-01 18:02 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2017-11-01 18:02 UTC (permalink / raw)
To: Rob Herring, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]
Hi Rob,
On Wed, 2017-11-01 at 12:50 -0500, Rob Herring wrote:
> On Wed, Nov 1, 2017 at 11:37 AM, Rob Herring <robh@kernel.org> wrote:
> > If the rotation property is supported for a plane, then the
> > rotation
> > value must be non-zero. For the case of 0 degree rotation,
> > DRM_MODE_ROTATE_0 needs to be set.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > drmdisplaycompositor.cpp | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Pushed to master.
Thanks :)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-01 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-01 16:37 [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0 Rob Herring
2017-11-01 17:50 ` Rob Herring
2017-11-01 18:02 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.