From: Paul Burton <paul.burton@mips.com> To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com> Cc: <linux-mips@linux-mips.org>, Miodrag Dinic <miodrag.dinic@mips.com>, Goran Ferenc <goran.ferenc@mips.com>, Aleksandar Markovic <aleksandar.markovic@mips.com>, "David S. Miller" <davem@davemloft.net>, Douglas Leung <douglas.leung@mips.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, James Hogan <james.hogan@mips.com>, <linux-kernel@vger.kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Miodrag Dinic <miodrag.dinic@imgtec.com>, Paul Burton <paul.burton@imgtec.com>, Petar Jovanovic <petar.jovanovic@mips.com>, Raghu Gandham <raghu.gandham@mips.com>, Ralf Baechle <ralf@linux-mips.org>, Randy Dunlap <rdunlap@infradead.org> Subject: Re: [PATCH v6 5/5] MIPS: ranchu: Add Ranchu as a new generic-based board Date: Wed, 1 Nov 2017 10:58:20 -0700 [thread overview] Message-ID: <20171101175820.nhepxzdwfokof6q2@pburton-laptop> (raw) In-Reply-To: <1509364642-21771-6-git-send-email-aleksandar.markovic@rt-rk.com> Hi Aleksandar, On Mon, Oct 30, 2017 at 12:56:36PM +0100, Aleksandar Markovic wrote: > diff --git a/arch/mips/generic/board-ranchu.c b/arch/mips/generic/board-ranchu.c > new file mode 100644 > index 0000000..0397752 > --- /dev/null > +++ b/arch/mips/generic/board-ranchu.c > @@ -0,0 +1,79 @@ > +/* > + * Support code for virtual Ranchu board for MIPS. > + * > + * Author: Miodrag Dinic <miodrag.dinic@mips.com> > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + */ > + > +#include <linux/of_address.h> > + > +#include <asm/machine.h> You should also include asm/mipsregs.h for read_c0_count(), even though it's presumably being pulled in indirectly as-is. > +#include <asm/time.h> > + > +#define GOLDFISH_TIMER_LOW 0x00 > +#define GOLDFISH_TIMER_HIGH 0x04 > + > +static __init uint64_t read_rtc_time(void __iomem *base) > +{ > + u64 time_low; > + u64 time_high; > + > + time_low = readl(base + GOLDFISH_TIMER_LOW); > + time_high = readl(base + GOLDFISH_TIMER_HIGH); > + > + return (time_high << 32) | time_low; > +} > + > +static __init unsigned int ranchu_measure_hpt_freq(void) > +{ > + u64 rtc_start, rtc_current, rtc_delta; > + unsigned int start, count; > + struct device_node *np; > + void __iomem *rtc_base; > + > + np = of_find_compatible_node(NULL, NULL, "google,goldfish-rtc"); > + if (!np) > + panic("%s(): Failed to find 'google,goldfish-rtc' dt node!", > + __func__); > + > + rtc_base = of_iomap(np, 0); > + if (!rtc_base) > + panic("%s(): Failed to ioremap Goldfish RTC base!", __func__); > + > + /* > + * poll the nanosecond resolution RTC for 1 second > + * to calibrate the CPU frequency > + */ > + rtc_start = read_rtc_time(rtc_base); > + start = read_c0_count(); > + > + do { > + rtc_current = read_rtc_time(rtc_base); > + rtc_delta = rtc_current - rtc_start; > + } while (rtc_delta < NSEC_PER_SEC); > + > + count = read_c0_count() - start; > + > + count += 5000; /* round */ > + count -= count % 10000; > + > + return count; > +} Would it be possible to have the emulator write the frequency into the devicetree, as the frequency of a fixed-clock used as the CPU's clock? If that were possible then there'd be no need for this board setup code at all. Not a big deal, but it'd be nice. > + > +static const struct of_device_id ranchu_of_match[]; > + > +MIPS_MACHINE(ranchu) = { > + .matches = ranchu_of_match, > + .measure_hpt_freq = ranchu_measure_hpt_freq, > +}; > + > +static const struct of_device_id ranchu_of_match[] = { > + { > + .compatible = "mti,ranchu", > + .data = &__mips_mach_ranchu, > + }, > +}; Could you move ranchu_of_match before the MIPS_MACHINE & drop the forward declaration? That would feel tidier to me. It could also be marked as __initdata. In general though, with those & James' comments addressed, I think this is looking good. Thanks, Paul
WARNING: multiple messages have this Message-ID (diff)
From: Paul Burton <paul.burton@mips.com> To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com> Cc: linux-mips@linux-mips.org, Miodrag Dinic <miodrag.dinic@mips.com>, Goran Ferenc <goran.ferenc@mips.com>, Aleksandar Markovic <aleksandar.markovic@mips.com>, "David S. Miller" <davem@davemloft.net>, Douglas Leung <douglas.leung@mips.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, James Hogan <james.hogan@mips.com>, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab <mchehab@kernel.org>, Miodrag Dinic <miodrag.dinic@imgtec.com>, Paul Burton <paul.burton@imgtec.com>, Petar Jovanovic <petar.jovanovic@mips.com>, Raghu Gandham <raghu.gandham@mips.com>, Ralf Baechle <ralf@linux-mips.org>, Randy Dunlap <rdunlap@infradead.org> Subject: Re: [PATCH v6 5/5] MIPS: ranchu: Add Ranchu as a new generic-based board Date: Wed, 1 Nov 2017 10:58:20 -0700 [thread overview] Message-ID: <20171101175820.nhepxzdwfokof6q2@pburton-laptop> (raw) Message-ID: <20171101175820.Cua7yQv7OmgQHEDjI-gD2AHoaRYQTsCatIWOdzfQFSc@z> (raw) In-Reply-To: <1509364642-21771-6-git-send-email-aleksandar.markovic@rt-rk.com> Hi Aleksandar, On Mon, Oct 30, 2017 at 12:56:36PM +0100, Aleksandar Markovic wrote: > diff --git a/arch/mips/generic/board-ranchu.c b/arch/mips/generic/board-ranchu.c > new file mode 100644 > index 0000000..0397752 > --- /dev/null > +++ b/arch/mips/generic/board-ranchu.c > @@ -0,0 +1,79 @@ > +/* > + * Support code for virtual Ranchu board for MIPS. > + * > + * Author: Miodrag Dinic <miodrag.dinic@mips.com> > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + */ > + > +#include <linux/of_address.h> > + > +#include <asm/machine.h> You should also include asm/mipsregs.h for read_c0_count(), even though it's presumably being pulled in indirectly as-is. > +#include <asm/time.h> > + > +#define GOLDFISH_TIMER_LOW 0x00 > +#define GOLDFISH_TIMER_HIGH 0x04 > + > +static __init uint64_t read_rtc_time(void __iomem *base) > +{ > + u64 time_low; > + u64 time_high; > + > + time_low = readl(base + GOLDFISH_TIMER_LOW); > + time_high = readl(base + GOLDFISH_TIMER_HIGH); > + > + return (time_high << 32) | time_low; > +} > + > +static __init unsigned int ranchu_measure_hpt_freq(void) > +{ > + u64 rtc_start, rtc_current, rtc_delta; > + unsigned int start, count; > + struct device_node *np; > + void __iomem *rtc_base; > + > + np = of_find_compatible_node(NULL, NULL, "google,goldfish-rtc"); > + if (!np) > + panic("%s(): Failed to find 'google,goldfish-rtc' dt node!", > + __func__); > + > + rtc_base = of_iomap(np, 0); > + if (!rtc_base) > + panic("%s(): Failed to ioremap Goldfish RTC base!", __func__); > + > + /* > + * poll the nanosecond resolution RTC for 1 second > + * to calibrate the CPU frequency > + */ > + rtc_start = read_rtc_time(rtc_base); > + start = read_c0_count(); > + > + do { > + rtc_current = read_rtc_time(rtc_base); > + rtc_delta = rtc_current - rtc_start; > + } while (rtc_delta < NSEC_PER_SEC); > + > + count = read_c0_count() - start; > + > + count += 5000; /* round */ > + count -= count % 10000; > + > + return count; > +} Would it be possible to have the emulator write the frequency into the devicetree, as the frequency of a fixed-clock used as the CPU's clock? If that were possible then there'd be no need for this board setup code at all. Not a big deal, but it'd be nice. > + > +static const struct of_device_id ranchu_of_match[]; > + > +MIPS_MACHINE(ranchu) = { > + .matches = ranchu_of_match, > + .measure_hpt_freq = ranchu_measure_hpt_freq, > +}; > + > +static const struct of_device_id ranchu_of_match[] = { > + { > + .compatible = "mti,ranchu", > + .data = &__mips_mach_ranchu, > + }, > +}; Could you move ranchu_of_match before the MIPS_MACHINE & drop the forward declaration? That would feel tidier to me. It could also be marked as __initdata. In general though, with those & James' comments addressed, I think this is looking good. Thanks, Paul
next prev parent reply other threads:[~2017-11-01 17:59 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-30 11:56 [PATCH v6 0/5] MIPS: Add virtual Ranchu board as a generic-based board Aleksandar Markovic 2017-10-30 11:56 ` [PATCH v6 1/5] Documentation: Add device tree binding for Goldfish PIC driver Aleksandar Markovic 2017-10-30 11:56 ` Aleksandar Markovic 2017-10-30 11:56 ` [PATCH v6 2/5] irqchip/irq-goldfish-pic: Add " Aleksandar Markovic 2017-10-31 2:26 ` Marc Zyngier 2017-10-31 2:26 ` Marc Zyngier 2017-11-01 14:34 ` Miodrag Dinic 2017-10-30 11:56 ` [PATCH v6 3/5] Documentation: Add device tree binding for Goldfish FB driver Aleksandar Markovic 2017-10-30 11:56 ` [PATCH v6 4/5] video: goldfishfb: Add support for device tree bindings Aleksandar Markovic 2017-10-30 11:56 ` Aleksandar Markovic 2017-10-30 11:56 ` [PATCH v6 5/5] MIPS: ranchu: Add Ranchu as a new generic-based board Aleksandar Markovic 2017-10-30 16:45 ` James Hogan 2017-10-30 16:45 ` James Hogan 2017-11-02 12:47 ` Miodrag Dinic 2017-11-02 12:47 ` Miodrag Dinic 2017-11-02 12:53 ` James Hogan 2017-11-01 17:58 ` Paul Burton [this message] 2017-11-01 17:58 ` Paul Burton 2017-11-02 13:47 ` Miodrag Dinic 2017-11-02 20:49 ` Paul Burton 2017-11-03 14:04 ` Miodrag Dinic
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171101175820.nhepxzdwfokof6q2@pburton-laptop \ --to=paul.burton@mips.com \ --cc=aleksandar.markovic@mips.com \ --cc=aleksandar.markovic@rt-rk.com \ --cc=davem@davemloft.net \ --cc=douglas.leung@mips.com \ --cc=goran.ferenc@mips.com \ --cc=gregkh@linuxfoundation.org \ --cc=james.hogan@mips.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=mchehab@kernel.org \ --cc=miodrag.dinic@imgtec.com \ --cc=miodrag.dinic@mips.com \ --cc=paul.burton@imgtec.com \ --cc=petar.jovanovic@mips.com \ --cc=raghu.gandham@mips.com \ --cc=ralf@linux-mips.org \ --cc=rdunlap@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.