* linux-next: build warnings after merge of the staging tree
@ 2017-11-02 4:38 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2017-11-02 4:38 UTC (permalink / raw)
To: Greg KH
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Kees Cook,
Aastha Gupta
Hi Greg,
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
drivers/staging/rtlwifi/base.c: In function 'rtl_watch_dog_timer_callback':
drivers/staging/rtlwifi/base.c:2167:23: warning: unused variable 'hw' [-Wunused-variable]
struct ieee80211_hw *hw = rtlpriv->hw;
^
drivers/staging/rtl8723bs/hal/hal_btcoex.c: In function 'hal_btcoex_Initialize':
drivers/staging/rtl8723bs/hal/hal_btcoex.c:1415:5: warning: unused variable 'ret2' [-Wunused-variable]
u8 ret2;
^
drivers/staging/rtl8723bs/hal/hal_btcoex.c:1414:5: warning: unused variable 'ret1' [-Wunused-variable]
u8 ret1;
^
Introduced by commits
f8af6a323368 ("staging: rtlwifi: Convert timers to use timer_setup()")
95b3b4238581 ("staging: rtl8723bs: remove ternary operators in assignmet statments")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 19+ messages in thread* linux-next: build warnings after merge of the staging tree
@ 2019-02-05 3:22 Stephen Rothwell
2019-02-05 10:24 ` Jonathan Cameron
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2019-02-05 3:22 UTC (permalink / raw)
To: Greg KH
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Tomasz Duszynski, Jonathan Cameron, Gustavo A. R. Silva,
Kees Cook
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
Hi Greg,
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
drivers/iio/chemical/sps30.c: In function 'sps30_read_raw':
drivers/iio/chemical/sps30.c:289:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (chan->channel2) {
^~~~~~
drivers/iio/chemical/sps30.c:299:3: note: here
default:
^~~~~~~
drivers/iio/chemical/sps30.c: In function 'sps30_do_cmd':
drivers/iio/chemical/sps30.c:120:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
buf[1] = (u8)SPS30_AUTO_CLEANING_PERIOD;
^
drivers/iio/chemical/sps30.c:121:2: note: here
case SPS30_READ_DATA_READY_FLAG:
^~~~
Introduced by commits
232e0f6ddeae ("iio: chemical: add support for Sensirion SPS30 sensor")
62129a0849d2 ("iio: chemical: sps30: allow changing self cleaning period")
I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early. The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: linux-next: build warnings after merge of the staging tree
2019-02-05 3:22 Stephen Rothwell
@ 2019-02-05 10:24 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2019-02-05 10:24 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, Linux Next Mailing List, Linux Kernel Mailing List,
Tomasz Duszynski, Gustavo A. R. Silva, Kees Cook
On Tue, 5 Feb 2019 14:22:17 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Greg,
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> drivers/iio/chemical/sps30.c: In function 'sps30_read_raw':
> drivers/iio/chemical/sps30.c:289:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
> switch (chan->channel2) {
> ^~~~~~
> drivers/iio/chemical/sps30.c:299:3: note: here
> default:
> ^~~~~~~
> drivers/iio/chemical/sps30.c: In function 'sps30_do_cmd':
> drivers/iio/chemical/sps30.c:120:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
> buf[1] = (u8)SPS30_AUTO_CLEANING_PERIOD;
> ^
> drivers/iio/chemical/sps30.c:121:2: note: here
> case SPS30_READ_DATA_READY_FLAG:
> ^~~~
>
> Introduced by commits
>
> 232e0f6ddeae ("iio: chemical: add support for Sensirion SPS30 sensor")
> 62129a0849d2 ("iio: chemical: sps30: allow changing self cleaning period")
>
> I get this warning because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early. The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (assuming that the fall through is intentional).
>
These both should both be marked - certainly look to be intentional.
The second one might be better handled with an additional return of the -EINVAL.
Thomasz, could you send me a patch tidying this up.
Thanks Stephen!
Jonathan
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: build warnings after merge of the staging tree
@ 2018-05-14 4:34 Stephen Rothwell
2018-05-14 9:26 ` Greg KH
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2018-05-14 4:34 UTC (permalink / raw)
To: Greg KH; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Abdun Nihaal
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
Hi Greg,
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/staging/most/video/video.c: In function 'vidioc_enum_fmt_vid_cap':
drivers/staging/most/video/video.c:265:25: warning: unused variable 'mdev' [-Wunused-variable]
struct most_video_dev *mdev = fh->mdev;
^~~~
drivers/staging/most/video/video.c: In function 'vidioc_g_fmt_vid_cap':
drivers/staging/most/video/video.c:282:25: warning: unused variable 'mdev' [-Wunused-variable]
struct most_video_dev *mdev = fh->mdev;
^~~~
drivers/staging/most/video/video.c: In function 'vidioc_g_std':
drivers/staging/most/video/video.c:309:25: warning: unused variable 'mdev' [-Wunused-variable]
struct most_video_dev *mdev = fh->mdev;
^~~~
Introduced by commit
7d7cdb4fa552 ("staging: most: video: remove debugging code")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: linux-next: build warnings after merge of the staging tree
2018-05-14 4:34 Stephen Rothwell
@ 2018-05-14 9:26 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2018-05-14 9:26 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Abdun Nihaal
On Mon, May 14, 2018 at 02:34:04PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/staging/most/video/video.c: In function 'vidioc_enum_fmt_vid_cap':
> drivers/staging/most/video/video.c:265:25: warning: unused variable 'mdev' [-Wunused-variable]
> struct most_video_dev *mdev = fh->mdev;
> ^~~~
> drivers/staging/most/video/video.c: In function 'vidioc_g_fmt_vid_cap':
> drivers/staging/most/video/video.c:282:25: warning: unused variable 'mdev' [-Wunused-variable]
> struct most_video_dev *mdev = fh->mdev;
> ^~~~
> drivers/staging/most/video/video.c: In function 'vidioc_g_std':
> drivers/staging/most/video/video.c:309:25: warning: unused variable 'mdev' [-Wunused-variable]
> struct most_video_dev *mdev = fh->mdev;
> ^~~~
>
> Introduced by commit
>
> 7d7cdb4fa552 ("staging: most: video: remove debugging code")
Sorry about this. This warning, and the other one in the staging tree,
were not noticed by me due to my system updating to gcc-8 and the huge
numbers of warnings it produced. Then 0-day went on a bender and didn't
spit out anything for a few days...
I'll go fix this up now, thanks for the report.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: build warnings after merge of the staging tree
@ 2017-07-31 5:02 Stephen Rothwell
2017-08-09 1:25 ` Stephen Rothwell
2017-08-17 17:57 ` Greg KH
0 siblings, 2 replies; 19+ messages in thread
From: Stephen Rothwell @ 2017-07-31 5:02 UTC (permalink / raw)
To: Greg KH
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, JB Van Puyvelde
Hi Greg,
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 'imx_vcm_power_up' defined but not used [-Wunused-function]
static int imx_vcm_power_up(struct v4l2_subdev *sd)
^
drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 'imx_vcm_power_down' defined but not used [-Wunused-function]
static int imx_vcm_power_down(struct v4l2_subdev *sd)
^
drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' defined but not used [-Wunused-function]
static int imx_vcm_init(struct v4l2_subdev *sd)
^
drivers/staging/media/atomisp/i2c/imx/imx.c:1111:12: warning: 'imx_t_focus_vcm' defined but not used [-Wunused-function]
static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
^
Introduced by commit
9a5a6911aa3f ("staging: imx: fix non-static declarations")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: linux-next: build warnings after merge of the staging tree
2017-07-31 5:02 Stephen Rothwell
@ 2017-08-09 1:25 ` Stephen Rothwell
2017-08-22 1:49 ` Stephen Rothwell
2017-08-17 17:57 ` Greg KH
1 sibling, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2017-08-09 1:25 UTC (permalink / raw)
To: Greg KH, Mauro Carvalho Chehab
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, JB Van Puyvelde
Hi all,
On Mon, 31 Jul 2017 15:02:27 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 'imx_vcm_power_up' defined but not used [-Wunused-function]
> static int imx_vcm_power_up(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 'imx_vcm_power_down' defined but not used [-Wunused-function]
> static int imx_vcm_power_down(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' defined but not used [-Wunused-function]
> static int imx_vcm_init(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1111:12: warning: 'imx_t_focus_vcm' defined but not used [-Wunused-function]
> static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> ^
>
> Introduced by commit
>
> 9a5a6911aa3f ("staging: imx: fix non-static declarations")
There is now another copy of this commit in the v4l-dvb tree producing
the same warnings :-(
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: linux-next: build warnings after merge of the staging tree
2017-08-09 1:25 ` Stephen Rothwell
@ 2017-08-22 1:49 ` Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2017-08-22 1:49 UTC (permalink / raw)
To: Greg KH, Mauro Carvalho Chehab
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, JB Van Puyvelde
Hi Mauro,
On Wed, 9 Aug 2017 11:25:22 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 31 Jul 2017 15:02:27 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the staging tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 'imx_vcm_power_up' defined but not used [-Wunused-function]
> > static int imx_vcm_power_up(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 'imx_vcm_power_down' defined but not used [-Wunused-function]
> > static int imx_vcm_power_down(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' defined but not used [-Wunused-function]
> > static int imx_vcm_init(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1111:12: warning: 'imx_t_focus_vcm' defined but not used [-Wunused-function]
> > static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> > ^
> >
> > Introduced by commit
> >
> > 9a5a6911aa3f ("staging: imx: fix non-static declarations")
>
> There is now another copy of this commit in the v4l-dvb tree producing
> the same warnings :-(
Any chance this will be fixed in the v4l-dvb tree?
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build warnings after merge of the staging tree
2017-07-31 5:02 Stephen Rothwell
2017-08-09 1:25 ` Stephen Rothwell
@ 2017-08-17 17:57 ` Greg KH
2017-08-18 12:02 ` JB Van Puyvelde
1 sibling, 1 reply; 19+ messages in thread
From: Greg KH @ 2017-08-17 17:57 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, JB Van Puyvelde
On Mon, Jul 31, 2017 at 03:02:27PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 'imx_vcm_power_up' defined but not used [-Wunused-function]
> static int imx_vcm_power_up(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 'imx_vcm_power_down' defined but not used [-Wunused-function]
> static int imx_vcm_power_down(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' defined but not used [-Wunused-function]
> static int imx_vcm_init(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1111:12: warning: 'imx_t_focus_vcm' defined but not used [-Wunused-function]
> static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> ^
>
> Introduced by commit
>
> 9a5a6911aa3f ("staging: imx: fix non-static declarations")
Sorry for the delay, now dropped from my tree, I shouldn't have taken it
in the first place :(
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: linux-next: build warnings after merge of the staging tree
2017-08-17 17:57 ` Greg KH
@ 2017-08-18 12:02 ` JB Van Puyvelde
0 siblings, 0 replies; 19+ messages in thread
From: JB Van Puyvelde @ 2017-08-18 12:02 UTC (permalink / raw)
To: Greg KH
Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List
On Thu, 17 Aug 2017 10:57:43 -0700
Greg KH <greg@kroah.com> wrote:
> On Mon, Jul 31, 2017 at 03:02:27PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > After merging the staging tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 'imx_vcm_power_up' defined but not used [-Wunused-function]
> > static int imx_vcm_power_up(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 'imx_vcm_power_down' defined but not used [-Wunused-function]
> > static int imx_vcm_power_down(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' defined but not used [-Wunused-function]
> > static int imx_vcm_init(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1111:12: warning: 'imx_t_focus_vcm' defined but not used [-Wunused-function]
> > static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> > ^
> >
> > Introduced by commit
> >
> > 9a5a6911aa3f ("staging: imx: fix non-static declarations")
>
> Sorry for the delay, now dropped from my tree, I shouldn't have taken it
> in the first place :(
>
> greg k-h
Hi,
Sorry about that. I will be more careful next time.
JB
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: build warnings after merge of the staging tree
@ 2015-05-29 10:40 Stephen Rothwell
2015-06-01 8:50 ` Stephen Rothwell
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2015-05-29 10:40 UTC (permalink / raw)
To: Greg KH
Cc: linux-next, linux-kernel, Johnny Kim, Guenter Roeck, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
Hi Greg,
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced a large number of warnings in
drivers/staging/wilc1000.
like:
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c: At top level:
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:4184:2: warning: initialization from incompatible pointer type
.add_station = WILC_WFI_add_station,
^
drivers/staging/wilc1000/linux_wlan.c: In function 'mac_open':
drivers/staging/wilc1000/linux_wlan.c:2140:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
g_linux_wlan->strInterfaceInfo[i].drvHandler = (WILC_Uint32)priv->hWILCWFIDrv;
^
drivers/staging/wilc1000/host_interface.c:708:59: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
s32Error = SendConfigPkt(SET_CFG, &strWID, 1, WILC_TRUE, (WILC_Uint32)pstrWFIDrv);
^
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: linux-next: build warnings after merge of the staging tree
2015-05-29 10:40 Stephen Rothwell
@ 2015-06-01 8:50 ` Stephen Rothwell
2015-06-20 10:48 ` Stephen Rothwell
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2015-06-01 8:50 UTC (permalink / raw)
To: Greg KH
Cc: linux-next, linux-kernel, Johnny Kim, Guenter Roeck, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
Hi Greg,
On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced a large number of warnings in
> drivers/staging/wilc1000.
Since there are so many warnings, I have disabled the driver for now.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build warnings after merge of the staging tree
2015-06-01 8:50 ` Stephen Rothwell
@ 2015-06-20 10:48 ` Stephen Rothwell
2015-06-20 14:50 ` Greg KH
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2015-06-20 10:48 UTC (permalink / raw)
To: Greg KH
Cc: linux-next, linux-kernel, Johnny Kim, Guenter Roeck, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
Hi Greg,
On Mon, 1 Jun 2015 18:50:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the staging tree, today's linux-next build (x86_64
> > allmodconfig) produced a large number of warnings in
> > drivers/staging/wilc1000.
>
> Since there are so many warnings, I have disabled the driver for now.
I tried building this with the driver enabled but it still produces and
inordinate number of warnings, so I have disabled it again. Please
either get them sorted out or disable this driver before asking Linus
to merge it.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build warnings after merge of the staging tree
2015-06-20 10:48 ` Stephen Rothwell
@ 2015-06-20 14:50 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2015-06-20 14:50 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Johnny Kim, Guenter Roeck, Arnd Bergmann
On Sat, Jun 20, 2015 at 08:48:26PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Mon, 1 Jun 2015 18:50:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the staging tree, today's linux-next build (x86_64
> > > allmodconfig) produced a large number of warnings in
> > > drivers/staging/wilc1000.
> >
> > Since there are so many warnings, I have disabled the driver for now.
>
> I tried building this with the driver enabled but it still produces and
> inordinate number of warnings, so I have disabled it again. Please
> either get them sorted out or disable this driver before asking Linus
> to merge it.
Yeah, I know, I keep asking the driver authors for fixes, but nothing
has shown up yet except cosmetic changes. I'm going to disable it as no
one seems willing to do the work, which is sad.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build warnings after merge of the staging tree
@ 2015-06-20 14:50 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2015-06-20 14:50 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Johnny Kim, Guenter Roeck, Arnd Bergmann
On Sat, Jun 20, 2015 at 08:48:26PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Mon, 1 Jun 2015 18:50:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the staging tree, today's linux-next build (x86_64
> > > allmodconfig) produced a large number of warnings in
> > > drivers/staging/wilc1000.
> >
> > Since there are so many warnings, I have disabled the driver for now.
>
> I tried building this with the driver enabled but it still produces and
> inordinate number of warnings, so I have disabled it again. Please
> either get them sorted out or disable this driver before asking Linus
> to merge it.
Yeah, I know, I keep asking the driver authors for fixes, but nothing
has shown up yet except cosmetic changes. I'm going to disable it as no
one seems willing to do the work, which is sad.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: build warnings after merge of the staging tree
@ 2015-05-06 4:10 Stephen Rothwell
2015-05-06 6:56 ` Julia Lawall
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2015-05-06 4:10 UTC (permalink / raw)
To: Greg KH, Julia Lawall; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
Hi Greg,
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
drivers/staging/lustre/lustre/llite/file.c: In function 'll_iocontrol_unregister':
drivers/staging/lustre/lustre/llite/file.c:3249:17: warning: unused variable 'size' [-Wunused-variable]
unsigned int size = tmp->iocd_size;
^
drivers/staging/lustre/lustre/llite/llite_lib.c: In function 'll_fill_super':
drivers/staging/lustre/lustre/llite/llite_lib.c:912:12: warning: unused variable 'instlen' [-Wunused-variable]
const int instlen = sizeof(cfg->cfg_instance) * 2 + 2;
^
Introduced by commit 97903a26fcfc ("staging: lustre: llite: drop uses
of OBD free functions").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: linux-next: build warnings after merge of the staging tree
2015-05-06 4:10 Stephen Rothwell
@ 2015-05-06 6:56 ` Julia Lawall
0 siblings, 0 replies; 19+ messages in thread
From: Julia Lawall @ 2015-05-06 6:56 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Greg KH, linux-next, linux-kernel
On Wed, 6 May 2015, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> drivers/staging/lustre/lustre/llite/file.c: In function 'll_iocontrol_unregister':
> drivers/staging/lustre/lustre/llite/file.c:3249:17: warning: unused variable 'size' [-Wunused-variable]
> unsigned int size = tmp->iocd_size;
> ^
> drivers/staging/lustre/lustre/llite/llite_lib.c: In function 'll_fill_super':
> drivers/staging/lustre/lustre/llite/llite_lib.c:912:12: warning: unused variable 'instlen' [-Wunused-variable]
> const int instlen = sizeof(cfg->cfg_instance) * 2 + 2;
> ^
>
> Introduced by commit 97903a26fcfc ("staging: lustre: llite: drop uses
> of OBD free functions").
Sorry for not having noticed. I will take care of it as soon as possible.
julia
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: build warnings after merge of the staging tree
@ 2012-01-31 3:25 Stephen Rothwell
2012-01-31 5:14 ` Greg KH
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2012-01-31 3:25 UTC (permalink / raw)
To: Greg KH; +Cc: linux-next, linux-kernel, Mark Allyn, Andy Shevchenko, Alan Cox
[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]
Hi Greg,
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
drivers/staging/sep/sep_main.c: In function 'sep_allocate_dmatables_region':
drivers/staging/sep/sep_main.c:217:2: warning: format '%X' expects argument of type 'unsigned int', but argument 5 has type 'size_t' [-Wformat]
drivers/staging/sep/sep_main.c: In function 'sep_activate_msgarea_context':
drivers/staging/sep/sep_main.c:3348:5: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
drivers/staging/sep/sep_main.c: In function 'sep_create_msgarea_context':
drivers/staging/sep/sep_main.c:3380:5: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
drivers/staging/sep/sep_main.c: In function 'sep_read':
drivers/staging/sep/sep_main.c:3466:2: warning: format '%X' expects argument of type 'unsigned int', but argument 5 has type 'size_t' [-Wformat]
drivers/staging/sep/sep_main.c: In function 'sep_fastcall_args_get':
drivers/staging/sep/sep_main.c:3526:5: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
drivers/staging/sep/sep_main.c:3567:5: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
drivers/staging/sep/sep_main.c:3567:5: warning: format '%X' expects argument of type 'unsigned int', but argument 5 has type 'size_t' [-Wformat]
Introduced by commit ff3d9c3c90c6 ("staging: sep: SEP update").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: linux-next: build warnings after merge of the staging tree
2012-01-31 3:25 Stephen Rothwell
@ 2012-01-31 5:14 ` Greg KH
0 siblings, 0 replies; 19+ messages in thread
From: Greg KH @ 2012-01-31 5:14 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Mark Allyn, Andy Shevchenko, Alan Cox
On Tue, Jan 31, 2012 at 02:25:21PM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> drivers/staging/sep/sep_main.c: In function 'sep_allocate_dmatables_region':
> drivers/staging/sep/sep_main.c:217:2: warning: format '%X' expects argument of type 'unsigned int', but argument 5 has type 'size_t' [-Wformat]
> drivers/staging/sep/sep_main.c: In function 'sep_activate_msgarea_context':
> drivers/staging/sep/sep_main.c:3348:5: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
> drivers/staging/sep/sep_main.c: In function 'sep_create_msgarea_context':
> drivers/staging/sep/sep_main.c:3380:5: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
> drivers/staging/sep/sep_main.c: In function 'sep_read':
> drivers/staging/sep/sep_main.c:3466:2: warning: format '%X' expects argument of type 'unsigned int', but argument 5 has type 'size_t' [-Wformat]
> drivers/staging/sep/sep_main.c: In function 'sep_fastcall_args_get':
> drivers/staging/sep/sep_main.c:3526:5: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
> drivers/staging/sep/sep_main.c:3567:5: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
> drivers/staging/sep/sep_main.c:3567:5: warning: format '%X' expects argument of type 'unsigned int', but argument 5 has type 'size_t' [-Wformat]
>
> Introduced by commit ff3d9c3c90c6 ("staging: sep: SEP update").
Thanks, I've already told Alan about them, he said he would resolve them
soon.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2019-02-05 10:24 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 4:38 linux-next: build warnings after merge of the staging tree Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2019-02-05 3:22 Stephen Rothwell
2019-02-05 10:24 ` Jonathan Cameron
2018-05-14 4:34 Stephen Rothwell
2018-05-14 9:26 ` Greg KH
2017-07-31 5:02 Stephen Rothwell
2017-08-09 1:25 ` Stephen Rothwell
2017-08-22 1:49 ` Stephen Rothwell
2017-08-17 17:57 ` Greg KH
2017-08-18 12:02 ` JB Van Puyvelde
2015-05-29 10:40 Stephen Rothwell
2015-06-01 8:50 ` Stephen Rothwell
2015-06-20 10:48 ` Stephen Rothwell
2015-06-20 14:50 ` Greg KH
2015-06-20 14:50 ` Greg KH
2015-05-06 4:10 Stephen Rothwell
2015-05-06 6:56 ` Julia Lawall
2012-01-31 3:25 Stephen Rothwell
2012-01-31 5:14 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.