From: Christoph Paasch <cpaasch@apple.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] tcp: Always cleanup skb before sending
Date: Thu, 02 Nov 2017 11:16:58 -0700 [thread overview]
Message-ID: <20171102181658.GU44287@da0602a-dhcp105.apple.com> (raw)
In-Reply-To: <1509584410.3828.64.camel@edumazet-glaptop3.roam.corp.google.com>
On 01/11/17 - 18:00:10, Eric Dumazet wrote:
> On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote:
>
> > Yes, that looks good to me. Thanks!
> >
> > But we still need to clean up the skb in tcp_v4_send_reset and
> > tcp_v4_send_ack, as the fields (e.g., tcp_skb_cb->seq) have been set when
> > coming from tcp_v4_rcv.
>
> You might be confused : ip_send_unicast_reply() does not send back the
> incoming skb.
>
> A fresh skb is allocated, then appended/sent.
>
> And commit 24a2d43d8886f5a29c did the changes to provide to
> __ip_options_echo() the proper IPCB header location.
Yes, sorry I misunderstood ip_send_unicast_reply(). Didn't see the
allocation of the new skb.
Christoph
prev parent reply other threads:[~2017-11-02 18:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 21:10 [PATCH net] tcp: Always cleanup skb before sending Christoph Paasch
2017-11-01 21:32 ` Eric Dumazet
2017-11-01 21:53 ` Eric Dumazet
2017-11-02 0:10 ` Christoph Paasch
2017-11-02 1:00 ` Eric Dumazet
2017-11-02 2:21 ` Eric Dumazet
2017-11-02 18:24 ` Christoph Paasch
2017-11-02 18:26 ` Eric Dumazet
2017-11-02 18:31 ` Christoph Paasch
2017-11-02 19:30 ` [PATCH net] tcp: do not mangle skb->cb[] in tcp_make_synack() Eric Dumazet
2017-11-02 19:49 ` Christoph Paasch
2017-11-03 5:32 ` David Miller
2017-11-02 18:16 ` Christoph Paasch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102181658.GU44287@da0602a-dhcp105.apple.com \
--to=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.