From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme: Factor get log into a helper
Date: Thu, 2 Nov 2017 20:39:26 +0100 [thread overview]
Message-ID: <20171102193926.GA5270@lst.de> (raw)
In-Reply-To: <20171101180400.6619-1-keith.busch@intel.com>
> +static int nvme_get_log(struct nvme_ctrl *ctrl, u8 log_page, void *log,
> + size_t size)
The argument alignmnet here looks a little odd, but we can fix that
up on the go.
Except for that this looks fine to me:
Reviewed-by: Christoph Hellwig <hch at lst.de>
prev parent reply other threads:[~2017-11-02 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 18:03 [PATCH 1/2] nvme: Factor get log into a helper Keith Busch
2017-11-01 18:04 ` [PATCH 2/2] nvme: Check admin passthru command effects Keith Busch
2017-11-02 9:00 ` Minwoo Im
2017-11-02 19:44 ` Christoph Hellwig
2017-11-02 13:54 ` [PATCH 1/2] nvme: Factor get log into a helper Javier González
2017-11-02 19:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102193926.GA5270@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.