All of lore.kernel.org
 help / color / mirror / Atom feed
From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH 2/2] nvme: Check admin passthru command effects
Date: Thu, 2 Nov 2017 18:00:15 +0900	[thread overview]
Message-ID: <CAA7jztcsxofX35nbg3UkA3MP0CE6FAV8cmTHavBmigeQq2gCjA@mail.gmail.com> (raw)
In-Reply-To: <20171101180400.6619-2-keith.busch@intel.com>

Hi Keith,

I have found a tiny typo in a comment during a review your code.

> +
> +static void nvme_passthru_end(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> +                                                               u32 effects)
> +{
> +       /*
> +        * Revaildate LBA changes prior to unfreezing. This is necessary to
> +        * prevent memory corruption if a logical block size was changed by
> +        * this command.

"Revalidate" seems okay for this comment.

> +        */
> +       if (effects & NVME_CMD_EFFECTS_LBCC)
> +               nvme_update_formats(ctrl);
> +       if (effects & (NVME_CMD_EFFECTS_LBCC | NVME_CMD_EFFECTS_CSE_MASK))
> +               nvme_unfreeze(ctrl);
> +       if (effects & NVME_CMD_EFFECTS_CCC)
> +               nvme_init_identify(ctrl);
> +       if (effects & (NVME_CMD_EFFECTS_NIC | NVME_CMD_EFFECTS_NCC))
> +               nvme_queue_scan(ctrl);
> +}
> +

I always appreciate your dedication to this amazing nvme driver.
Thanks,

Minwoo

  reply	other threads:[~2017-11-02  9:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01 18:03 [PATCH 1/2] nvme: Factor get log into a helper Keith Busch
2017-11-01 18:04 ` [PATCH 2/2] nvme: Check admin passthru command effects Keith Busch
2017-11-02  9:00   ` Minwoo Im [this message]
2017-11-02 19:44   ` Christoph Hellwig
2017-11-02 13:54 ` [PATCH 1/2] nvme: Factor get log into a helper Javier González
2017-11-02 19:39 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA7jztcsxofX35nbg3UkA3MP0CE6FAV8cmTHavBmigeQq2gCjA@mail.gmail.com \
    --to=minwoo.im.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.