From: David Miller <davem@davemloft.net>
To: privat@egil-hjelmeland.no
Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
f.fainelli@gmail.com, rafal@milecki.pl,
stephen@networkplumber.org, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h
Date: Fri, 03 Nov 2017 14:18:39 +0900 (KST) [thread overview]
Message-ID: <20171103.141839.1785916247470411683.davem@davemloft.net> (raw)
In-Reply-To: <20171102093648.4141-1-privat@egil-hjelmeland.no>
From: Egil Hjelmeland <privat@egil-hjelmeland.no>
Date: Thu, 2 Nov 2017 10:36:48 +0100
> The lan9303 driver defines eth_stp_addr as a synonym to
> eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00.
>
> eth_reserved_addr_base is also used to define the start of Bridge Reserved
> ethernet address range, which happen to be the STP address.
>
> br_dev_setup refer to eth_reserved_addr_base as a definition of STP
> address.
>
> Clean up by:
> - Move the eth_stp_addr definition to linux/etherdevice.h
> - Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup.
>
> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
Applied, thank you.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: privat@egil-hjelmeland.no
Cc: andrew@lunn.ch, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
rafal@milecki.pl
Subject: Re: [Bridge] [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h
Date: Fri, 03 Nov 2017 14:18:39 +0900 (KST) [thread overview]
Message-ID: <20171103.141839.1785916247470411683.davem@davemloft.net> (raw)
In-Reply-To: <20171102093648.4141-1-privat@egil-hjelmeland.no>
From: Egil Hjelmeland <privat@egil-hjelmeland.no>
Date: Thu, 2 Nov 2017 10:36:48 +0100
> The lan9303 driver defines eth_stp_addr as a synonym to
> eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00.
>
> eth_reserved_addr_base is also used to define the start of Bridge Reserved
> ethernet address range, which happen to be the STP address.
>
> br_dev_setup refer to eth_reserved_addr_base as a definition of STP
> address.
>
> Clean up by:
> - Move the eth_stp_addr definition to linux/etherdevice.h
> - Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup.
>
> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
Applied, thank you.
next prev parent reply other threads:[~2017-11-03 5:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 9:36 [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h Egil Hjelmeland
2017-11-02 12:53 ` Andrew Lunn
2017-11-02 12:53 ` [Bridge] " Andrew Lunn
2017-11-03 5:18 ` David Miller [this message]
2017-11-03 5:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103.141839.1785916247470411683.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=privat@egil-hjelmeland.no \
--cc=rafal@milecki.pl \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.