All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francisco Iglesias <frasse.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Cc: edgari@xilinx.com, alistai@xilinx.com,
	francisco.iglesias@feimtech.se, mar.krzeminski@gmail.com,
	peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v7 10/13] xilinx_spips: Add support for 4 byte addresses in the LQSPI
Date: Fri,  3 Nov 2017 01:01:06 +0100	[thread overview]
Message-ID: <20171103000109.28244-11-frasse.iglesias@gmail.com> (raw)
In-Reply-To: <20171103000109.28244-1-frasse.iglesias@gmail.com>

Add support for 4 byte addresses in the LQSPI and correct LQSPI_CFG_SEP_BUS.

Signed-off-by: Francisco Iglesias <frasse.iglesias@gmail.com>
---
 hw/ssi/xilinx_spips.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index 3a98799..7f0f317 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -92,8 +92,9 @@
 #define R_LQSPI_CFG_RESET       0x03A002EB
 #define LQSPI_CFG_LQ_MODE       (1U << 31)
 #define LQSPI_CFG_TWO_MEM       (1 << 30)
-#define LQSPI_CFG_SEP_BUS       (1 << 30)
+#define LQSPI_CFG_SEP_BUS       (1 << 29)
 #define LQSPI_CFG_U_PAGE        (1 << 28)
+#define LQSPI_CFG_ADDR4         (1 << 27)
 #define LQSPI_CFG_MODE_EN       (1 << 25)
 #define LQSPI_CFG_MODE_WIDTH    8
 #define LQSPI_CFG_MODE_SHIFT    16
@@ -702,6 +703,9 @@ static void lqspi_load_cache(void *opaque, hwaddr addr)
         fifo8_push(&s->tx_fifo, s->regs[R_LQSPI_CFG] & LQSPI_CFG_INST_CODE);
         /* read address */
         DB_PRINT_L(0, "pushing read address %06x\n", flash_addr);
+        if (s->regs[R_LQSPI_CFG] & LQSPI_CFG_ADDR4) {
+            fifo8_push(&s->tx_fifo, (uint8_t)(flash_addr >> 24));
+        }
         fifo8_push(&s->tx_fifo, (uint8_t)(flash_addr >> 16));
         fifo8_push(&s->tx_fifo, (uint8_t)(flash_addr >> 8));
         fifo8_push(&s->tx_fifo, (uint8_t)flash_addr);
-- 
2.9.3

  parent reply	other threads:[~2017-11-03  0:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03  0:00 [Qemu-devel] [PATCH v7 00/13] Add support for the ZynqMP Generic QSPI Francisco Iglesias
2017-11-03  0:00 ` [Qemu-devel] [PATCH v7 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR Francisco Iglesias
2017-11-03 16:18   ` mar.krzeminski
2017-11-03 17:25     ` francisco iglesias
2017-11-03 20:34       ` mar.krzeminski
2017-11-03  0:00 ` [Qemu-devel] [PATCH v7 02/13] m25p80: Add support for SST READ ID 0x90/0xAB commands Francisco Iglesias
2017-11-03  0:00 ` [Qemu-devel] [PATCH v7 03/13] m25p80: Add support for BRRD/BRWR and BULK_ERASE (0x60) Francisco Iglesias
2017-11-03  0:01 ` [Qemu-devel] [PATCH v7 04/13] m25p80: Add support for n25q512a11 and n25q512a13 Francisco Iglesias
2017-11-03  0:01 ` [Qemu-devel] [PATCH v7 05/13] xilinx_spips: Move FlashCMD, XilinxQSPIPS and XilinxSPIPSClass Francisco Iglesias
2017-11-23  0:33   ` Alistair Francis
2017-11-03  0:01 ` [Qemu-devel] [PATCH v7 06/13] xilinx_spips: Update striping to be big-endian bit order Francisco Iglesias
2017-11-23  0:36   ` Alistair Francis
2017-11-03  0:01 ` [Qemu-devel] [PATCH v7 07/13] xilinx_spips: Add support for RX discard and RX drain Francisco Iglesias
2017-11-03  0:01 ` [Qemu-devel] [PATCH v7 08/13] xilinx_spips: Make tx/rx_data_bytes more generic and reusable Francisco Iglesias
2017-11-03  0:01 ` [Qemu-devel] [PATCH v7 09/13] xilinx_spips: Add support for zero pumping Francisco Iglesias
2017-11-03  0:01 ` Francisco Iglesias [this message]
2017-11-23  0:37   ` [Qemu-devel] [PATCH v7 10/13] xilinx_spips: Add support for 4 byte addresses in the LQSPI Alistair Francis
2017-11-03  0:01 ` [Qemu-devel] [PATCH v7 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done Francisco Iglesias
2017-11-23  0:39   ` Alistair Francis
2017-11-23 19:51     ` francisco iglesias
2017-11-03  0:01 ` [Qemu-devel] [PATCH v7 12/13] xilinx_spips: Add support for the ZynqMP Generic QSPI Francisco Iglesias
2017-11-03  0:01 ` [Qemu-devel] [PATCH v7 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI Francisco Iglesias
2017-11-21 18:39 ` [Qemu-devel] [PATCH v7 00/13] Add support for the ZynqMP Generic QSPI Peter Maydell
2017-11-23  0:30   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171103000109.28244-11-frasse.iglesias@gmail.com \
    --to=frasse.iglesias@gmail.com \
    --cc=alistai@xilinx.com \
    --cc=edgari@xilinx.com \
    --cc=francisco.iglesias@feimtech.se \
    --cc=mar.krzeminski@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.