* [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt.
@ 2017-11-02 12:14 Guo Ren
2017-11-02 16:27 ` Yann E. MORIN
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Guo Ren @ 2017-11-02 12:14 UTC (permalink / raw)
To: buildroot
The "install-bin" just install dtc's programs to host/bin without
libfdt, but qemu system compile need libfdt.
see: https://gitlab.com/c-sky/buildroot/-/jobs/38654503
So we need install libfdt to satisfy qemu system compile.
Change-Id: I85748479ac11e1c6452d3f79d04f02666218774a
Signed-off-by: Guo Ren <ren_guo@c-sky.com>
---
package/dtc/dtc.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/dtc/dtc.mk b/package/dtc/dtc.mk
index dd0f30d..1bcee29 100644
--- a/package/dtc/dtc.mk
+++ b/package/dtc/dtc.mk
@@ -51,7 +51,7 @@ define HOST_DTC_BUILD_CMDS
endef
define HOST_DTC_INSTALL_CMDS
- $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=$(HOST_DIR) install-bin
+ $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=$(HOST_DIR) install
endef
$(eval $(generic-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt.
2017-11-02 12:14 [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt Guo Ren
@ 2017-11-02 16:27 ` Yann E. MORIN
2017-11-03 1:49 ` Guo Ren
2017-11-02 21:14 ` Thomas Petazzoni
2017-11-03 2:00 ` Jan Kundrát
2 siblings, 1 reply; 9+ messages in thread
From: Yann E. MORIN @ 2017-11-02 16:27 UTC (permalink / raw)
To: buildroot
Guo Ren, All,
On 2017-11-02 20:14 +0800, Guo Ren spake thusly:
> The "install-bin" just install dtc's programs to host/bin without
> libfdt, but qemu system compile need libfdt.
>
> see: https://gitlab.com/c-sky/buildroot/-/jobs/38654503
>
> So we need install libfdt to satisfy qemu system compile.
>
> Change-Id: I85748479ac11e1c6452d3f79d04f02666218774a
What's this Change-Id tag? We do not want to carry per-project specific
tags. If you want/need to point to some related reference, just add an
URL pointing to it.
Otherwise:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> ---
> package/dtc/dtc.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/dtc/dtc.mk b/package/dtc/dtc.mk
> index dd0f30d..1bcee29 100644
> --- a/package/dtc/dtc.mk
> +++ b/package/dtc/dtc.mk
> @@ -51,7 +51,7 @@ define HOST_DTC_BUILD_CMDS
> endef
>
> define HOST_DTC_INSTALL_CMDS
> - $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=$(HOST_DIR) install-bin
> + $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=$(HOST_DIR) install
> endef
>
> $(eval $(generic-package))
> --
> 2.7.4
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt.
2017-11-02 16:27 ` Yann E. MORIN
@ 2017-11-03 1:49 ` Guo Ren
0 siblings, 0 replies; 9+ messages in thread
From: Guo Ren @ 2017-11-03 1:49 UTC (permalink / raw)
To: buildroot
Hi Yanni E,
On Thu, Noj 02, 2017 at 05:27:08PM +0100, Yann E. MORIN wrote:
> What's this Change-Id tag? We do not want to carry per-project specific
> tags. If you want/need to point to some related reference, just add an
> URL pointing to it.
>
Change-Id is from my git-hook for my gerrit system, and I forgot to
remove it, sorry.
Best Regards
Guo Ren
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt.
2017-11-02 12:14 [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt Guo Ren
2017-11-02 16:27 ` Yann E. MORIN
@ 2017-11-02 21:14 ` Thomas Petazzoni
2017-11-03 2:00 ` Jan Kundrát
2 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2017-11-02 21:14 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 2 Nov 2017 20:14:33 +0800, Guo Ren wrote:
> The "install-bin" just install dtc's programs to host/bin without
> libfdt, but qemu system compile need libfdt.
>
> see: https://gitlab.com/c-sky/buildroot/-/jobs/38654503
>
> So we need install libfdt to satisfy qemu system compile.
>
> Change-Id: I85748479ac11e1c6452d3f79d04f02666218774a
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> ---
> package/dtc/dtc.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, after minor commit log tweaks.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt.
2017-11-02 12:14 [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt Guo Ren
2017-11-02 16:27 ` Yann E. MORIN
2017-11-02 21:14 ` Thomas Petazzoni
@ 2017-11-03 2:00 ` Jan Kundrát
2017-11-03 2:33 ` Jan Kundrát
2 siblings, 1 reply; 9+ messages in thread
From: Jan Kundrát @ 2017-11-03 2:00 UTC (permalink / raw)
To: buildroot
This change breaks U-Boot 2017.09 because now U-Boot finds a copy of libfdt
installed by host-dtc. Yes, it's probably a bug in U-Boot that it includes
these files via <system-path>.
Here's how U-Boot build dies for me now:
tools/fdtgrep.c:228:21: error: array type has incomplete element type
struct fdt_region region[], int count)
^
Cheers,
Jan
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt.
2017-11-03 2:00 ` Jan Kundrát
@ 2017-11-03 2:33 ` Jan Kundrát
2017-11-04 20:51 ` Arnout Vandecappelle
0 siblings, 1 reply; 9+ messages in thread
From: Jan Kundrát @ 2017-11-03 2:33 UTC (permalink / raw)
To: buildroot
...and here's a simple patch against U-Boot which fixes the build for me.
It seems that U-Boot is special in Buildroot when it comes to patch
handling. I also don't know whether it's reasonable to patch it like this
instead of not installing libfdt from the DTC. I also looked at U-Boot's
patchwork and noticed that there's aparently an active series where someone
is refactoring libfdt wrappers.
TL;DR: it's a mess. This fixes stuff for me, feel free to pick in any way
you feel is appropriate.
My mail with this patch to upstream U-Boot is in a moderation queue, so I'm
posting it at least here.
Cheers,
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uboot-no-system-libfdt.patch
Type: text/x-patch
Size: 1223 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171103/92a2928e/attachment.bin>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt.
2017-11-03 2:33 ` Jan Kundrát
@ 2017-11-04 20:51 ` Arnout Vandecappelle
2017-11-06 15:41 ` Matthew Weber
0 siblings, 1 reply; 9+ messages in thread
From: Arnout Vandecappelle @ 2017-11-04 20:51 UTC (permalink / raw)
To: buildroot
On 03-11-17 03:33, Jan Kundr?t wrote:
> ...and here's a simple patch against U-Boot which fixes the build for me.
Isn't the build already fixed if you only replace the ../include line? The
../lib/libfdt/fdt.h should not be problematic since that file doesn't exist in
STAGING_DIR. Right? Same for libfdt_internal.h.
> It
> seems that U-Boot is special in Buildroot when it comes to patch handling.
Indeed, because the U-Boot version is configurable so it's impossible to say if
a patch can apply.
However, it would be possible to do the fixup using sed, e.g.
$(SED) 's%<../include/libfdt.h>%"../include/libfdt.h"%' $(@D)/tools/fdtgrep.c
in a post-patch hook.
Regards,
Arnout
> I
> also don't know whether it's reasonable to patch it like this instead of not
> installing libfdt from the DTC. I also looked at U-Boot's patchwork and noticed
> that there's aparently an active series where someone is refactoring libfdt
> wrappers.
>
> TL;DR: it's a mess. This fixes stuff for me, feel free to pick in any way you
> feel is appropriate.
>
> My mail with this patch to upstream U-Boot is in a moderation queue, so I'm
> posting it at least here.
>
> Cheers,
> Jan
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt.
2017-11-04 20:51 ` Arnout Vandecappelle
@ 2017-11-06 15:41 ` Matthew Weber
2017-11-06 17:40 ` Matthew Weber
0 siblings, 1 reply; 9+ messages in thread
From: Matthew Weber @ 2017-11-06 15:41 UTC (permalink / raw)
To: buildroot
Jan/Arnout,
On Sat, Nov 4, 2017 at 3:51 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
> On 03-11-17 03:33, Jan Kundr?t wrote:
>> ...and here's a simple patch against U-Boot which fixes the build for me.
>
> Isn't the build already fixed if you only replace the ../include line? The
> ../lib/libfdt/fdt.h should not be problematic since that file doesn't exist in
> STAGING_DIR. Right? Same for libfdt_internal.h.
>
I've got a number of internal CI failures from this one. I'm testing
the combined uboot-tools and uboot fix against my cases and will send
a patch later today.
Matt
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt.
2017-11-06 15:41 ` Matthew Weber
@ 2017-11-06 17:40 ` Matthew Weber
0 siblings, 0 replies; 9+ messages in thread
From: Matthew Weber @ 2017-11-06 17:40 UTC (permalink / raw)
To: buildroot
Arnout, Jan
On Mon, Nov 6, 2017 at 9:41 AM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
>
> Jan/Arnout,
>
> On Sat, Nov 4, 2017 at 3:51 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> >
> >
> > On 03-11-17 03:33, Jan Kundr?t wrote:
> >> ...and here's a simple patch against U-Boot which fixes the build for me.
> >
> > Isn't the build already fixed if you only replace the ../include line? The
> > ../lib/libfdt/fdt.h should not be problematic since that file doesn't exist in
> > STAGING_DIR. Right? Same for libfdt_internal.h.
> >
>
> I've got a number of internal CI failures from this one. I'm testing
> the combined uboot-tools and uboot fix against my cases and will send
> a patch later today.
>
https://patchwork.ozlabs.org/patch/834861/
https://patchwork.ozlabs.org/patch/834862/
Matt
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-11-06 17:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 12:14 [Buildroot] [PATCH 1/1] package/dtc: qemu system build need libfdt Guo Ren
2017-11-02 16:27 ` Yann E. MORIN
2017-11-03 1:49 ` Guo Ren
2017-11-02 21:14 ` Thomas Petazzoni
2017-11-03 2:00 ` Jan Kundrát
2017-11-03 2:33 ` Jan Kundrát
2017-11-04 20:51 ` Arnout Vandecappelle
2017-11-06 15:41 ` Matthew Weber
2017-11-06 17:40 ` Matthew Weber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.