* [PATCH] media: imx274: fix missing return assignment from call to imx274_mode_regs
@ 2017-11-03 6:41 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2017-11-03 6:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Leon Luo, Sakari Ailus, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable ret is being checked for failure however it is not being set
from the return status from the call to imx274_mode_regs. Currently ret is
alwayus zero and the check is redundant. Fix this by assigning it.
Detected by CoverityScan, CID#1460278 ("Logically dead code")
Fixes: 0985dd306f72 ("media: imx274: V4l2 driver for Sony imx274 CMOS sensor")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index ab6a5f31da74..800b9bf9cdd3 100644
--- a/drivers/media/i2c/imx274.c
+++ b/drivers/media/i2c/imx274.c
@@ -1059,7 +1059,7 @@ static int imx274_s_stream(struct v4l2_subdev *sd, int on)
if (on) {
/* load mode registers */
- imx274_mode_regs(imx274, imx274->mode_index);
+ ret = imx274_mode_regs(imx274, imx274->mode_index);
if (ret)
goto fail;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] media: imx274: fix missing return assignment from call to imx274_mode_regs
@ 2017-11-03 6:41 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2017-11-03 6:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Leon Luo, Sakari Ailus, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable ret is being checked for failure however it is not being set
from the return status from the call to imx274_mode_regs. Currently ret is
alwayus zero and the check is redundant. Fix this by assigning it.
Detected by CoverityScan, CID#1460278 ("Logically dead code")
Fixes: 0985dd306f72 ("media: imx274: V4l2 driver for Sony imx274 CMOS sensor")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index ab6a5f31da74..800b9bf9cdd3 100644
--- a/drivers/media/i2c/imx274.c
+++ b/drivers/media/i2c/imx274.c
@@ -1059,7 +1059,7 @@ static int imx274_s_stream(struct v4l2_subdev *sd, int on)
if (on) {
/* load mode registers */
- imx274_mode_regs(imx274, imx274->mode_index);
+ ret = imx274_mode_regs(imx274, imx274->mode_index);
if (ret)
goto fail;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-03 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 6:41 [PATCH] media: imx274: fix missing return assignment from call to imx274_mode_regs Colin King
2017-11-03 6:41 ` Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.