All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: koelsch: Move cec_clock to root node
@ 2017-11-02  9:18 ` Simon Horman
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-11-02  9:18 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Laurent Pinchart, Biju Das, Simon Horman

cec-clock is a fixed clock generator that is not controlled by i2c5 and
thus should not be a child of the i2c5 bus node. Rather, it should be
a child of the root node of the DT.

Fixes: 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI transmitter")
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index e164eda69baf..4126de417922 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -278,6 +278,12 @@
 		};
 	};
 
+	cec_clock: cec-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <12000000>;
+	};
+
 	hdmi-out {
 		compatible = "hdmi-connector";
 		type = "a";
@@ -640,12 +646,6 @@
 		};
 	};
 
-	cec_clock: cec-clock {
-		compatible = "fixed-clock";
-		#clock-cells = <0>;
-		clock-frequency = <12000000>;
-	};
-
 	hdmi@39 {
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: koelsch: Move cec_clock to root node
@ 2017-11-02  9:18 ` Simon Horman
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-11-02  9:18 UTC (permalink / raw)
  To: linux-arm-kernel

cec-clock is a fixed clock generator that is not controlled by i2c5 and
thus should not be a child of the i2c5 bus node. Rather, it should be
a child of the root node of the DT.

Fixes: 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI transmitter")
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index e164eda69baf..4126de417922 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -278,6 +278,12 @@
 		};
 	};
 
+	cec_clock: cec-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <12000000>;
+	};
+
 	hdmi-out {
 		compatible = "hdmi-connector";
 		type = "a";
@@ -640,12 +646,6 @@
 		};
 	};
 
-	cec_clock: cec-clock {
-		compatible = "fixed-clock";
-		#clock-cells = <0>;
-		clock-frequency = <12000000>;
-	};
-
 	hdmi at 39 {
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: koelsch: Move cec_clock to root node
  2017-11-02  9:18 ` Simon Horman
@ 2017-11-02 17:39   ` Laurent Pinchart
  -1 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2017-11-02 17:39 UTC (permalink / raw)
  To: Simon Horman; +Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm, Biju Das

Hi Simon,

Thank you for the patch.

On Thursday, 2 November 2017 11:18:05 EET Simon Horman wrote:
> cec-clock is a fixed clock generator that is not controlled by i2c5 and
> thus should not be a child of the i2c5 bus node. Rather, it should be
> a child of the root node of the DT.
> 
> Fixes: 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI
> transmitter") Reported-by: Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> b/arch/arm/boot/dts/r8a7791-koelsch.dts index e164eda69baf..4126de417922
> 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -278,6 +278,12 @@
>  		};
>  	};
> 
> +	cec_clock: cec-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <12000000>;
> +	};
> +
>  	hdmi-out {
>  		compatible = "hdmi-connector";
>  		type = "a";
> @@ -640,12 +646,6 @@
>  		};
>  	};
> 
> -	cec_clock: cec-clock {
> -		compatible = "fixed-clock";
> -		#clock-cells = <0>;
> -		clock-frequency = <12000000>;
> -	};
> -
>  	hdmi@39 {
>  		compatible = "adi,adv7511w";
>  		reg = <0x39>;


-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: koelsch: Move cec_clock to root node
@ 2017-11-02 17:39   ` Laurent Pinchart
  0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2017-11-02 17:39 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon,

Thank you for the patch.

On Thursday, 2 November 2017 11:18:05 EET Simon Horman wrote:
> cec-clock is a fixed clock generator that is not controlled by i2c5 and
> thus should not be a child of the i2c5 bus node. Rather, it should be
> a child of the root node of the DT.
> 
> Fixes: 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI
> transmitter") Reported-by: Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> b/arch/arm/boot/dts/r8a7791-koelsch.dts index e164eda69baf..4126de417922
> 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -278,6 +278,12 @@
>  		};
>  	};
> 
> +	cec_clock: cec-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <12000000>;
> +	};
> +
>  	hdmi-out {
>  		compatible = "hdmi-connector";
>  		type = "a";
> @@ -640,12 +646,6 @@
>  		};
>  	};
> 
> -	cec_clock: cec-clock {
> -		compatible = "fixed-clock";
> -		#clock-cells = <0>;
> -		clock-frequency = <12000000>;
> -	};
> -
>  	hdmi at 39 {
>  		compatible = "adi,adv7511w";
>  		reg = <0x39>;


-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: koelsch: Move cec_clock to root node
  2017-11-02 17:39   ` Laurent Pinchart
@ 2017-11-03  8:04     ` Simon Horman
  -1 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-11-03  8:04 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm, Biju Das

On Thu, Nov 02, 2017 at 07:39:18PM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> Thank you for the patch.
> 
> On Thursday, 2 November 2017 11:18:05 EET Simon Horman wrote:
> > cec-clock is a fixed clock generator that is not controlled by i2c5 and
> > thus should not be a child of the i2c5 bus node. Rather, it should be
> > a child of the root node of the DT.
> > 
> > Fixes: 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI
> > transmitter") Reported-by: Laurent Pinchart
> > <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: koelsch: Move cec_clock to root node
@ 2017-11-03  8:04     ` Simon Horman
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-11-03  8:04 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Nov 02, 2017 at 07:39:18PM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> Thank you for the patch.
> 
> On Thursday, 2 November 2017 11:18:05 EET Simon Horman wrote:
> > cec-clock is a fixed clock generator that is not controlled by i2c5 and
> > thus should not be a child of the i2c5 bus node. Rather, it should be
> > a child of the root node of the DT.
> > 
> > Fixes: 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI
> > transmitter") Reported-by: Laurent Pinchart
> > <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-03  8:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02  9:18 [PATCH] ARM: dts: koelsch: Move cec_clock to root node Simon Horman
2017-11-02  9:18 ` Simon Horman
2017-11-02 17:39 ` Laurent Pinchart
2017-11-02 17:39   ` Laurent Pinchart
2017-11-03  8:04   ` Simon Horman
2017-11-03  8:04     ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.