* [PATCH 0/3] objtool: sync warning fix and cleanups
@ 2017-11-03 14:31 Josh Poimboeuf
2017-11-03 14:31 ` [PATCH 1/3] objtool: Resync objtool's instruction decoder with the kernel's Josh Poimboeuf
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Josh Poimboeuf @ 2017-11-03 14:31 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Stephen Rothwell
Patch 1 fixes the "x86 instruction decoder differs from kernel" warning.
Patches 2-3 improve the sync checking so that future warnings will be
more useful.
Josh Poimboeuf (3):
objtool: Resync objtool's instruction decoder with the kernel's
objtool: Move synced files to their original relative locations
objtool: Move sync check to a script
tools/objtool/.gitignore | 2 +-
tools/objtool/Makefile | 20 +++------------
tools/objtool/arch/x86/Build | 10 +++-----
tools/objtool/arch/x86/decode.c | 6 ++---
.../objtool/arch/x86/{insn => include/asm}/inat.h | 2 +-
.../arch/x86/{insn => include/asm}/inat_types.h | 0
.../objtool/arch/x86/{insn => include/asm}/insn.h | 2 +-
.../objtool/{ => arch/x86/include/asm}/orc_types.h | 0
tools/objtool/arch/x86/{insn => lib}/inat.c | 2 +-
tools/objtool/arch/x86/{insn => lib}/insn.c | 4 +--
.../arch/x86/{insn => lib}/x86-opcode-map.txt | 0
.../arch/x86/{insn => tools}/gen-insn-attr-x86.awk | 1 +
tools/objtool/orc.h | 2 +-
tools/objtool/sync-check.sh | 29 ++++++++++++++++++++++
14 files changed, 48 insertions(+), 32 deletions(-)
rename tools/objtool/arch/x86/{insn => include/asm}/inat.h (99%)
rename tools/objtool/arch/x86/{insn => include/asm}/inat_types.h (100%)
rename tools/objtool/arch/x86/{insn => include/asm}/insn.h (99%)
rename tools/objtool/{ => arch/x86/include/asm}/orc_types.h (100%)
rename tools/objtool/arch/x86/{insn => lib}/inat.c (99%)
rename tools/objtool/arch/x86/{insn => lib}/insn.c (99%)
rename tools/objtool/arch/x86/{insn => lib}/x86-opcode-map.txt (100%)
rename tools/objtool/arch/x86/{insn => tools}/gen-insn-attr-x86.awk (99%)
create mode 100755 tools/objtool/sync-check.sh
--
2.13.6
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] objtool: Resync objtool's instruction decoder with the kernel's
2017-11-03 14:31 [PATCH 0/3] objtool: sync warning fix and cleanups Josh Poimboeuf
@ 2017-11-03 14:31 ` Josh Poimboeuf
2017-11-04 8:31 ` [tip:core/urgent] objtool: Resync objtool's instruction decoder source code copy with the kernel's latest version tip-bot for Josh Poimboeuf
2017-11-03 14:31 ` [PATCH 2/3] objtool: Move synced files to their original relative locations Josh Poimboeuf
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Josh Poimboeuf @ 2017-11-03 14:31 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Stephen Rothwell
This fixes the following warning:
warning: objtool: x86 instruction decoder differs from kernel
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk b/tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk
index a3d2c62fd805..b02a36b2c14f 100644
--- a/tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk
+++ b/tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk
@@ -1,4 +1,5 @@
#!/bin/awk -f
+# SPDX-License-Identifier: GPL-2.0
# gen-insn-attr-x86.awk: Instruction attribute table generator
# Written by Masami Hiramatsu <mhiramat@redhat.com>
#
--
2.13.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] objtool: Move synced files to their original relative locations
2017-11-03 14:31 [PATCH 0/3] objtool: sync warning fix and cleanups Josh Poimboeuf
2017-11-03 14:31 ` [PATCH 1/3] objtool: Resync objtool's instruction decoder with the kernel's Josh Poimboeuf
@ 2017-11-03 14:31 ` Josh Poimboeuf
2017-11-03 14:31 ` [PATCH 3/3] objtool: Move sync check to a script Josh Poimboeuf
2017-11-03 18:54 ` [PATCH 0/3] objtool: sync warning fix and cleanups Josh Poimboeuf
3 siblings, 0 replies; 7+ messages in thread
From: Josh Poimboeuf @ 2017-11-03 14:31 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Stephen Rothwell
This will enable more straightforward comparisons, and it also allows
the files to be 100% identical.
Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
tools/objtool/.gitignore | 2 +-
tools/objtool/Makefile | 20 +++++++++++---------
tools/objtool/arch/x86/Build | 10 ++++------
tools/objtool/arch/x86/decode.c | 6 +++---
tools/objtool/arch/x86/{insn => include/asm}/inat.h | 2 +-
.../arch/x86/{insn => include/asm}/inat_types.h | 0
tools/objtool/arch/x86/{insn => include/asm}/insn.h | 2 +-
tools/objtool/{ => arch/x86/include/asm}/orc_types.h | 0
tools/objtool/arch/x86/{insn => lib}/inat.c | 2 +-
tools/objtool/arch/x86/{insn => lib}/insn.c | 4 ++--
.../arch/x86/{insn => lib}/x86-opcode-map.txt | 0
.../arch/x86/{insn => tools}/gen-insn-attr-x86.awk | 0
tools/objtool/orc.h | 2 +-
13 files changed, 25 insertions(+), 25 deletions(-)
rename tools/objtool/arch/x86/{insn => include/asm}/inat.h (99%)
rename tools/objtool/arch/x86/{insn => include/asm}/inat_types.h (100%)
rename tools/objtool/arch/x86/{insn => include/asm}/insn.h (99%)
rename tools/objtool/{ => arch/x86/include/asm}/orc_types.h (100%)
rename tools/objtool/arch/x86/{insn => lib}/inat.c (99%)
rename tools/objtool/arch/x86/{insn => lib}/insn.c (99%)
rename tools/objtool/arch/x86/{insn => lib}/x86-opcode-map.txt (100%)
rename tools/objtool/arch/x86/{insn => tools}/gen-insn-attr-x86.awk (100%)
diff --git a/tools/objtool/.gitignore b/tools/objtool/.gitignore
index d3102c865a95..914cff12899b 100644
--- a/tools/objtool/.gitignore
+++ b/tools/objtool/.gitignore
@@ -1,3 +1,3 @@
-arch/x86/insn/inat-tables.c
+arch/x86/lib/inat-tables.c
objtool
fixdep
diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
index 424b1965d06f..7f4771ed0666 100644
--- a/tools/objtool/Makefile
+++ b/tools/objtool/Makefile
@@ -25,7 +25,9 @@ OBJTOOL_IN := $(OBJTOOL)-in.o
all: $(OBJTOOL)
-INCLUDES := -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi
+INCLUDES := -I$(srctree)/tools/include \
+ -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \
+ -I$(srctree)/tools/objtool/arch/$(HOSTARCH)/include
WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed
CFLAGS += -Wall -Werror $(WARNINGS) -fomit-frame-pointer -O2 -g $(INCLUDES)
LDFLAGS += -lelf $(LIBSUBCMD)
@@ -46,16 +48,16 @@ $(OBJTOOL_IN): fixdep FORCE
$(OBJTOOL): $(LIBSUBCMD) $(OBJTOOL_IN)
@(diff -I 2>&1 | grep -q 'option requires an argument' && \
test -d ../../kernel -a -d ../../tools -a -d ../objtool && (( \
- diff -I'^#include' arch/x86/insn/insn.c ../../arch/x86/lib/insn.c >/dev/null && \
- diff -I'^#include' arch/x86/insn/inat.c ../../arch/x86/lib/inat.c >/dev/null && \
- diff arch/x86/insn/x86-opcode-map.txt ../../arch/x86/lib/x86-opcode-map.txt >/dev/null && \
- diff arch/x86/insn/gen-insn-attr-x86.awk ../../arch/x86/tools/gen-insn-attr-x86.awk >/dev/null && \
- diff -I'^#include' arch/x86/insn/insn.h ../../arch/x86/include/asm/insn.h >/dev/null && \
- diff -I'^#include' arch/x86/insn/inat.h ../../arch/x86/include/asm/inat.h >/dev/null && \
- diff -I'^#include' arch/x86/insn/inat_types.h ../../arch/x86/include/asm/inat_types.h >/dev/null) \
+ diff arch/x86/lib/insn.c ../../arch/x86/lib/insn.c >/dev/null && \
+ diff arch/x86/lib/inat.c ../../arch/x86/lib/inat.c >/dev/null && \
+ diff arch/x86/lib/x86-opcode-map.txt ../../arch/x86/lib/x86-opcode-map.txt >/dev/null && \
+ diff arch/x86/tools/gen-insn-attr-x86.awk ../../arch/x86/tools/gen-insn-attr-x86.awk >/dev/null && \
+ diff arch/x86/include/asm/insn.h ../../arch/x86/include/asm/insn.h >/dev/null && \
+ diff arch/x86/include/asm/inat.h ../../arch/x86/include/asm/inat.h >/dev/null && \
+ diff arch/x86/include/asm/inat_types.h ../../arch/x86/include/asm/inat_types.h >/dev/null) \
|| echo "warning: objtool: x86 instruction decoder differs from kernel" >&2 )) || true
@(test -d ../../kernel -a -d ../../tools -a -d ../objtool && (( \
- diff ../../arch/x86/include/asm/orc_types.h orc_types.h >/dev/null) \
+ diff ../../arch/x86/include/asm/orc_types.h arch/x86/include/asm/orc_types.h >/dev/null) \
|| echo "warning: objtool: orc_types.h differs from kernel" >&2 )) || true
$(QUIET_LINK)$(CC) $(OBJTOOL_IN) $(LDFLAGS) -o $@
diff --git a/tools/objtool/arch/x86/Build b/tools/objtool/arch/x86/Build
index debbdb0b5c43..dddadc7948f7 100644
--- a/tools/objtool/arch/x86/Build
+++ b/tools/objtool/arch/x86/Build
@@ -1,12 +1,10 @@
objtool-y += decode.o
-inat_tables_script = arch/x86/insn/gen-insn-attr-x86.awk
-inat_tables_maps = arch/x86/insn/x86-opcode-map.txt
+inat_tables_script = arch/x86/tools/gen-insn-attr-x86.awk
+inat_tables_maps = arch/x86/lib/x86-opcode-map.txt
-$(OUTPUT)arch/x86/insn/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
+$(OUTPUT)arch/x86/lib/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
$(call rule_mkdir)
$(Q)$(call echo-cmd,gen)$(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@
-$(OUTPUT)arch/x86/decode.o: $(OUTPUT)arch/x86/insn/inat-tables.c
-
-CFLAGS_decode.o += -I$(OUTPUT)arch/x86/insn
+$(OUTPUT)arch/x86/decode.o: $(OUTPUT)arch/x86/lib/inat-tables.c
diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c
index 34a579f806e3..8acfc47af70e 100644
--- a/tools/objtool/arch/x86/decode.c
+++ b/tools/objtool/arch/x86/decode.c
@@ -19,9 +19,9 @@
#include <stdlib.h>
#define unlikely(cond) (cond)
-#include "insn/insn.h"
-#include "insn/inat.c"
-#include "insn/insn.c"
+#include <asm/insn.h>
+#include "lib/inat.c"
+#include "lib/insn.c"
#include "../../elf.h"
#include "../../arch.h"
diff --git a/tools/objtool/arch/x86/insn/inat.h b/tools/objtool/arch/x86/include/asm/inat.h
similarity index 99%
rename from tools/objtool/arch/x86/insn/inat.h
rename to tools/objtool/arch/x86/include/asm/inat.h
index 125ecd2a300d..02aff0867211 100644
--- a/tools/objtool/arch/x86/insn/inat.h
+++ b/tools/objtool/arch/x86/include/asm/inat.h
@@ -20,7 +20,7 @@
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*
*/
-#include "inat_types.h"
+#include <asm/inat_types.h>
/*
* Internal bits. Don't use bitmasks directly, because these bits are
diff --git a/tools/objtool/arch/x86/insn/inat_types.h b/tools/objtool/arch/x86/include/asm/inat_types.h
similarity index 100%
rename from tools/objtool/arch/x86/insn/inat_types.h
rename to tools/objtool/arch/x86/include/asm/inat_types.h
diff --git a/tools/objtool/arch/x86/insn/insn.h b/tools/objtool/arch/x86/include/asm/insn.h
similarity index 99%
rename from tools/objtool/arch/x86/insn/insn.h
rename to tools/objtool/arch/x86/include/asm/insn.h
index e23578c7b1be..b3e32b010ab1 100644
--- a/tools/objtool/arch/x86/insn/insn.h
+++ b/tools/objtool/arch/x86/include/asm/insn.h
@@ -21,7 +21,7 @@
*/
/* insn_attr_t is defined in inat.h */
-#include "inat.h"
+#include <asm/inat.h>
struct insn_field {
union {
diff --git a/tools/objtool/orc_types.h b/tools/objtool/arch/x86/include/asm/orc_types.h
similarity index 100%
rename from tools/objtool/orc_types.h
rename to tools/objtool/arch/x86/include/asm/orc_types.h
diff --git a/tools/objtool/arch/x86/insn/inat.c b/tools/objtool/arch/x86/lib/inat.c
similarity index 99%
rename from tools/objtool/arch/x86/insn/inat.c
rename to tools/objtool/arch/x86/lib/inat.c
index e4bf28e6f4c7..c1f01a8e9f65 100644
--- a/tools/objtool/arch/x86/insn/inat.c
+++ b/tools/objtool/arch/x86/lib/inat.c
@@ -18,7 +18,7 @@
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*
*/
-#include "insn.h"
+#include <asm/insn.h>
/* Attribute tables are generated from opcode map */
#include "inat-tables.c"
diff --git a/tools/objtool/arch/x86/insn/insn.c b/tools/objtool/arch/x86/lib/insn.c
similarity index 99%
rename from tools/objtool/arch/x86/insn/insn.c
rename to tools/objtool/arch/x86/lib/insn.c
index ca983e2bea8b..1088eb8f3a5f 100644
--- a/tools/objtool/arch/x86/insn/insn.c
+++ b/tools/objtool/arch/x86/lib/insn.c
@@ -23,8 +23,8 @@
#else
#include <string.h>
#endif
-#include "inat.h"
-#include "insn.h"
+#include <asm/inat.h>
+#include <asm/insn.h>
/* Verify next sizeof(t) bytes can be on the same instruction */
#define validate_next(t, insn, n) \
diff --git a/tools/objtool/arch/x86/insn/x86-opcode-map.txt b/tools/objtool/arch/x86/lib/x86-opcode-map.txt
similarity index 100%
rename from tools/objtool/arch/x86/insn/x86-opcode-map.txt
rename to tools/objtool/arch/x86/lib/x86-opcode-map.txt
diff --git a/tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk b/tools/objtool/arch/x86/tools/gen-insn-attr-x86.awk
similarity index 100%
rename from tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk
rename to tools/objtool/arch/x86/tools/gen-insn-attr-x86.awk
diff --git a/tools/objtool/orc.h b/tools/objtool/orc.h
index a4139e386ef3..b0e92a6d0903 100644
--- a/tools/objtool/orc.h
+++ b/tools/objtool/orc.h
@@ -18,7 +18,7 @@
#ifndef _ORC_H
#define _ORC_H
-#include "orc_types.h"
+#include <asm/orc_types.h>
struct objtool_file;
--
2.13.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] objtool: Move sync check to a script
2017-11-03 14:31 [PATCH 0/3] objtool: sync warning fix and cleanups Josh Poimboeuf
2017-11-03 14:31 ` [PATCH 1/3] objtool: Resync objtool's instruction decoder with the kernel's Josh Poimboeuf
2017-11-03 14:31 ` [PATCH 2/3] objtool: Move synced files to their original relative locations Josh Poimboeuf
@ 2017-11-03 14:31 ` Josh Poimboeuf
2017-11-03 18:54 ` [PATCH 0/3] objtool: sync warning fix and cleanups Josh Poimboeuf
3 siblings, 0 replies; 7+ messages in thread
From: Josh Poimboeuf @ 2017-11-03 14:31 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Stephen Rothwell
Replace the nasty diff checks in the objtool Makefile with a clean bash
script, and make the warnings more specific.
Heavily inspired by tools/perf/check-headers.sh.
Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
tools/objtool/Makefile | 16 +---------------
tools/objtool/sync-check.sh | 29 +++++++++++++++++++++++++++++
2 files changed, 30 insertions(+), 15 deletions(-)
create mode 100755 tools/objtool/sync-check.sh
diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
index 7f4771ed0666..1cde71c231d5 100644
--- a/tools/objtool/Makefile
+++ b/tools/objtool/Makefile
@@ -43,22 +43,8 @@ include $(srctree)/tools/build/Makefile.include
$(OBJTOOL_IN): fixdep FORCE
@$(MAKE) $(build)=objtool
-# Busybox's diff doesn't have -I, avoid warning in that case
-#
$(OBJTOOL): $(LIBSUBCMD) $(OBJTOOL_IN)
- @(diff -I 2>&1 | grep -q 'option requires an argument' && \
- test -d ../../kernel -a -d ../../tools -a -d ../objtool && (( \
- diff arch/x86/lib/insn.c ../../arch/x86/lib/insn.c >/dev/null && \
- diff arch/x86/lib/inat.c ../../arch/x86/lib/inat.c >/dev/null && \
- diff arch/x86/lib/x86-opcode-map.txt ../../arch/x86/lib/x86-opcode-map.txt >/dev/null && \
- diff arch/x86/tools/gen-insn-attr-x86.awk ../../arch/x86/tools/gen-insn-attr-x86.awk >/dev/null && \
- diff arch/x86/include/asm/insn.h ../../arch/x86/include/asm/insn.h >/dev/null && \
- diff arch/x86/include/asm/inat.h ../../arch/x86/include/asm/inat.h >/dev/null && \
- diff arch/x86/include/asm/inat_types.h ../../arch/x86/include/asm/inat_types.h >/dev/null) \
- || echo "warning: objtool: x86 instruction decoder differs from kernel" >&2 )) || true
- @(test -d ../../kernel -a -d ../../tools -a -d ../objtool && (( \
- diff ../../arch/x86/include/asm/orc_types.h arch/x86/include/asm/orc_types.h >/dev/null) \
- || echo "warning: objtool: orc_types.h differs from kernel" >&2 )) || true
+ @./sync-check.sh
$(QUIET_LINK)$(CC) $(OBJTOOL_IN) $(LDFLAGS) -o $@
diff --git a/tools/objtool/sync-check.sh b/tools/objtool/sync-check.sh
new file mode 100755
index 000000000000..f2e5f8b0460c
--- /dev/null
+++ b/tools/objtool/sync-check.sh
@@ -0,0 +1,29 @@
+#!/bin/sh
+# SPDX-License-Identifier: GPL-2.0
+
+FILES='
+arch/x86/lib/insn.c
+arch/x86/lib/inat.c
+arch/x86/lib/x86-opcode-map.txt
+arch/x86/tools/gen-insn-attr-x86.awk
+arch/x86/include/asm/insn.h
+arch/x86/include/asm/inat.h
+arch/x86/include/asm/inat_types.h
+arch/x86/include/asm/orc_types.h
+'
+
+check()
+{
+ local file=$1
+
+ diff $file ../../$file &> /dev/null ||
+ echo "Warning: synced file at 'tools/objtool/$file' differs from latest kernel version at '$file'"
+}
+
+if [ ! -d ../../kernel ] || [ ! -d ../../tools ] || [ ! -d ../objtool ]; then
+ exit 0
+fi
+
+for i in $FILES; do
+ check $i
+done
--
2.13.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] objtool: sync warning fix and cleanups
2017-11-03 14:31 [PATCH 0/3] objtool: sync warning fix and cleanups Josh Poimboeuf
` (2 preceding siblings ...)
2017-11-03 14:31 ` [PATCH 3/3] objtool: Move sync check to a script Josh Poimboeuf
@ 2017-11-03 18:54 ` Josh Poimboeuf
2017-11-04 7:54 ` Ingo Molnar
3 siblings, 1 reply; 7+ messages in thread
From: Josh Poimboeuf @ 2017-11-03 18:54 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Stephen Rothwell
On Fri, Nov 03, 2017 at 09:31:42AM -0500, Josh Poimboeuf wrote:
> Patch 1 fixes the "x86 instruction decoder differs from kernel" warning.
>
> Patches 2-3 improve the sync checking so that future warnings will be
> more useful.
Hm, patch 2 seems to be causing a 0-day bot error which I need to look
into.
However the real fix is in patch 1, it can be taken immediately.
--
Josh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] objtool: sync warning fix and cleanups
2017-11-03 18:54 ` [PATCH 0/3] objtool: sync warning fix and cleanups Josh Poimboeuf
@ 2017-11-04 7:54 ` Ingo Molnar
0 siblings, 0 replies; 7+ messages in thread
From: Ingo Molnar @ 2017-11-04 7:54 UTC (permalink / raw)
To: Josh Poimboeuf; +Cc: linux-kernel, Stephen Rothwell
* Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Fri, Nov 03, 2017 at 09:31:42AM -0500, Josh Poimboeuf wrote:
> > Patch 1 fixes the "x86 instruction decoder differs from kernel" warning.
> >
> > Patches 2-3 improve the sync checking so that future warnings will be
> > more useful.
>
> Hm, patch 2 seems to be causing a 0-day bot error which I need to look
> into.
>
> However the real fix is in patch 1, it can be taken immediately.
Ok, picked up #1 and will wait for v2 of the other two patches.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:core/urgent] objtool: Resync objtool's instruction decoder source code copy with the kernel's latest version
2017-11-03 14:31 ` [PATCH 1/3] objtool: Resync objtool's instruction decoder with the kernel's Josh Poimboeuf
@ 2017-11-04 8:31 ` tip-bot for Josh Poimboeuf
0 siblings, 0 replies; 7+ messages in thread
From: tip-bot for Josh Poimboeuf @ 2017-11-04 8:31 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, sfr, hpa, tglx, jpoimboe, torvalds, linux-kernel, mingo
Commit-ID: da0db32bbe816085d7f7f9cebfc825e55eff811f
Gitweb: https://git.kernel.org/tip/da0db32bbe816085d7f7f9cebfc825e55eff811f
Author: Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Fri, 3 Nov 2017 09:31:43 -0500
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 4 Nov 2017 08:54:06 +0100
objtool: Resync objtool's instruction decoder source code copy with the kernel's latest version
This fixes the following warning:
warning: objtool: x86 instruction decoder differs from kernel
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/013315a808ccf5580abc293808827c8e2b5e1354.1509719152.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk b/tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk
index a3d2c62..b02a36b 100644
--- a/tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk
+++ b/tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk
@@ -1,4 +1,5 @@
#!/bin/awk -f
+# SPDX-License-Identifier: GPL-2.0
# gen-insn-attr-x86.awk: Instruction attribute table generator
# Written by Masami Hiramatsu <mhiramat@redhat.com>
#
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-11-04 8:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 14:31 [PATCH 0/3] objtool: sync warning fix and cleanups Josh Poimboeuf
2017-11-03 14:31 ` [PATCH 1/3] objtool: Resync objtool's instruction decoder with the kernel's Josh Poimboeuf
2017-11-04 8:31 ` [tip:core/urgent] objtool: Resync objtool's instruction decoder source code copy with the kernel's latest version tip-bot for Josh Poimboeuf
2017-11-03 14:31 ` [PATCH 2/3] objtool: Move synced files to their original relative locations Josh Poimboeuf
2017-11-03 14:31 ` [PATCH 3/3] objtool: Move sync check to a script Josh Poimboeuf
2017-11-03 18:54 ` [PATCH 0/3] objtool: sync warning fix and cleanups Josh Poimboeuf
2017-11-04 7:54 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.