* [Qemu-devel] [PATCH] Ignore sgabios rom in case sercon is enabled.
@ 2017-11-03 7:57 Gerd Hoffmann
2017-11-04 10:09 ` [Qemu-devel] [SeaBIOS] " Peter Stuge
0 siblings, 1 reply; 3+ messages in thread
From: Gerd Hoffmann @ 2017-11-03 7:57 UTC (permalink / raw)
To: seabios; +Cc: qemu-devel, Paolo Bonzini, Daniel P. Berrange, Gerd Hoffmann
We don't want them both be active.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
src/optionroms.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/optionroms.c b/src/optionroms.c
index 092393a56c..a5ecd4cd11 100644
--- a/src/optionroms.c
+++ b/src/optionroms.c
@@ -193,6 +193,11 @@ run_file_roms(const char *prefix, int isvga, u64 *sources)
file = romfile_findprefix(prefix, file);
if (!file)
break;
+ if (strcmp(file->name, "vgaroms/sgabios.bin") == 0 &&
+ CONFIG_SERCON && romfile_loadint("etc/sercon-port", 0)) {
+ dprintf(1, "sercon: is enabled, not loading sgabios rom.\n");
+ continue;
+ }
struct rom_header *rom = deploy_romfile(file);
if (rom) {
setRomSource(sources, rom, (u32)file);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [SeaBIOS] [PATCH] Ignore sgabios rom in case sercon is enabled.
2017-11-03 7:57 [Qemu-devel] [PATCH] Ignore sgabios rom in case sercon is enabled Gerd Hoffmann
@ 2017-11-04 10:09 ` Peter Stuge
2017-11-04 16:55 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Peter Stuge @ 2017-11-04 10:09 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: seabios, Paolo Bonzini, Daniel P. Berrange, qemu-devel
Gerd Hoffmann wrote:
> +++ b/src/optionroms.c
> @@ -193,6 +193,11 @@ run_file_roms(const char *prefix, int isvga, u64 *sources)
> file = romfile_findprefix(prefix, file);
> if (!file)
> break;
> + if (strcmp(file->name, "vgaroms/sgabios.bin") == 0 &&
> + CONFIG_SERCON && romfile_loadint("etc/sercon-port", 0)) {
> + dprintf(1, "sercon: is enabled, not loading sgabios rom.\n");
> + continue;
> + }
This heuristic isn't very reliable. Is there nothing in the sgabios.bin
option ROM itself that can be used instead?
//Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [SeaBIOS] [PATCH] Ignore sgabios rom in case sercon is enabled.
2017-11-04 10:09 ` [Qemu-devel] [SeaBIOS] " Peter Stuge
@ 2017-11-04 16:55 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2017-11-04 16:55 UTC (permalink / raw)
To: Peter Stuge, Gerd Hoffmann; +Cc: seabios, Daniel P. Berrange, qemu-devel
On 04/11/2017 11:09, Peter Stuge wrote:
>> + if (strcmp(file->name, "vgaroms/sgabios.bin") == 0 &&
>> + CONFIG_SERCON && romfile_loadint("etc/sercon-port", 0)) {
>> + dprintf(1, "sercon: is enabled, not loading sgabios rom.\n");
>> + continue;
>> + }
> This heuristic isn't very reliable. Is there nothing in the sgabios.bin
> option ROM itself that can be used instead?
In what sense it is not very reliable?
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-04 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 7:57 [Qemu-devel] [PATCH] Ignore sgabios rom in case sercon is enabled Gerd Hoffmann
2017-11-04 10:09 ` [Qemu-devel] [SeaBIOS] " Peter Stuge
2017-11-04 16:55 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.