All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Oleksandr Shamray <oleksandrs@mellanox.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	openbmc@lists.ozlabs.org, joel@jms.id.au, jiri@resnulli.us,
	tklauser@distanz.ch, linux-serial@vger.kernel.org, mec@shout.net,
	vadimp@mellanox.com, system-sw-low-level@mellanox.com,
	robh+dt@kernel.org, openocd-devel-owner@lists.sourceforge.net,
	linux-api@vger.kernel.org, davem@davemloft.net,
	mchehab@kernel.org, Jiri Pirko <jiri@mellanox.com>
Subject: Re: [patch v11 1/4] drivers: jtag: Add JTAG core driver
Date: Sat, 4 Nov 2017 12:36:32 +0100	[thread overview]
Message-ID: <20171104113632.GC24583@kroah.com> (raw)
In-Reply-To: <1509724449-26221-2-git-send-email-oleksandrs@mellanox.com>

On Fri, Nov 03, 2017 at 05:54:06PM +0200, Oleksandr Shamray wrote:
> diff --git a/include/uapi/linux/jtag.h b/include/uapi/linux/jtag.h
> new file mode 100644
> index 0000000..0b25a83
> --- /dev/null
> +++ b/include/uapi/linux/jtag.h
> @@ -0,0 +1,117 @@
> +/*
> + * JTAG class driver
> + *
> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved.
> + * Copyright (c) 2017 Oleksandr Shamray <oleksandrs@mellanox.com>
> + *
> + * Released under the GPLv2/BSD.
> + * SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause

Minor nit, this should go on the first line of the .h file now, to match
the rest of the kernel (just happened, not your fault.)

Also, uapi files are not just GPLv2, they have the userspace exception,
so this should just be:
	SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
no need to add any BSD stuff to it at all.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Oleksandr Shamray <oleksandrs-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: arnd-r2nGTMty4D4@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org,
	jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org,
	tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org,
	linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mec-WqBc5aa1uDFeoWH0uzbU5w@public.gmane.org,
	vadimp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	system-sw-low-level-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	openocd-devel-owner-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	Jiri Pirko <jiri-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [patch v11 1/4] drivers: jtag: Add JTAG core driver
Date: Sat, 4 Nov 2017 12:36:32 +0100	[thread overview]
Message-ID: <20171104113632.GC24583@kroah.com> (raw)
In-Reply-To: <1509724449-26221-2-git-send-email-oleksandrs-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

On Fri, Nov 03, 2017 at 05:54:06PM +0200, Oleksandr Shamray wrote:
> diff --git a/include/uapi/linux/jtag.h b/include/uapi/linux/jtag.h
> new file mode 100644
> index 0000000..0b25a83
> --- /dev/null
> +++ b/include/uapi/linux/jtag.h
> @@ -0,0 +1,117 @@
> +/*
> + * JTAG class driver
> + *
> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved.
> + * Copyright (c) 2017 Oleksandr Shamray <oleksandrs-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> + *
> + * Released under the GPLv2/BSD.
> + * SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause

Minor nit, this should go on the first line of the .h file now, to match
the rest of the kernel (just happened, not your fault.)

Also, uapi files are not just GPLv2, they have the userspace exception,
so this should just be:
	SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
no need to add any BSD stuff to it at all.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch v11 1/4] drivers: jtag: Add JTAG core driver
Date: Sat, 4 Nov 2017 12:36:32 +0100	[thread overview]
Message-ID: <20171104113632.GC24583@kroah.com> (raw)
In-Reply-To: <1509724449-26221-2-git-send-email-oleksandrs@mellanox.com>

On Fri, Nov 03, 2017 at 05:54:06PM +0200, Oleksandr Shamray wrote:
> diff --git a/include/uapi/linux/jtag.h b/include/uapi/linux/jtag.h
> new file mode 100644
> index 0000000..0b25a83
> --- /dev/null
> +++ b/include/uapi/linux/jtag.h
> @@ -0,0 +1,117 @@
> +/*
> + * JTAG class driver
> + *
> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved.
> + * Copyright (c) 2017 Oleksandr Shamray <oleksandrs@mellanox.com>
> + *
> + * Released under the GPLv2/BSD.
> + * SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause

Minor nit, this should go on the first line of the .h file now, to match
the rest of the kernel (just happened, not your fault.)

Also, uapi files are not just GPLv2, they have the userspace exception,
so this should just be:
	SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
no need to add any BSD stuff to it at all.

thanks,

greg k-h

  reply	other threads:[~2017-11-04 11:36 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 15:54 [patch v11 0/4] JTAG driver introduction Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
2017-11-03 15:54 ` [patch v11 1/4] drivers: jtag: Add JTAG core driver Oleksandr Shamray
2017-11-03 15:54   ` Oleksandr Shamray
2017-11-03 15:54   ` Oleksandr Shamray
2017-11-04 11:36   ` Greg KH [this message]
2017-11-04 11:36     ` Greg KH
2017-11-04 11:36     ` Greg KH
2017-11-05 22:32   ` [v11,1/4] " Chip Bilbrey
2017-11-05 22:32     ` Chip Bilbrey
2017-11-05 22:32     ` Chip Bilbrey
2017-11-06 14:28     ` Oleksandr Shamray
2017-11-06 14:28       ` Oleksandr Shamray
2017-11-06 14:28       ` Oleksandr Shamray
2017-11-06 14:28       ` Oleksandr Shamray
2017-11-14 10:34     ` Oleksandr Shamray
2017-11-14 10:34       ` Oleksandr Shamray
2017-11-14 10:34       ` Oleksandr Shamray
2017-11-14 10:34       ` Oleksandr Shamray
2017-11-14 11:10       ` gregkh
2017-11-14 11:10         ` gregkh at linuxfoundation.org
2017-11-14 11:10         ` gregkh
2017-11-14 11:10         ` gregkh
2017-11-14 11:19         ` Russell King - ARM Linux
2017-11-14 11:19           ` Russell King - ARM Linux
2017-11-14 11:19           ` Russell King - ARM Linux
2017-11-14 11:19           ` Russell King - ARM Linux
2017-11-14 11:31           ` gregkh
2017-11-14 11:31             ` gregkh at linuxfoundation.org
2017-11-14 11:31             ` gregkh
2017-11-14 11:31             ` gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r
2017-11-03 15:54 ` [patch v11 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver Oleksandr Shamray
2017-11-03 15:54   ` Oleksandr Shamray
2017-11-03 15:54 ` [patch v11 3/4] Documentation: jtag: Add bindings for " Oleksandr Shamray
2017-11-03 15:54   ` Oleksandr Shamray
2017-11-03 15:54   ` Oleksandr Shamray
2017-11-03 15:54 ` [patch v11 4/4] Documentation: jtag: Add ABI documentation Oleksandr Shamray
2017-11-03 15:54   ` Oleksandr Shamray
2017-11-03 15:54   ` Oleksandr Shamray
2017-11-07 10:36   ` Tobias Klauser
2017-11-07 10:36     ` Tobias Klauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171104113632.GC24583@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jiri@mellanox.com \
    --cc=jiri@resnulli.us \
    --cc=joel@jms.id.au \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mec@shout.net \
    --cc=oleksandrs@mellanox.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=openocd-devel-owner@lists.sourceforge.net \
    --cc=robh+dt@kernel.org \
    --cc=system-sw-low-level@mellanox.com \
    --cc=tklauser@distanz.ch \
    --cc=vadimp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.