All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Mahesh Bandewar <mahesh@bandewar.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Netdev <netdev@vger.kernel.org>,
	Kernel-hardening <kernel-hardening@lists.openwall.com>,
	Linux API <linux-api@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Serge Hallyn <serge@hallyn.com>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Eric Dumazet <edumazet@google.com>,
	David Miller <davem@davemloft.net>,
	Mahesh Bandewar <maheshb@google.com>
Subject: Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces
Date: Sat, 4 Nov 2017 18:53:46 -0500	[thread overview]
Message-ID: <20171104235346.GA17170@mail.hallyn.com> (raw)
In-Reply-To: <20171103004436.40026-1-mahesh@bandewar.net>

Quoting Mahesh Bandewar (mahesh@bandewar.net):
> Init-user-ns is always uncontrolled and a process that has SYS_ADMIN
> that belongs to uncontrolled user-ns can create another (child) user-
> namespace that is uncontrolled. Any other process (that either does
> not have SYS_ADMIN or belongs to a controlled user-ns) can only
> create a user-ns that is controlled.

That's a huge change though.  It means that any system that previously
used unprivileged containers will need new privileged code (which always
risks more privilege leaks through the new code) to re-enable what was
possible without privilege before.  That's a regression.

I'm very much interested in what you want to do,  But it seems like
it would be worth starting with some automated code analysis that shows
exactly what code becomes accessible to unprivileged users with user
namespaces which was accessible to unprivileged users before.  Then we
can reason about classifying that code and perhaps limiting access to
some of it.

WARNING: multiple messages have this Message-ID (diff)
From: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
To: Mahesh Bandewar <mahesh-bmGAjcP2qsnk1uMJSBkQmQ@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Kernel-hardening
	<kernel-hardening-ZwoEplunGu1jrUoiu81ncdBPR1lH4CV8@public.gmane.org>,
	Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Serge Hallyn <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>,
	"Eric W . Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	Eric Dumazet <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	Mahesh Bandewar <maheshb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces
Date: Sat, 4 Nov 2017 18:53:46 -0500	[thread overview]
Message-ID: <20171104235346.GA17170@mail.hallyn.com> (raw)
In-Reply-To: <20171103004436.40026-1-mahesh-bmGAjcP2qsnk1uMJSBkQmQ@public.gmane.org>

Quoting Mahesh Bandewar (mahesh-bmGAjcP2qsnk1uMJSBkQmQ@public.gmane.org):
> Init-user-ns is always uncontrolled and a process that has SYS_ADMIN
> that belongs to uncontrolled user-ns can create another (child) user-
> namespace that is uncontrolled. Any other process (that either does
> not have SYS_ADMIN or belongs to a controlled user-ns) can only
> create a user-ns that is controlled.

That's a huge change though.  It means that any system that previously
used unprivileged containers will need new privileged code (which always
risks more privilege leaks through the new code) to re-enable what was
possible without privilege before.  That's a regression.

I'm very much interested in what you want to do,  But it seems like
it would be worth starting with some automated code analysis that shows
exactly what code becomes accessible to unprivileged users with user
namespaces which was accessible to unprivileged users before.  Then we
can reason about classifying that code and perhaps limiting access to
some of it.

WARNING: multiple messages have this Message-ID (diff)
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Mahesh Bandewar <mahesh@bandewar.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Netdev <netdev@vger.kernel.org>,
	Kernel-hardening <kernel-hardening@lists.openwall.com>,
	Linux API <linux-api@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Serge Hallyn <serge@hallyn.com>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Eric Dumazet <edumazet@google.com>,
	David Miller <davem@davemloft.net>,
	Mahesh Bandewar <maheshb@google.com>
Subject: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces
Date: Sat, 4 Nov 2017 18:53:46 -0500	[thread overview]
Message-ID: <20171104235346.GA17170@mail.hallyn.com> (raw)
In-Reply-To: <20171103004436.40026-1-mahesh@bandewar.net>

Quoting Mahesh Bandewar (mahesh@bandewar.net):
> Init-user-ns is always uncontrolled and a process that has SYS_ADMIN
> that belongs to uncontrolled user-ns can create another (child) user-
> namespace that is uncontrolled. Any other process (that either does
> not have SYS_ADMIN or belongs to a controlled user-ns) can only
> create a user-ns that is controlled.

That's a huge change though.  It means that any system that previously
used unprivileged containers will need new privileged code (which always
risks more privilege leaks through the new code) to re-enable what was
possible without privilege before.  That's a regression.

I'm very much interested in what you want to do,  But it seems like
it would be worth starting with some automated code analysis that shows
exactly what code becomes accessible to unprivileged users with user
namespaces which was accessible to unprivileged users before.  Then we
can reason about classifying that code and perhaps limiting access to
some of it.

  reply	other threads:[~2017-11-04 23:53 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03  0:44 [PATCH resend 2/2] userns: control capabilities of some user namespaces Mahesh Bandewar
2017-11-03  0:44 ` [kernel-hardening] " Mahesh Bandewar
2017-11-04 23:53 ` Serge E. Hallyn [this message]
2017-11-04 23:53   ` [kernel-hardening] " Serge E. Hallyn
2017-11-04 23:53   ` Serge E. Hallyn
2017-11-06  7:23   ` Mahesh Bandewar (महेश बंडेवार)
2017-11-06  7:23     ` [kernel-hardening] " Mahesh Bandewar (महेश बंडेवार)
2017-11-06  7:23     ` Mahesh Bandewar (महेश बंडेवार)
2017-11-06 15:03     ` Serge E. Hallyn
2017-11-06 15:03       ` [kernel-hardening] " Serge E. Hallyn
2017-11-06 21:33       ` Daniel Micay
2017-11-06 21:33         ` Daniel Micay
2017-11-06 22:14         ` Serge E. Hallyn
2017-11-06 22:14           ` Serge E. Hallyn
2017-11-06 22:42           ` Christian Brauner
2017-11-06 22:42             ` Christian Brauner
2017-11-06 23:17           ` Boris Lukashev
2017-11-06 23:39             ` Serge E. Hallyn
2017-11-07  0:01               ` Boris Lukashev
2017-11-07  0:01                 ` Boris Lukashev
2017-11-07  3:28                 ` [kernel-hardening] " Serge E. Hallyn
2017-11-07  3:28                   ` Serge E. Hallyn
2017-11-08 11:09                   ` Mahesh Bandewar (महेश बंडेवार)
2017-11-08 11:09                     ` Mahesh Bandewar (महेश बंडेवार)
2017-11-08 19:02                     ` Christian Brauner
2017-11-09  0:55                       ` Mahesh Bandewar (महेश बंडेवार)
2017-11-09  0:55                         ` Mahesh Bandewar (महेश बंडेवार)
2017-11-09  3:21                         ` Serge E. Hallyn
2017-11-09  3:21                           ` Serge E. Hallyn
2017-11-09  7:13                           ` Mahesh Bandewar (महेश बंडेवार)
2017-11-09  7:13                             ` [kernel-hardening] " Mahesh Bandewar (महेश बंडेवार)
2017-11-09  7:18                           ` Mahesh Bandewar (महेश बंडेवार)
2017-11-09  7:18                             ` Mahesh Bandewar (महेश बंडेवार)
2017-11-09 16:14                             ` [kernel-hardening] " Serge E. Hallyn
2017-11-09 16:14                               ` Serge E. Hallyn
2017-11-09 21:58                             ` [kernel-hardening] " Eric W. Biederman
2017-11-09 21:58                               ` Eric W. Biederman
2017-11-10  4:30                               ` Mahesh Bandewar (महेश बंडेवार)
2017-11-10  4:30                                 ` Mahesh Bandewar (महेश बंडेवार)
2017-11-10  4:46                               ` Serge E. Hallyn
2017-11-10  4:46                                 ` Serge E. Hallyn
2017-11-10  5:28                                 ` Mahesh Bandewar (महेश बंडेवार)
2017-11-10  5:28                                   ` Mahesh Bandewar (महेश बंडेवार)
2017-11-07  2:16           ` Daniel Micay
2017-11-07  2:16             ` Daniel Micay
2017-11-07  3:23             ` Serge E. Hallyn
2017-11-07  3:23               ` Serge E. Hallyn
2017-11-09 18:01               ` chris hyser
2017-11-09 18:05                 ` Serge E. Hallyn
2017-11-09 18:05                   ` Serge E. Hallyn
2017-11-09 18:27                   ` chris hyser
2017-11-09 17:25 ` Serge E. Hallyn
2017-11-09 17:25   ` [kernel-hardening] " Serge E. Hallyn
2017-11-10  1:49   ` Mahesh Bandewar (महेश बंडेवार)
2017-11-10  1:49     ` [kernel-hardening] " Mahesh Bandewar (महेश बंडेवार)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171104235346.GA17170@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=edumazet@google.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mahesh@bandewar.net \
    --cc=maheshb@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.