All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] mesa3d: fix build with BR2_SHARED_STATIC_LIBS
@ 2017-11-05 10:49 Fabrice Fontaine
  2017-11-11 22:40 ` Thomas Petazzoni
  2017-11-26 21:29 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2017-11-05 10:49 UTC (permalink / raw)
  To: buildroot

mesa3d does not allow to enable both static and shared libraries so if
BR2_SHARED_STATIC_LIBS is set, disable static

Fixes https://bugs.busybox.net/show_bug.cgi?id=10326

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/mesa3d/mesa3d.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index 9305523bd..5627344f0 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -26,6 +26,12 @@ MESA3D_DEPENDENCIES = \
 # Disable assembly usage.
 MESA3D_CONF_OPTS = --disable-asm
 
+# Disable static, otherwise configure will fail with: "Cannot enable both static
+# and shared."
+ifeq ($(BR2_SHARED_STATIC_LIBS),y)
+MESA3D_CONF_OPTS += --disable-static
+endif
+
 # The Sourcery MIPS toolchain has a special (non-upstream) feature to
 # have "compact exception handling", which unfortunately breaks with
 # mesa3d, so we disable it here by passing -mno-compact-eh.
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] mesa3d: fix build with BR2_SHARED_STATIC_LIBS
  2017-11-05 10:49 [Buildroot] [PATCH 1/1] mesa3d: fix build with BR2_SHARED_STATIC_LIBS Fabrice Fontaine
@ 2017-11-11 22:40 ` Thomas Petazzoni
  2017-11-26 21:29 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-11-11 22:40 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun,  5 Nov 2017 11:49:58 +0100, Fabrice Fontaine wrote:
> mesa3d does not allow to enable both static and shared libraries so if
> BR2_SHARED_STATIC_LIBS is set, disable static
> 
> Fixes https://bugs.busybox.net/show_bug.cgi?id=10326
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/mesa3d/mesa3d.mk | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] mesa3d: fix build with BR2_SHARED_STATIC_LIBS
  2017-11-05 10:49 [Buildroot] [PATCH 1/1] mesa3d: fix build with BR2_SHARED_STATIC_LIBS Fabrice Fontaine
  2017-11-11 22:40 ` Thomas Petazzoni
@ 2017-11-26 21:29 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-11-26 21:29 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > mesa3d does not allow to enable both static and shared libraries so if
 > BR2_SHARED_STATIC_LIBS is set, disable static

 > Fixes https://bugs.busybox.net/show_bug.cgi?id=10326

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2017.02.x and 2017.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-26 21:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-05 10:49 [Buildroot] [PATCH 1/1] mesa3d: fix build with BR2_SHARED_STATIC_LIBS Fabrice Fontaine
2017-11-11 22:40 ` Thomas Petazzoni
2017-11-26 21:29 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.