[RESEND PATCH] kernel: fitimage: deploy real fit-image

[RESEND PATCH] kernel: fitimage: deploy real fit-image

[Gaël PORTAY]

Currently, do_deploy installs a standard kernel image as an ITB. This
image is linux.bin and it is prepared by uboot_prep_kimage.

The real kernel fit-image is build under arch/${ARCH}/boot/fitImage.

This patch deploys the real fit-image instead of the one prepared by
u-boot and which is included in the ITB.

Note: this patch only concerns fit-images which are not signed by u-boot
or which do not contains initramfs. Only a kernel image with a
device-tree.

Reviewed-by: Denys Dmytriyenko <denys@ti.com>
Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>
---

 meta/classes/kernel-fitimage.bbclass | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
index 179185b6b2..8b581b36e7 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -456,9 +456,9 @@ kernel_do_deploy_append() {
 		its_base_name="fitImage-its-${PV}-${PR}-${MACHINE}-${DATETIME}"
 		its_symlink_name=fitImage-its-${MACHINE}
 		install -m 0644 fit-image.its ${DEPLOYDIR}/${its_base_name}.its
-		linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}"
-		linux_bin_symlink_name=fitImage-linux.bin-${MACHINE}
-		install -m 0644 linux.bin ${DEPLOYDIR}/${linux_bin_base_name}.bin
+		itb_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}"
+		itb_symlink_name=fitImage-linux.bin-${MACHINE}
+		install -m 0644 arch/${ARCH}/boot/fitImage ${DEPLOYDIR}/${itb_base_name}.bin
 
 		if [ -n "${INITRAMFS_IMAGE}" ]; then
 			echo "Copying fit-image-${INITRAMFS_IMAGE}.its source file..."
@@ -472,7 +472,7 @@ kernel_do_deploy_append() {
 
 		cd ${DEPLOYDIR}
 		ln -sf ${its_base_name}.its ${its_symlink_name}.its
-		ln -sf ${linux_bin_base_name}.bin ${linux_bin_symlink_name}.bin
+		ln -sf ${itb_base_name}.bin ${itb_symlink_name}.bin
 
 		if [ -n "${INITRAMFS_IMAGE}" ]; then
 			ln -sf ${its_initramfs_base_name}.its ${its_initramfs_symlink_name}.its
-- 
2.14.2

Re: [RESEND PATCH] kernel: fitimage: deploy real fit-image

[Gaël PORTAY]

Hi all,

On Sun, Nov 05, 2017 at 12:52:36PM -0500, Gaël PORTAY wrote:
> Currently, do_deploy installs a standard kernel image as an ITB. This
> image is linux.bin and it is prepared by uboot_prep_kimage.
> 
> The real kernel fit-image is build under arch/${ARCH}/boot/fitImage.
> 
> This patch deploys the real fit-image instead of the one prepared by
> u-boot and which is included in the ITB.
> 
> Note: this patch only concerns fit-images which are not signed by u-boot
> or which do not contains initramfs. Only a kernel image with a
> device-tree.
> 
> Reviewed-by: Denys Dmytriyenko <denys@ti.com>
> Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com>
> ---
> 
>  meta/classes/kernel-fitimage.bbclass | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 179185b6b2..8b581b36e7 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -456,9 +456,9 @@ kernel_do_deploy_append() {
>  		its_base_name="fitImage-its-${PV}-${PR}-${MACHINE}-${DATETIME}"
>  		its_symlink_name=fitImage-its-${MACHINE}
>  		install -m 0644 fit-image.its ${DEPLOYDIR}/${its_base_name}.its
> -		linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}"
> -		linux_bin_symlink_name=fitImage-linux.bin-${MACHINE}
> -		install -m 0644 linux.bin ${DEPLOYDIR}/${linux_bin_base_name}.bin
> +		itb_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}"
> +		itb_symlink_name=fitImage-linux.bin-${MACHINE}
> +		install -m 0644 arch/${ARCH}/boot/fitImage ${DEPLOYDIR}/${itb_base_name}.bin
>  
>  		if [ -n "${INITRAMFS_IMAGE}" ]; then
>  			echo "Copying fit-image-${INITRAMFS_IMAGE}.its source file..."
> @@ -472,7 +472,7 @@ kernel_do_deploy_append() {
>  
>  		cd ${DEPLOYDIR}
>  		ln -sf ${its_base_name}.its ${its_symlink_name}.its
> -		ln -sf ${linux_bin_base_name}.bin ${linux_bin_symlink_name}.bin
> +		ln -sf ${itb_base_name}.bin ${itb_symlink_name}.bin
>  
>  		if [ -n "${INITRAMFS_IMAGE}" ]; then
>  			ln -sf ${its_initramfs_base_name}.its ${its_initramfs_symlink_name}.its
> -- 
> 2.14.2
>

Is there anything bad with that patch? I will resend an rebased version
of that patch.

Regards,
Gael