All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] clk: sunxi-ng: a83t: Fix i2c buses bits
@ 2017-11-05 16:51 ` Mylène Josserand
  0 siblings, 0 replies; 6+ messages in thread
From: Mylène Josserand @ 2017-11-05 16:51 UTC (permalink / raw)
  To: maxime.ripard, wens, mturquette, sboyd
  Cc: mylene.josserand, linux-arm-kernel, linux-clk, linux-kernel

i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2.
Because of that, the i2c0 (bit 0) was not correctly configured.
Fixed the correct bits for i2c1 and i2c2.

Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU")

Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>
---
 drivers/clk/sunxi-ng/ccu-sun8i-a83t.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
index e43acebdfbcd..f8203115a6bc 100644
--- a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
+++ b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
@@ -354,9 +354,9 @@ static SUNXI_CCU_GATE(bus_tdm_clk,	"bus-tdm",	"apb1",
 static SUNXI_CCU_GATE(bus_i2c0_clk,	"bus-i2c0",	"apb2",
 		      0x06c, BIT(0), 0);
 static SUNXI_CCU_GATE(bus_i2c1_clk,	"bus-i2c1",	"apb2",
-		      0x06c, BIT(0), 0);
+		      0x06c, BIT(1), 0);
 static SUNXI_CCU_GATE(bus_i2c2_clk,	"bus-i2c2",	"apb2",
-		      0x06c, BIT(0), 0);
+		      0x06c, BIT(2), 0);
 static SUNXI_CCU_GATE(bus_uart0_clk,	"bus-uart0",	"apb2",
 		      0x06c, BIT(16), 0);
 static SUNXI_CCU_GATE(bus_uart1_clk,	"bus-uart1",	"apb2",
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH RESEND] clk: sunxi-ng: a83t: Fix i2c buses bits
@ 2017-11-05 16:51 ` Mylène Josserand
  0 siblings, 0 replies; 6+ messages in thread
From: Mylène Josserand @ 2017-11-05 16:51 UTC (permalink / raw)
  To: linux-arm-kernel

i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2.
Because of that, the i2c0 (bit 0) was not correctly configured.
Fixed the correct bits for i2c1 and i2c2.

Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU")

Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>
---
 drivers/clk/sunxi-ng/ccu-sun8i-a83t.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
index e43acebdfbcd..f8203115a6bc 100644
--- a/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
+++ b/drivers/clk/sunxi-ng/ccu-sun8i-a83t.c
@@ -354,9 +354,9 @@ static SUNXI_CCU_GATE(bus_tdm_clk,	"bus-tdm",	"apb1",
 static SUNXI_CCU_GATE(bus_i2c0_clk,	"bus-i2c0",	"apb2",
 		      0x06c, BIT(0), 0);
 static SUNXI_CCU_GATE(bus_i2c1_clk,	"bus-i2c1",	"apb2",
-		      0x06c, BIT(0), 0);
+		      0x06c, BIT(1), 0);
 static SUNXI_CCU_GATE(bus_i2c2_clk,	"bus-i2c2",	"apb2",
-		      0x06c, BIT(0), 0);
+		      0x06c, BIT(2), 0);
 static SUNXI_CCU_GATE(bus_uart0_clk,	"bus-uart0",	"apb2",
 		      0x06c, BIT(16), 0);
 static SUNXI_CCU_GATE(bus_uart1_clk,	"bus-uart1",	"apb2",
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] clk: sunxi-ng: a83t: Fix i2c buses bits
  2017-11-05 16:51 ` Mylène Josserand
@ 2017-11-06  8:02   ` Maxime Ripard
  -1 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2017-11-06  8:02 UTC (permalink / raw)
  To: Mylène Josserand
  Cc: wens, mturquette, sboyd, linux-arm-kernel, linux-clk, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

On Sun, Nov 05, 2017 at 05:51:34PM +0100, Mylène Josserand wrote:
> i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2.
> Because of that, the i2c0 (bit 0) was not correctly configured.
> Fixed the correct bits for i2c1 and i2c2.
> 
> Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU")
> 
> Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Stephen, can you merge it directly? It's not super urgent since we
don't have i2c enabled for that SoC yet, so it can definitely be in
4.15.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH RESEND] clk: sunxi-ng: a83t: Fix i2c buses bits
@ 2017-11-06  8:02   ` Maxime Ripard
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2017-11-06  8:02 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, Nov 05, 2017 at 05:51:34PM +0100, Myl?ne Josserand wrote:
> i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2.
> Because of that, the i2c0 (bit 0) was not correctly configured.
> Fixed the correct bits for i2c1 and i2c2.
> 
> Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU")
> 
> Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Stephen, can you merge it directly? It's not super urgent since we
don't have i2c enabled for that SoC yet, so it can definitely be in
4.15.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171106/3d66dcca/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] clk: sunxi-ng: a83t: Fix i2c buses bits
  2017-11-05 16:51 ` Mylène Josserand
@ 2017-11-14 23:53   ` Stephen Boyd
  -1 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2017-11-14 23:53 UTC (permalink / raw)
  To: Mylène Josserand
  Cc: maxime.ripard, wens, mturquette, linux-arm-kernel, linux-clk,
	linux-kernel

On 11/05, Mylène Josserand wrote:
> i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2.
> Because of that, the i2c0 (bit 0) was not correctly configured.
> Fixed the correct bits for i2c1 and i2c2.
> 
> Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU")
> 
> Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH RESEND] clk: sunxi-ng: a83t: Fix i2c buses bits
@ 2017-11-14 23:53   ` Stephen Boyd
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2017-11-14 23:53 UTC (permalink / raw)
  To: linux-arm-kernel

On 11/05, Myl?ne Josserand wrote:
> i2c1 and i2c2 bits for CCU are not bit 0 but bit 1 and bit 2.
> Because of that, the i2c0 (bit 0) was not correctly configured.
> Fixed the correct bits for i2c1 and i2c2.
> 
> Fixes: 05359be1176b ("clk: sunxi-ng: Add driver for A83T CCU")
> 
> Signed-off-by: Myl?ne Josserand <mylene.josserand@free-electrons.com>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-14 23:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-05 16:51 [PATCH RESEND] clk: sunxi-ng: a83t: Fix i2c buses bits Mylène Josserand
2017-11-05 16:51 ` Mylène Josserand
2017-11-06  8:02 ` Maxime Ripard
2017-11-06  8:02   ` Maxime Ripard
2017-11-14 23:53 ` Stephen Boyd
2017-11-14 23:53   ` Stephen Boyd

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.