* [PATCH net-next] bnxt: delete some unreachable code
@ 2017-11-06 11:43 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-11-06 11:43 UTC (permalink / raw)
To: Michael Chan, Jiri Pirko; +Cc: netdev, kernel-janitors
We return on the previous line so this "return 0;" statement should just
be deleted.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
index b6aa7db99705..69186d188c43 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
@@ -148,7 +148,6 @@ static int bnxt_vf_rep_setup_tc_block(struct net_device *dev,
return tcf_block_cb_register(f->block,
bnxt_vf_rep_setup_tc_block_cb,
vf_rep, vf_rep);
- return 0;
case TC_BLOCK_UNBIND:
tcf_block_cb_unregister(f->block,
bnxt_vf_rep_setup_tc_block_cb, vf_rep);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next] bnxt: delete some unreachable code
@ 2017-11-06 11:43 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-11-06 11:43 UTC (permalink / raw)
To: Michael Chan, Jiri Pirko; +Cc: netdev, kernel-janitors
We return on the previous line so this "return 0;" statement should just
be deleted.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
index b6aa7db99705..69186d188c43 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
@@ -148,7 +148,6 @@ static int bnxt_vf_rep_setup_tc_block(struct net_device *dev,
return tcf_block_cb_register(f->block,
bnxt_vf_rep_setup_tc_block_cb,
vf_rep, vf_rep);
- return 0;
case TC_BLOCK_UNBIND:
tcf_block_cb_unregister(f->block,
bnxt_vf_rep_setup_tc_block_cb, vf_rep);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bnxt: delete some unreachable code
2017-11-06 11:43 ` Dan Carpenter
@ 2017-11-08 4:35 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-11-08 4:35 UTC (permalink / raw)
To: dan.carpenter; +Cc: michael.chan, jiri, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 6 Nov 2017 14:43:01 +0300
> We return on the previous line so this "return 0;" statement should just
> be deleted.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bnxt: delete some unreachable code
@ 2017-11-08 4:35 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-11-08 4:35 UTC (permalink / raw)
To: dan.carpenter; +Cc: michael.chan, jiri, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 6 Nov 2017 14:43:01 +0300
> We return on the previous line so this "return 0;" statement should just
> be deleted.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-08 4:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 11:43 [PATCH net-next] bnxt: delete some unreachable code Dan Carpenter
2017-11-06 11:43 ` Dan Carpenter
2017-11-08 4:35 ` David Miller
2017-11-08 4:35 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.