[Qemu-devel] [PATCH] memory: remove unused memory_region_set_global_locking()

[Qemu-devel] [PATCH] memory: remove unused memory_region_set_global_locking()

[Marc-André Lureau]

This was never used since its introduction in commit
196ea13104f8 ("memory: Add global-locking property to memory
regions").

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 include/exec/memory.h | 12 ------------
 memory.c              |  5 -----
 2 files changed, 17 deletions(-)

diff --git a/include/exec/memory.h b/include/exec/memory.h
index 5ed4042f87..a4cabdf44c 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -1240,18 +1240,6 @@ void memory_region_set_flush_coalesced(MemoryRegion *mr);
  */
 void memory_region_clear_flush_coalesced(MemoryRegion *mr);
 
-/**
- * memory_region_set_global_locking: Declares the access processing requires
- *                                   QEMU's global lock.
- *
- * When this is invoked, accesses to the memory region will be processed while
- * holding the global lock of QEMU. This is the default behavior of memory
- * regions.
- *
- * @mr: the memory region to be updated.
- */
-void memory_region_set_global_locking(MemoryRegion *mr);
-
 /**
  * memory_region_clear_global_locking: Declares that access processing does
  *                                     not depend on the QEMU global lock.
diff --git a/memory.c b/memory.c
index e26e5a3b1d..4b41fb837b 100644
--- a/memory.c
+++ b/memory.c
@@ -2189,11 +2189,6 @@ void memory_region_clear_flush_coalesced(MemoryRegion *mr)
     }
 }
 
-void memory_region_set_global_locking(MemoryRegion *mr)
-{
-    mr->global_locking = true;
-}
-
 void memory_region_clear_global_locking(MemoryRegion *mr)
 {
     mr->global_locking = false;
-- 
2.15.0.rc0.40.gaefcc5f6f

Re: [Qemu-devel] [PATCH] memory: remove unused memory_region_set_global_locking()

[Paolo Bonzini]

On 06/11/2017 19:55, Marc-André Lureau wrote:
> This was never used since its introduction in commit
> 196ea13104f8 ("memory: Add global-locking property to memory
> regions").
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Indeed, it was introduced for symmetry with
memory_region_clear_global_locking but it isn't very useful.

Adding qemu-trivial.

Paolo