* [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-07 14:10 ` Yixun Lan
0 siblings, 0 replies; 12+ messages in thread
From: Yixun Lan @ 2017-11-07 14:10 UTC (permalink / raw)
To: Kevin Hilman, devicetree
Cc: Martin Blumenstingl, Rob Herring, Mark Rutland, Carlo Caione,
Yixun Lan, Xingyu Chen, linux-amlogic, linux-arm-kernel,
linux-kernel
From: Xingyu Chen <xingyu.chen@amlogic.com>
The SAR ADC modules doesn't require The "sana" clock.
Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
arch/arm/boot/dts/meson8.dtsi | 5 ++---
arch/arm/boot/dts/meson8b.dtsi | 5 ++---
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
4 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
index b98d44fde6b6..f93d6cf6e094 100644
--- a/arch/arm/boot/dts/meson8.dtsi
+++ b/arch/arm/boot/dts/meson8.dtsi
@@ -289,9 +289,8 @@
&saradc {
compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
clocks = <&clkc CLKID_XTAL>,
- <&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>;
- clock-names = "clkin", "core", "sana";
+ <&clkc CLKID_SAR_ADC>;
+ clock-names = "clkin", "core";
};
&spifc {
diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index bc278da7df0d..4aa444284f0c 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -185,9 +185,8 @@
&saradc {
compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
clocks = <&clkc CLKID_XTAL>,
- <&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>;
- clock-names = "clkin", "core", "sana";
+ <&clkc CLKID_SAR_ADC>;
+ clock-names = "clkin", "core";
};
&uart_AO {
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index af834cdbba79..b77f2593cdc3 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -686,10 +686,9 @@
compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
clocks = <&xtal>,
<&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>,
<&clkc CLKID_SAR_ADC_CLK>,
<&clkc CLKID_SAR_ADC_SEL>;
- clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
+ clock-names = "clkin", "core", "adc_clk", "adc_sel";
};
&sd_emmc_a {
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index d8dd3298b15c..07805a3b4db0 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -628,10 +628,9 @@
compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
clocks = <&xtal>,
<&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>,
<&clkc CLKID_SAR_ADC_CLK>,
<&clkc CLKID_SAR_ADC_SEL>;
- clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
+ clock-names = "clkin", "core", "adc_clk", "adc_sel";
};
&sd_emmc_a {
--
2.14.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-07 14:10 ` Yixun Lan
0 siblings, 0 replies; 12+ messages in thread
From: Yixun Lan @ 2017-11-07 14:10 UTC (permalink / raw)
To: Kevin Hilman, devicetree
Cc: Martin Blumenstingl, Rob Herring, Mark Rutland, Carlo Caione,
Yixun Lan, Xingyu Chen, linux-amlogic, linux-arm-kernel,
linux-kernel
From: Xingyu Chen <xingyu.chen@amlogic.com>
The SAR ADC modules doesn't require The "sana" clock.
Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
arch/arm/boot/dts/meson8.dtsi | 5 ++---
arch/arm/boot/dts/meson8b.dtsi | 5 ++---
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
4 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
index b98d44fde6b6..f93d6cf6e094 100644
--- a/arch/arm/boot/dts/meson8.dtsi
+++ b/arch/arm/boot/dts/meson8.dtsi
@@ -289,9 +289,8 @@
&saradc {
compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
clocks = <&clkc CLKID_XTAL>,
- <&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>;
- clock-names = "clkin", "core", "sana";
+ <&clkc CLKID_SAR_ADC>;
+ clock-names = "clkin", "core";
};
&spifc {
diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index bc278da7df0d..4aa444284f0c 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -185,9 +185,8 @@
&saradc {
compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
clocks = <&clkc CLKID_XTAL>,
- <&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>;
- clock-names = "clkin", "core", "sana";
+ <&clkc CLKID_SAR_ADC>;
+ clock-names = "clkin", "core";
};
&uart_AO {
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index af834cdbba79..b77f2593cdc3 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -686,10 +686,9 @@
compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
clocks = <&xtal>,
<&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>,
<&clkc CLKID_SAR_ADC_CLK>,
<&clkc CLKID_SAR_ADC_SEL>;
- clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
+ clock-names = "clkin", "core", "adc_clk", "adc_sel";
};
&sd_emmc_a {
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index d8dd3298b15c..07805a3b4db0 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -628,10 +628,9 @@
compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
clocks = <&xtal>,
<&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>,
<&clkc CLKID_SAR_ADC_CLK>,
<&clkc CLKID_SAR_ADC_SEL>;
- clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
+ clock-names = "clkin", "core", "adc_clk", "adc_sel";
};
&sd_emmc_a {
--
2.14.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-07 14:10 ` Yixun Lan
0 siblings, 0 replies; 12+ messages in thread
From: Yixun Lan @ 2017-11-07 14:10 UTC (permalink / raw)
To: linux-arm-kernel
From: Xingyu Chen <xingyu.chen@amlogic.com>
The SAR ADC modules doesn't require The "sana" clock.
Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
arch/arm/boot/dts/meson8.dtsi | 5 ++---
arch/arm/boot/dts/meson8b.dtsi | 5 ++---
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
4 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
index b98d44fde6b6..f93d6cf6e094 100644
--- a/arch/arm/boot/dts/meson8.dtsi
+++ b/arch/arm/boot/dts/meson8.dtsi
@@ -289,9 +289,8 @@
&saradc {
compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
clocks = <&clkc CLKID_XTAL>,
- <&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>;
- clock-names = "clkin", "core", "sana";
+ <&clkc CLKID_SAR_ADC>;
+ clock-names = "clkin", "core";
};
&spifc {
diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index bc278da7df0d..4aa444284f0c 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -185,9 +185,8 @@
&saradc {
compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
clocks = <&clkc CLKID_XTAL>,
- <&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>;
- clock-names = "clkin", "core", "sana";
+ <&clkc CLKID_SAR_ADC>;
+ clock-names = "clkin", "core";
};
&uart_AO {
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index af834cdbba79..b77f2593cdc3 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -686,10 +686,9 @@
compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
clocks = <&xtal>,
<&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>,
<&clkc CLKID_SAR_ADC_CLK>,
<&clkc CLKID_SAR_ADC_SEL>;
- clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
+ clock-names = "clkin", "core", "adc_clk", "adc_sel";
};
&sd_emmc_a {
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index d8dd3298b15c..07805a3b4db0 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -628,10 +628,9 @@
compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
clocks = <&xtal>,
<&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>,
<&clkc CLKID_SAR_ADC_CLK>,
<&clkc CLKID_SAR_ADC_SEL>;
- clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
+ clock-names = "clkin", "core", "adc_clk", "adc_sel";
};
&sd_emmc_a {
--
2.14.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-07 14:10 ` Yixun Lan
0 siblings, 0 replies; 12+ messages in thread
From: Yixun Lan @ 2017-11-07 14:10 UTC (permalink / raw)
To: linus-amlogic
From: Xingyu Chen <xingyu.chen@amlogic.com>
The SAR ADC modules doesn't require The "sana" clock.
Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
arch/arm/boot/dts/meson8.dtsi | 5 ++---
arch/arm/boot/dts/meson8b.dtsi | 5 ++---
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
4 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
index b98d44fde6b6..f93d6cf6e094 100644
--- a/arch/arm/boot/dts/meson8.dtsi
+++ b/arch/arm/boot/dts/meson8.dtsi
@@ -289,9 +289,8 @@
&saradc {
compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
clocks = <&clkc CLKID_XTAL>,
- <&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>;
- clock-names = "clkin", "core", "sana";
+ <&clkc CLKID_SAR_ADC>;
+ clock-names = "clkin", "core";
};
&spifc {
diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index bc278da7df0d..4aa444284f0c 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -185,9 +185,8 @@
&saradc {
compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
clocks = <&clkc CLKID_XTAL>,
- <&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>;
- clock-names = "clkin", "core", "sana";
+ <&clkc CLKID_SAR_ADC>;
+ clock-names = "clkin", "core";
};
&uart_AO {
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index af834cdbba79..b77f2593cdc3 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -686,10 +686,9 @@
compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
clocks = <&xtal>,
<&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>,
<&clkc CLKID_SAR_ADC_CLK>,
<&clkc CLKID_SAR_ADC_SEL>;
- clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
+ clock-names = "clkin", "core", "adc_clk", "adc_sel";
};
&sd_emmc_a {
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index d8dd3298b15c..07805a3b4db0 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -628,10 +628,9 @@
compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
clocks = <&xtal>,
<&clkc CLKID_SAR_ADC>,
- <&clkc CLKID_SANA>,
<&clkc CLKID_SAR_ADC_CLK>,
<&clkc CLKID_SAR_ADC_SEL>;
- clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
+ clock-names = "clkin", "core", "adc_clk", "adc_sel";
};
&sd_emmc_a {
--
2.14.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-12 1:33 ` Martin Blumenstingl
0 siblings, 0 replies; 12+ messages in thread
From: Martin Blumenstingl @ 2017-11-12 1:33 UTC (permalink / raw)
To: Yixun Lan
Cc: Kevin Hilman, devicetree, Rob Herring, Mark Rutland,
Carlo Caione, Xingyu Chen, linux-amlogic, linux-arm-kernel,
linux-kernel
Hi Yixun,
On Tue, Nov 7, 2017 at 3:10 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> From: Xingyu Chen <xingyu.chen@amlogic.com>
>
> The SAR ADC modules doesn't require The "sana" clock.
>
> Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
> arch/arm/boot/dts/meson8.dtsi | 5 ++---
> arch/arm/boot/dts/meson8b.dtsi | 5 ++---
these two should go into a separate patch (with "ARM: dts: ..."
prefix) - the ARM maintainers want separate pull requests for the
32-bit and 64-bit .dts changes, so patches should also follow that
schema
with that fixed, you can add my ACK on both (32-bit and 64-bit) .dts patches:
Acked-by: Martin Blumenstingl<martin.blumenstingl@googlemail.com>
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
> 4 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index b98d44fde6b6..f93d6cf6e094 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -289,9 +289,8 @@
> &saradc {
> compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
> clocks = <&clkc CLKID_XTAL>,
> - <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>;
> - clock-names = "clkin", "core", "sana";
> + <&clkc CLKID_SAR_ADC>;
> + clock-names = "clkin", "core";
> };
>
> &spifc {
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index bc278da7df0d..4aa444284f0c 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -185,9 +185,8 @@
> &saradc {
> compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
> clocks = <&clkc CLKID_XTAL>,
> - <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>;
> - clock-names = "clkin", "core", "sana";
> + <&clkc CLKID_SAR_ADC>;
> + clock-names = "clkin", "core";
> };
>
> &uart_AO {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index af834cdbba79..b77f2593cdc3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -686,10 +686,9 @@
> compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
> clocks = <&xtal>,
> <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>,
> <&clkc CLKID_SAR_ADC_CLK>,
> <&clkc CLKID_SAR_ADC_SEL>;
> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
> };
>
> &sd_emmc_a {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index d8dd3298b15c..07805a3b4db0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -628,10 +628,9 @@
> compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
> clocks = <&xtal>,
> <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>,
> <&clkc CLKID_SAR_ADC_CLK>,
> <&clkc CLKID_SAR_ADC_SEL>;
> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
> };
>
> &sd_emmc_a {
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-12 1:33 ` Martin Blumenstingl
0 siblings, 0 replies; 12+ messages in thread
From: Martin Blumenstingl @ 2017-11-12 1:33 UTC (permalink / raw)
To: Yixun Lan
Cc: Kevin Hilman, devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring,
Mark Rutland, Carlo Caione, Xingyu Chen,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi Yixun,
On Tue, Nov 7, 2017 at 3:10 PM, Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org> wrote:
> From: Xingyu Chen <xingyu.chen-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
>
> The SAR ADC modules doesn't require The "sana" clock.
>
> Singed-off-by: Xingyu Chen <xingyu.chen-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
> ---
> arch/arm/boot/dts/meson8.dtsi | 5 ++---
> arch/arm/boot/dts/meson8b.dtsi | 5 ++---
these two should go into a separate patch (with "ARM: dts: ..."
prefix) - the ARM maintainers want separate pull requests for the
32-bit and 64-bit .dts changes, so patches should also follow that
schema
with that fixed, you can add my ACK on both (32-bit and 64-bit) .dts patches:
Acked-by: Martin Blumenstingl<martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
> 4 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index b98d44fde6b6..f93d6cf6e094 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -289,9 +289,8 @@
> &saradc {
> compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
> clocks = <&clkc CLKID_XTAL>,
> - <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>;
> - clock-names = "clkin", "core", "sana";
> + <&clkc CLKID_SAR_ADC>;
> + clock-names = "clkin", "core";
> };
>
> &spifc {
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index bc278da7df0d..4aa444284f0c 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -185,9 +185,8 @@
> &saradc {
> compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
> clocks = <&clkc CLKID_XTAL>,
> - <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>;
> - clock-names = "clkin", "core", "sana";
> + <&clkc CLKID_SAR_ADC>;
> + clock-names = "clkin", "core";
> };
>
> &uart_AO {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index af834cdbba79..b77f2593cdc3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -686,10 +686,9 @@
> compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
> clocks = <&xtal>,
> <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>,
> <&clkc CLKID_SAR_ADC_CLK>,
> <&clkc CLKID_SAR_ADC_SEL>;
> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
> };
>
> &sd_emmc_a {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index d8dd3298b15c..07805a3b4db0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -628,10 +628,9 @@
> compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
> clocks = <&xtal>,
> <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>,
> <&clkc CLKID_SAR_ADC_CLK>,
> <&clkc CLKID_SAR_ADC_SEL>;
> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
> };
>
> &sd_emmc_a {
> --
> 2.14.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-12 1:33 ` Martin Blumenstingl
0 siblings, 0 replies; 12+ messages in thread
From: Martin Blumenstingl @ 2017-11-12 1:33 UTC (permalink / raw)
To: linux-arm-kernel
Hi Yixun,
On Tue, Nov 7, 2017 at 3:10 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> From: Xingyu Chen <xingyu.chen@amlogic.com>
>
> The SAR ADC modules doesn't require The "sana" clock.
>
> Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
> arch/arm/boot/dts/meson8.dtsi | 5 ++---
> arch/arm/boot/dts/meson8b.dtsi | 5 ++---
these two should go into a separate patch (with "ARM: dts: ..."
prefix) - the ARM maintainers want separate pull requests for the
32-bit and 64-bit .dts changes, so patches should also follow that
schema
with that fixed, you can add my ACK on both (32-bit and 64-bit) .dts patches:
Acked-by: Martin Blumenstingl<martin.blumenstingl@googlemail.com>
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
> 4 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index b98d44fde6b6..f93d6cf6e094 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -289,9 +289,8 @@
> &saradc {
> compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
> clocks = <&clkc CLKID_XTAL>,
> - <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>;
> - clock-names = "clkin", "core", "sana";
> + <&clkc CLKID_SAR_ADC>;
> + clock-names = "clkin", "core";
> };
>
> &spifc {
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index bc278da7df0d..4aa444284f0c 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -185,9 +185,8 @@
> &saradc {
> compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
> clocks = <&clkc CLKID_XTAL>,
> - <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>;
> - clock-names = "clkin", "core", "sana";
> + <&clkc CLKID_SAR_ADC>;
> + clock-names = "clkin", "core";
> };
>
> &uart_AO {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index af834cdbba79..b77f2593cdc3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -686,10 +686,9 @@
> compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
> clocks = <&xtal>,
> <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>,
> <&clkc CLKID_SAR_ADC_CLK>,
> <&clkc CLKID_SAR_ADC_SEL>;
> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
> };
>
> &sd_emmc_a {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index d8dd3298b15c..07805a3b4db0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -628,10 +628,9 @@
> compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
> clocks = <&xtal>,
> <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>,
> <&clkc CLKID_SAR_ADC_CLK>,
> <&clkc CLKID_SAR_ADC_SEL>;
> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
> };
>
> &sd_emmc_a {
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-12 1:33 ` Martin Blumenstingl
0 siblings, 0 replies; 12+ messages in thread
From: Martin Blumenstingl @ 2017-11-12 1:33 UTC (permalink / raw)
To: linus-amlogic
Hi Yixun,
On Tue, Nov 7, 2017 at 3:10 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> From: Xingyu Chen <xingyu.chen@amlogic.com>
>
> The SAR ADC modules doesn't require The "sana" clock.
>
> Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
> arch/arm/boot/dts/meson8.dtsi | 5 ++---
> arch/arm/boot/dts/meson8b.dtsi | 5 ++---
these two should go into a separate patch (with "ARM: dts: ..."
prefix) - the ARM maintainers want separate pull requests for the
32-bit and 64-bit .dts changes, so patches should also follow that
schema
with that fixed, you can add my ACK on both (32-bit and 64-bit) .dts patches:
Acked-by: Martin Blumenstingl<martin.blumenstingl@googlemail.com>
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
> 4 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index b98d44fde6b6..f93d6cf6e094 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -289,9 +289,8 @@
> &saradc {
> compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
> clocks = <&clkc CLKID_XTAL>,
> - <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>;
> - clock-names = "clkin", "core", "sana";
> + <&clkc CLKID_SAR_ADC>;
> + clock-names = "clkin", "core";
> };
>
> &spifc {
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index bc278da7df0d..4aa444284f0c 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -185,9 +185,8 @@
> &saradc {
> compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
> clocks = <&clkc CLKID_XTAL>,
> - <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>;
> - clock-names = "clkin", "core", "sana";
> + <&clkc CLKID_SAR_ADC>;
> + clock-names = "clkin", "core";
> };
>
> &uart_AO {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index af834cdbba79..b77f2593cdc3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -686,10 +686,9 @@
> compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
> clocks = <&xtal>,
> <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>,
> <&clkc CLKID_SAR_ADC_CLK>,
> <&clkc CLKID_SAR_ADC_SEL>;
> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
> };
>
> &sd_emmc_a {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index d8dd3298b15c..07805a3b4db0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -628,10 +628,9 @@
> compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
> clocks = <&xtal>,
> <&clkc CLKID_SAR_ADC>,
> - <&clkc CLKID_SANA>,
> <&clkc CLKID_SAR_ADC_CLK>,
> <&clkc CLKID_SAR_ADC_SEL>;
> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
> };
>
> &sd_emmc_a {
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-13 7:38 ` Yixun Lan
0 siblings, 0 replies; 12+ messages in thread
From: Yixun Lan @ 2017-11-13 7:38 UTC (permalink / raw)
To: Martin Blumenstingl, Kevin Hilman
Cc: yixun.lan, devicetree, Rob Herring, Mark Rutland, Carlo Caione,
Xingyu Chen, linux-amlogic, linux-arm-kernel, linux-kernel
Hi Kevin & others
I'd like to just re-send the patch [4/4] (while leave others[1-3/4]
unchanged), to have separated DT patch the for 32bit / 64bit platform.
is this ok for you?
On 11/12/17 09:33, Martin Blumenstingl wrote:
> Hi Yixun,
>
> On Tue, Nov 7, 2017 at 3:10 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
>> From: Xingyu Chen <xingyu.chen@amlogic.com>
>>
>> The SAR ADC modules doesn't require The "sana" clock.
>>
>> Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
>> ---
>> arch/arm/boot/dts/meson8.dtsi | 5 ++---
>> arch/arm/boot/dts/meson8b.dtsi | 5 ++---
> these two should go into a separate patch (with "ARM: dts: ..."
> prefix) - the ARM maintainers want separate pull requests for the
> 32-bit and 64-bit .dts changes, so patches should also follow that
> schema
>
> with that fixed, you can add my ACK on both (32-bit and 64-bit) .dts patches:
> Acked-by: Martin Blumenstingl<martin.blumenstingl@googlemail.com>
>
thanks, I will send separate patch for this, and I will add your 'Acked-by'
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
>> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
>> 4 files changed, 6 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
>> index b98d44fde6b6..f93d6cf6e094 100644
>> --- a/arch/arm/boot/dts/meson8.dtsi
>> +++ b/arch/arm/boot/dts/meson8.dtsi
>> @@ -289,9 +289,8 @@
>> &saradc {
>> compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
>> clocks = <&clkc CLKID_XTAL>,
>> - <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>;
>> - clock-names = "clkin", "core", "sana";
>> + <&clkc CLKID_SAR_ADC>;
>> + clock-names = "clkin", "core";
>> };
>>
>> &spifc {
>> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
>> index bc278da7df0d..4aa444284f0c 100644
>> --- a/arch/arm/boot/dts/meson8b.dtsi
>> +++ b/arch/arm/boot/dts/meson8b.dtsi
>> @@ -185,9 +185,8 @@
>> &saradc {
>> compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
>> clocks = <&clkc CLKID_XTAL>,
>> - <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>;
>> - clock-names = "clkin", "core", "sana";
>> + <&clkc CLKID_SAR_ADC>;
>> + clock-names = "clkin", "core";
>> };
>>
>> &uart_AO {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index af834cdbba79..b77f2593cdc3 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -686,10 +686,9 @@
>> compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
>> clocks = <&xtal>,
>> <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>,
>> <&clkc CLKID_SAR_ADC_CLK>,
>> <&clkc CLKID_SAR_ADC_SEL>;
>> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
>> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
>> };
>>
>> &sd_emmc_a {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> index d8dd3298b15c..07805a3b4db0 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> @@ -628,10 +628,9 @@
>> compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
>> clocks = <&xtal>,
>> <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>,
>> <&clkc CLKID_SAR_ADC_CLK>,
>> <&clkc CLKID_SAR_ADC_SEL>;
>> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
>> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
>> };
>>
>> &sd_emmc_a {
>> --
>> 2.14.1
>>
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-13 7:38 ` Yixun Lan
0 siblings, 0 replies; 12+ messages in thread
From: Yixun Lan @ 2017-11-13 7:38 UTC (permalink / raw)
To: Martin Blumenstingl, Kevin Hilman
Cc: yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ,
devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Mark Rutland,
Carlo Caione, Xingyu Chen,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi Kevin & others
I'd like to just re-send the patch [4/4] (while leave others[1-3/4]
unchanged), to have separated DT patch the for 32bit / 64bit platform.
is this ok for you?
On 11/12/17 09:33, Martin Blumenstingl wrote:
> Hi Yixun,
>
> On Tue, Nov 7, 2017 at 3:10 PM, Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org> wrote:
>> From: Xingyu Chen <xingyu.chen-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
>>
>> The SAR ADC modules doesn't require The "sana" clock.
>>
>> Singed-off-by: Xingyu Chen <xingyu.chen-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
>> Signed-off-by: Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>
>> ---
>> arch/arm/boot/dts/meson8.dtsi | 5 ++---
>> arch/arm/boot/dts/meson8b.dtsi | 5 ++---
> these two should go into a separate patch (with "ARM: dts: ..."
> prefix) - the ARM maintainers want separate pull requests for the
> 32-bit and 64-bit .dts changes, so patches should also follow that
> schema
>
> with that fixed, you can add my ACK on both (32-bit and 64-bit) .dts patches:
> Acked-by: Martin Blumenstingl<martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
>
thanks, I will send separate patch for this, and I will add your 'Acked-by'
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
>> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
>> 4 files changed, 6 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
>> index b98d44fde6b6..f93d6cf6e094 100644
>> --- a/arch/arm/boot/dts/meson8.dtsi
>> +++ b/arch/arm/boot/dts/meson8.dtsi
>> @@ -289,9 +289,8 @@
>> &saradc {
>> compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
>> clocks = <&clkc CLKID_XTAL>,
>> - <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>;
>> - clock-names = "clkin", "core", "sana";
>> + <&clkc CLKID_SAR_ADC>;
>> + clock-names = "clkin", "core";
>> };
>>
>> &spifc {
>> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
>> index bc278da7df0d..4aa444284f0c 100644
>> --- a/arch/arm/boot/dts/meson8b.dtsi
>> +++ b/arch/arm/boot/dts/meson8b.dtsi
>> @@ -185,9 +185,8 @@
>> &saradc {
>> compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
>> clocks = <&clkc CLKID_XTAL>,
>> - <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>;
>> - clock-names = "clkin", "core", "sana";
>> + <&clkc CLKID_SAR_ADC>;
>> + clock-names = "clkin", "core";
>> };
>>
>> &uart_AO {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index af834cdbba79..b77f2593cdc3 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -686,10 +686,9 @@
>> compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
>> clocks = <&xtal>,
>> <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>,
>> <&clkc CLKID_SAR_ADC_CLK>,
>> <&clkc CLKID_SAR_ADC_SEL>;
>> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
>> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
>> };
>>
>> &sd_emmc_a {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> index d8dd3298b15c..07805a3b4db0 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> @@ -628,10 +628,9 @@
>> compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
>> clocks = <&xtal>,
>> <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>,
>> <&clkc CLKID_SAR_ADC_CLK>,
>> <&clkc CLKID_SAR_ADC_SEL>;
>> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
>> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
>> };
>>
>> &sd_emmc_a {
>> --
>> 2.14.1
>>
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-13 7:38 ` Yixun Lan
0 siblings, 0 replies; 12+ messages in thread
From: Yixun Lan @ 2017-11-13 7:38 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kevin & others
I'd like to just re-send the patch [4/4] (while leave others[1-3/4]
unchanged), to have separated DT patch the for 32bit / 64bit platform.
is this ok for you?
On 11/12/17 09:33, Martin Blumenstingl wrote:
> Hi Yixun,
>
> On Tue, Nov 7, 2017 at 3:10 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
>> From: Xingyu Chen <xingyu.chen@amlogic.com>
>>
>> The SAR ADC modules doesn't require The "sana" clock.
>>
>> Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
>> ---
>> arch/arm/boot/dts/meson8.dtsi | 5 ++---
>> arch/arm/boot/dts/meson8b.dtsi | 5 ++---
> these two should go into a separate patch (with "ARM: dts: ..."
> prefix) - the ARM maintainers want separate pull requests for the
> 32-bit and 64-bit .dts changes, so patches should also follow that
> schema
>
> with that fixed, you can add my ACK on both (32-bit and 64-bit) .dts patches:
> Acked-by: Martin Blumenstingl<martin.blumenstingl@googlemail.com>
>
thanks, I will send separate patch for this, and I will add your 'Acked-by'
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
>> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
>> 4 files changed, 6 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
>> index b98d44fde6b6..f93d6cf6e094 100644
>> --- a/arch/arm/boot/dts/meson8.dtsi
>> +++ b/arch/arm/boot/dts/meson8.dtsi
>> @@ -289,9 +289,8 @@
>> &saradc {
>> compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
>> clocks = <&clkc CLKID_XTAL>,
>> - <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>;
>> - clock-names = "clkin", "core", "sana";
>> + <&clkc CLKID_SAR_ADC>;
>> + clock-names = "clkin", "core";
>> };
>>
>> &spifc {
>> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
>> index bc278da7df0d..4aa444284f0c 100644
>> --- a/arch/arm/boot/dts/meson8b.dtsi
>> +++ b/arch/arm/boot/dts/meson8b.dtsi
>> @@ -185,9 +185,8 @@
>> &saradc {
>> compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
>> clocks = <&clkc CLKID_XTAL>,
>> - <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>;
>> - clock-names = "clkin", "core", "sana";
>> + <&clkc CLKID_SAR_ADC>;
>> + clock-names = "clkin", "core";
>> };
>>
>> &uart_AO {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index af834cdbba79..b77f2593cdc3 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -686,10 +686,9 @@
>> compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
>> clocks = <&xtal>,
>> <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>,
>> <&clkc CLKID_SAR_ADC_CLK>,
>> <&clkc CLKID_SAR_ADC_SEL>;
>> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
>> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
>> };
>>
>> &sd_emmc_a {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> index d8dd3298b15c..07805a3b4db0 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> @@ -628,10 +628,9 @@
>> compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
>> clocks = <&xtal>,
>> <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>,
>> <&clkc CLKID_SAR_ADC_CLK>,
>> <&clkc CLKID_SAR_ADC_SEL>;
>> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
>> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
>> };
>>
>> &sd_emmc_a {
>> --
>> 2.14.1
>>
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC
@ 2017-11-13 7:38 ` Yixun Lan
0 siblings, 0 replies; 12+ messages in thread
From: Yixun Lan @ 2017-11-13 7:38 UTC (permalink / raw)
To: linus-amlogic
Hi Kevin & others
I'd like to just re-send the patch [4/4] (while leave others[1-3/4]
unchanged), to have separated DT patch the for 32bit / 64bit platform.
is this ok for you?
On 11/12/17 09:33, Martin Blumenstingl wrote:
> Hi Yixun,
>
> On Tue, Nov 7, 2017 at 3:10 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
>> From: Xingyu Chen <xingyu.chen@amlogic.com>
>>
>> The SAR ADC modules doesn't require The "sana" clock.
>>
>> Singed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
>> ---
>> arch/arm/boot/dts/meson8.dtsi | 5 ++---
>> arch/arm/boot/dts/meson8b.dtsi | 5 ++---
> these two should go into a separate patch (with "ARM: dts: ..."
> prefix) - the ARM maintainers want separate pull requests for the
> 32-bit and 64-bit .dts changes, so patches should also follow that
> schema
>
> with that fixed, you can add my ACK on both (32-bit and 64-bit) .dts patches:
> Acked-by: Martin Blumenstingl<martin.blumenstingl@googlemail.com>
>
thanks, I will send separate patch for this, and I will add your 'Acked-by'
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
>> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +--
>> 4 files changed, 6 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
>> index b98d44fde6b6..f93d6cf6e094 100644
>> --- a/arch/arm/boot/dts/meson8.dtsi
>> +++ b/arch/arm/boot/dts/meson8.dtsi
>> @@ -289,9 +289,8 @@
>> &saradc {
>> compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
>> clocks = <&clkc CLKID_XTAL>,
>> - <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>;
>> - clock-names = "clkin", "core", "sana";
>> + <&clkc CLKID_SAR_ADC>;
>> + clock-names = "clkin", "core";
>> };
>>
>> &spifc {
>> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
>> index bc278da7df0d..4aa444284f0c 100644
>> --- a/arch/arm/boot/dts/meson8b.dtsi
>> +++ b/arch/arm/boot/dts/meson8b.dtsi
>> @@ -185,9 +185,8 @@
>> &saradc {
>> compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
>> clocks = <&clkc CLKID_XTAL>,
>> - <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>;
>> - clock-names = "clkin", "core", "sana";
>> + <&clkc CLKID_SAR_ADC>;
>> + clock-names = "clkin", "core";
>> };
>>
>> &uart_AO {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index af834cdbba79..b77f2593cdc3 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -686,10 +686,9 @@
>> compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
>> clocks = <&xtal>,
>> <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>,
>> <&clkc CLKID_SAR_ADC_CLK>,
>> <&clkc CLKID_SAR_ADC_SEL>;
>> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
>> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
>> };
>>
>> &sd_emmc_a {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> index d8dd3298b15c..07805a3b4db0 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> @@ -628,10 +628,9 @@
>> compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
>> clocks = <&xtal>,
>> <&clkc CLKID_SAR_ADC>,
>> - <&clkc CLKID_SANA>,
>> <&clkc CLKID_SAR_ADC_CLK>,
>> <&clkc CLKID_SAR_ADC_SEL>;
>> - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
>> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
>> };
>>
>> &sd_emmc_a {
>> --
>> 2.14.1
>>
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-11-13 7:39 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 14:10 [PATCH v4 4/4] ARM64: dts: meson: drop "sana" clock from SAR ADC Yixun Lan
2017-11-07 14:10 ` Yixun Lan
2017-11-07 14:10 ` Yixun Lan
2017-11-07 14:10 ` Yixun Lan
2017-11-12 1:33 ` Martin Blumenstingl
2017-11-12 1:33 ` Martin Blumenstingl
2017-11-12 1:33 ` Martin Blumenstingl
2017-11-12 1:33 ` Martin Blumenstingl
2017-11-13 7:38 ` Yixun Lan
2017-11-13 7:38 ` Yixun Lan
2017-11-13 7:38 ` Yixun Lan
2017-11-13 7:38 ` Yixun Lan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.