From: James Hogan <james.hogan@mips.com>
To: "Steven J. Hill" <steven.hill@cavium.com>
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>
Subject: Re: [PATCH v2 03/12] MIPS: Allow __cpu_number_map to be larger than NR_CPUS
Date: Tue, 7 Nov 2017 18:29:49 +0000 [thread overview]
Message-ID: <20171107182948.GJ15260@jhogan-linux> (raw)
In-Reply-To: <1506620053-2557-4-git-send-email-steven.hill@cavium.com>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
Hi,
On Thu, Sep 28, 2017 at 12:34:04PM -0500, Steven J. Hill wrote:
> @@ -2725,6 +2726,14 @@ config NR_CPUS
> config MIPS_PERF_SHARED_TC_COUNTERS
> bool
>
> +config MIPS_NR_CPU_NR_MAP_1024
> + bool
> +
> +config MIPS_NR_CPU_NR_MAP
> + int
I think this needs:
depends on SMP
Otherwise you get errors like this on UP defconfigs:
.config:144:warning: symbol value '' invalid for MIPS_NR_CPU_NR_MAP
The use in smp.h looks safe since asm/smp.h is only included if
CONFIG_SMP.
I'll squash the fix in.
Cheers
James
> + default 1024 if MIPS_NR_CPU_NR_MAP_1024
> + default NR_CPUS if !MIPS_NR_CPU_NR_MAP_1024
> +
> #
> # Timer Interrupt Frequency Configuration
> #
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@mips.com>
To: "Steven J. Hill" <steven.hill@cavium.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH v2 03/12] MIPS: Allow __cpu_number_map to be larger than NR_CPUS
Date: Tue, 7 Nov 2017 18:29:49 +0000 [thread overview]
Message-ID: <20171107182948.GJ15260@jhogan-linux> (raw)
Message-ID: <20171107182949.aRQcGburrHYCXKUSVK7pRsogcDeVllnm8TdRaY7T2cg@z> (raw)
In-Reply-To: <1506620053-2557-4-git-send-email-steven.hill@cavium.com>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
Hi,
On Thu, Sep 28, 2017 at 12:34:04PM -0500, Steven J. Hill wrote:
> @@ -2725,6 +2726,14 @@ config NR_CPUS
> config MIPS_PERF_SHARED_TC_COUNTERS
> bool
>
> +config MIPS_NR_CPU_NR_MAP_1024
> + bool
> +
> +config MIPS_NR_CPU_NR_MAP
> + int
I think this needs:
depends on SMP
Otherwise you get errors like this on UP defconfigs:
.config:144:warning: symbol value '' invalid for MIPS_NR_CPU_NR_MAP
The use in smp.h looks safe since asm/smp.h is only included if
CONFIG_SMP.
I'll squash the fix in.
Cheers
James
> + default 1024 if MIPS_NR_CPU_NR_MAP_1024
> + default NR_CPUS if !MIPS_NR_CPU_NR_MAP_1024
> +
> #
> # Timer Interrupt Frequency Configuration
> #
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-07 18:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 17:34 [PATCH v2 00/12] Add Octeon Hotplug CPU Support Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 01/12] MIPS: Add nudges to writes for bit unlocks Steven J. Hill
2017-09-29 20:54 ` James Hogan
2017-09-29 20:54 ` James Hogan
2017-09-28 17:34 ` [PATCH v2 02/12] MIPS: Remove unused variable 'lastpfn' Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 03/12] MIPS: Allow __cpu_number_map to be larger than NR_CPUS Steven J. Hill
2017-11-07 18:29 ` James Hogan [this message]
2017-11-07 18:29 ` James Hogan
2017-09-28 17:34 ` [PATCH v2 04/12] MIPS: Octeon: Remove usage of cvmx_wait() everywhere Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 05/12] MIPS: Octeon: Header and file cleaning Steven J. Hill
2017-11-07 16:11 ` James Hogan
2017-11-07 16:11 ` James Hogan
2017-11-07 18:52 ` Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 06/12] MIPS: Octeon: Update CIU_FUSE registers Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 07/12] MIPS: Octeon: Add Octeon III platforms for console output Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 08/12] MIPS: Octeon: Remove crufty KEXEC and CRASH_DUMP code Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 09/12] MIPS: Octeon: Populate kernel memory from cvmx_bootmem named blocks Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 10/12] MIPS: Add the concept of BOOT_MEM_KERNEL to boot_mem_map Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 11/12] MIPS: Add define for number of bits in MMUSizeExt field Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 12/12] MIPS: Octeon: Add working hotplug CPU support Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107182948.GJ15260@jhogan-linux \
--to=james.hogan@mips.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.