* [PATCH v3 0/3] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3
@ 2017-11-05 17:09 Yiannis Marangos
2017-11-05 17:09 ` [PATCH v3 1/2] " Yiannis Marangos
2017-11-05 17:09 ` [PATCH v3 2/2] Input: synaptics - Lenovo X1 Carbon 5 should use SMBUS/RMI Yiannis Marangos
0 siblings, 2 replies; 5+ messages in thread
From: Yiannis Marangos @ 2017-11-05 17:09 UTC (permalink / raw)
To: linux-input, dmitry.torokhov
Added 'signed-off-by'.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3
2017-11-05 17:09 [PATCH v3 0/3] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3 Yiannis Marangos
@ 2017-11-05 17:09 ` Yiannis Marangos
2017-11-06 7:56 ` Benjamin Tissoires
2017-11-05 17:09 ` [PATCH v3 2/2] Input: synaptics - Lenovo X1 Carbon 5 should use SMBUS/RMI Yiannis Marangos
1 sibling, 1 reply; 5+ messages in thread
From: Yiannis Marangos @ 2017-11-05 17:09 UTC (permalink / raw)
To: linux-input, dmitry.torokhov; +Cc: Yiannis Marangos
Some synaptics devices such as LEN0073 use SMBUS version 3.
Signed-off-by: Yiannis Marangos <yiannis.marangos@gmail.com>
---
drivers/input/rmi4/rmi_smbus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_smbus.c b/drivers/input/rmi4/rmi_smbus.c
index 225025a0940c..b6ccf39c6a7b 100644
--- a/drivers/input/rmi4/rmi_smbus.c
+++ b/drivers/input/rmi4/rmi_smbus.c
@@ -312,7 +312,7 @@ static int rmi_smb_probe(struct i2c_client *client,
rmi_smb->xport.dev = &client->dev;
rmi_smb->xport.pdata = *pdata;
rmi_smb->xport.pdata.irq = client->irq;
- rmi_smb->xport.proto_name = "smb2";
+ rmi_smb->xport.proto_name = "smb";
rmi_smb->xport.ops = &rmi_smb_ops;
smbus_version = rmi_smb_get_version(rmi_smb);
@@ -322,7 +322,7 @@ static int rmi_smb_probe(struct i2c_client *client,
rmi_dbg(RMI_DEBUG_XPORT, &client->dev, "Smbus version is %d",
smbus_version);
- if (smbus_version != 2) {
+ if (smbus_version != 2 && smbus_version != 3) {
dev_err(&client->dev, "Unrecognized SMB version %d\n",
smbus_version);
return -ENODEV;
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] Input: synaptics - Lenovo X1 Carbon 5 should use SMBUS/RMI
2017-11-05 17:09 [PATCH v3 0/3] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3 Yiannis Marangos
2017-11-05 17:09 ` [PATCH v3 1/2] " Yiannis Marangos
@ 2017-11-05 17:09 ` Yiannis Marangos
1 sibling, 0 replies; 5+ messages in thread
From: Yiannis Marangos @ 2017-11-05 17:09 UTC (permalink / raw)
To: linux-input, dmitry.torokhov; +Cc: Yiannis Marangos
Signed-off-by: Yiannis Marangos <yiannis.marangos@gmail.com>
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index ee5466a374bf..b3c683a84d3f 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -172,6 +172,7 @@ static const char * const smbus_pnp_ids[] = {
"LEN0048", /* X1 Carbon 3 */
"LEN0046", /* X250 */
"LEN004a", /* W541 */
+ "LEN0073", /* X1 Carbon 5 */
"LEN200f", /* T450s */
NULL
};
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3
2017-11-05 17:09 ` [PATCH v3 1/2] " Yiannis Marangos
@ 2017-11-06 7:56 ` Benjamin Tissoires
2017-11-08 0:24 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Tissoires @ 2017-11-06 7:56 UTC (permalink / raw)
To: Yiannis Marangos; +Cc: linux-input, Dmitry Torokhov
On Sun, Nov 5, 2017 at 6:09 PM, Yiannis Marangos
<yiannis.marangos@gmail.com> wrote:
> Some synaptics devices such as LEN0073 use SMBUS version 3.
>
> Signed-off-by: Yiannis Marangos <yiannis.marangos@gmail.com>
> ---
In the same way v2 was:
Acked-by: Benjamin Tissoires <benjamion.tissoires@redhat.com>
This also applies to 2/2.
Yiannis, please next time keep the various acked-by, rev-by already
provided by reviewers, this is less work for the maintainer to gather
them if they are already there.
Cheers,
Benjamin
> drivers/input/rmi4/rmi_smbus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_smbus.c b/drivers/input/rmi4/rmi_smbus.c
> index 225025a0940c..b6ccf39c6a7b 100644
> --- a/drivers/input/rmi4/rmi_smbus.c
> +++ b/drivers/input/rmi4/rmi_smbus.c
> @@ -312,7 +312,7 @@ static int rmi_smb_probe(struct i2c_client *client,
> rmi_smb->xport.dev = &client->dev;
> rmi_smb->xport.pdata = *pdata;
> rmi_smb->xport.pdata.irq = client->irq;
> - rmi_smb->xport.proto_name = "smb2";
> + rmi_smb->xport.proto_name = "smb";
> rmi_smb->xport.ops = &rmi_smb_ops;
>
> smbus_version = rmi_smb_get_version(rmi_smb);
> @@ -322,7 +322,7 @@ static int rmi_smb_probe(struct i2c_client *client,
> rmi_dbg(RMI_DEBUG_XPORT, &client->dev, "Smbus version is %d",
> smbus_version);
>
> - if (smbus_version != 2) {
> + if (smbus_version != 2 && smbus_version != 3) {
> dev_err(&client->dev, "Unrecognized SMB version %d\n",
> smbus_version);
> return -ENODEV;
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3
2017-11-06 7:56 ` Benjamin Tissoires
@ 2017-11-08 0:24 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2017-11-08 0:24 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Yiannis Marangos, linux-input
On Mon, Nov 06, 2017 at 08:56:16AM +0100, Benjamin Tissoires wrote:
> On Sun, Nov 5, 2017 at 6:09 PM, Yiannis Marangos
> <yiannis.marangos@gmail.com> wrote:
> > Some synaptics devices such as LEN0073 use SMBUS version 3.
> >
> > Signed-off-by: Yiannis Marangos <yiannis.marangos@gmail.com>
> > ---
>
> In the same way v2 was:
> Acked-by: Benjamin Tissoires <benjamion.tissoires@redhat.com>
Applied, thank you.
>
> This also applies to 2/2.
>
> Yiannis, please next time keep the various acked-by, rev-by already
> provided by reviewers, this is less work for the maintainer to gather
> them if they are already there.
>
> Cheers,
> Benjamin
>
> > drivers/input/rmi4/rmi_smbus.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/input/rmi4/rmi_smbus.c b/drivers/input/rmi4/rmi_smbus.c
> > index 225025a0940c..b6ccf39c6a7b 100644
> > --- a/drivers/input/rmi4/rmi_smbus.c
> > +++ b/drivers/input/rmi4/rmi_smbus.c
> > @@ -312,7 +312,7 @@ static int rmi_smb_probe(struct i2c_client *client,
> > rmi_smb->xport.dev = &client->dev;
> > rmi_smb->xport.pdata = *pdata;
> > rmi_smb->xport.pdata.irq = client->irq;
> > - rmi_smb->xport.proto_name = "smb2";
> > + rmi_smb->xport.proto_name = "smb";
> > rmi_smb->xport.ops = &rmi_smb_ops;
> >
> > smbus_version = rmi_smb_get_version(rmi_smb);
> > @@ -322,7 +322,7 @@ static int rmi_smb_probe(struct i2c_client *client,
> > rmi_dbg(RMI_DEBUG_XPORT, &client->dev, "Smbus version is %d",
> > smbus_version);
> >
> > - if (smbus_version != 2) {
> > + if (smbus_version != 2 && smbus_version != 3) {
> > dev_err(&client->dev, "Unrecognized SMB version %d\n",
> > smbus_version);
> > return -ENODEV;
> > --
> > 2.14.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-input" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-08 0:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-05 17:09 [PATCH v3 0/3] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3 Yiannis Marangos
2017-11-05 17:09 ` [PATCH v3 1/2] " Yiannis Marangos
2017-11-06 7:56 ` Benjamin Tissoires
2017-11-08 0:24 ` Dmitry Torokhov
2017-11-05 17:09 ` [PATCH v3 2/2] Input: synaptics - Lenovo X1 Carbon 5 should use SMBUS/RMI Yiannis Marangos
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.