* [PATCH] libsemanage: free genhomedircon fallback user
@ 2017-11-06 15:35 Jan Zarsky
2017-11-08 6:58 ` Jason Zaman
0 siblings, 1 reply; 2+ messages in thread
From: Jan Zarsky @ 2017-11-06 15:35 UTC (permalink / raw)
To: selinux
Function semanage_genhomedircon() adds fallback user and function
setup_fallback_user() may add another one. But only one fallback
user is freed. Make sure to free all fallback users in
semanage_genhomedircon().
Signed-off-by: Jan Zarsky <jzarsky@redhat.com>
---
libsemanage/src/genhomedircon.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libsemanage/src/genhomedircon.c b/libsemanage/src/genhomedircon.c
index 27a269ea..d09d82ff 100644
--- a/libsemanage/src/genhomedircon.c
+++ b/libsemanage/src/genhomedircon.c
@@ -1385,7 +1385,9 @@ done:
if (out != NULL)
fclose(out);
- pop_user_entry(&(s.fallback));
+ while (s.fallback)
+ pop_user_entry(&(s.fallback));
+
ignore_free();
return retval;
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libsemanage: free genhomedircon fallback user
2017-11-06 15:35 [PATCH] libsemanage: free genhomedircon fallback user Jan Zarsky
@ 2017-11-08 6:58 ` Jason Zaman
0 siblings, 0 replies; 2+ messages in thread
From: Jason Zaman @ 2017-11-08 6:58 UTC (permalink / raw)
To: Jan Zarsky; +Cc: selinux
On Mon, Nov 06, 2017 at 04:35:30PM +0100, Jan Zarsky wrote:
> Function semanage_genhomedircon() adds fallback user and function
> setup_fallback_user() may add another one. But only one fallback
> user is freed. Make sure to free all fallback users in
> semanage_genhomedircon().
>
> Signed-off-by: Jan Zarsky <jzarsky@redhat.com>
Looks good to me,
merged, thanks :)
> ---
> libsemanage/src/genhomedircon.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libsemanage/src/genhomedircon.c b/libsemanage/src/genhomedircon.c
> index 27a269ea..d09d82ff 100644
> --- a/libsemanage/src/genhomedircon.c
> +++ b/libsemanage/src/genhomedircon.c
> @@ -1385,7 +1385,9 @@ done:
> if (out != NULL)
> fclose(out);
>
> - pop_user_entry(&(s.fallback));
> + while (s.fallback)
> + pop_user_entry(&(s.fallback));
> +
> ignore_free();
>
> return retval;
> --
> 2.14.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-08 6:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 15:35 [PATCH] libsemanage: free genhomedircon fallback user Jan Zarsky
2017-11-08 6:58 ` Jason Zaman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.