* [PATCH] zd1201: remove unused variable framelen
@ 2017-11-07 18:56 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-11-07 18:56 UTC (permalink / raw)
To: Kalle Valo, linux-wireless, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable framelen is assigned but never read, hence it is redundant
and can be removed. Cleans up clang warning:
drivers/net/wireless/zydas/zd1201.c:234:3: warning: Value stored
to 'framelen' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/zydas/zd1201.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/zydas/zd1201.c b/drivers/net/wireless/zydas/zd1201.c
index 581e8577a221..253403899fe9 100644
--- a/drivers/net/wireless/zydas/zd1201.c
+++ b/drivers/net/wireless/zydas/zd1201.c
@@ -230,8 +230,7 @@ static void zd1201_usbrx(struct urb *urb)
/* Info frame */
if (type == ZD1201_PACKET_INQUIRE) {
int i = 0;
- unsigned short infotype, framelen, copylen;
- framelen = le16_to_cpu(*(__le16*)&data[4]);
+ unsigned short infotype, copylen;
infotype = le16_to_cpu(*(__le16*)&data[6]);
if (infotype == ZD1201_INF_LINKSTATUS) {
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] zd1201: remove unused variable framelen
@ 2017-11-07 18:56 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-11-07 18:56 UTC (permalink / raw)
To: Kalle Valo, linux-wireless, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable framelen is assigned but never read, hence it is redundant
and can be removed. Cleans up clang warning:
drivers/net/wireless/zydas/zd1201.c:234:3: warning: Value stored
to 'framelen' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/zydas/zd1201.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/zydas/zd1201.c b/drivers/net/wireless/zydas/zd1201.c
index 581e8577a221..253403899fe9 100644
--- a/drivers/net/wireless/zydas/zd1201.c
+++ b/drivers/net/wireless/zydas/zd1201.c
@@ -230,8 +230,7 @@ static void zd1201_usbrx(struct urb *urb)
/* Info frame */
if (type = ZD1201_PACKET_INQUIRE) {
int i = 0;
- unsigned short infotype, framelen, copylen;
- framelen = le16_to_cpu(*(__le16*)&data[4]);
+ unsigned short infotype, copylen;
infotype = le16_to_cpu(*(__le16*)&data[6]);
if (infotype = ZD1201_INF_LINKSTATUS) {
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: zd1201: remove unused variable framelen
2017-11-07 18:56 ` Colin King
@ 2017-11-08 12:54 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2017-11-08 12:54 UTC (permalink / raw)
To: Colin Ian King; +Cc: linux-wireless, netdev, kernel-janitors, linux-kernel
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable framelen is assigned but never read, hence it is redundant
> and can be removed. Cleans up clang warning:
>
> drivers/net/wireless/zydas/zd1201.c:234:3: warning: Value stored
> to 'framelen' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
03e40f1e7680 zd1201: remove unused variable framelen
--
https://patchwork.kernel.org/patch/10047145/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-08 12:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 18:56 [PATCH] zd1201: remove unused variable framelen Colin King
2017-11-07 18:56 ` Colin King
2017-11-08 12:54 ` Kalle Valo
2017-11-08 12:54 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.