From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Ray Jui <rjui@broadcom.com>, Eric Anholt <eric@anholt.net>,
Rob Herring <robh+dt@kernel.org>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Harald Freudenberger <freude@linux.vnet.ibm.com>,
linux-arm-kernel@lists.infradead.org,
PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Martin Kaiser <martin@kaiser.cx>, Matt Mackall <mpm@selenic.com>,
bcm-kernel-feedback-list@broadcom.com,
Mark Rutland <mark.rutland@arm.com>,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 07/12] hwrng: bcm2835-rng: Manage an optional clock
Date: Wed, 8 Nov 2017 19:23:03 +0000 [thread overview]
Message-ID: <20171108192303.GT9463@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1065382783.63901.1510168797132@email.1und1.de>
On Wed, Nov 08, 2017 at 08:19:57PM +0100, Stefan Wahren wrote:
> Hi Florian,
> > + /* Clock is optional on most platforms */
> > + priv->clk = devm_clk_get(dev, NULL);
> > +
>
> At least EPROBE_DEFER should be handled here:
>
> if (IS_ERR(priv->clk) && PTR_ERR(priv->clk) == -EPROBE_DEFER)
> return -EPROBE_DEFER;
if (priv->clk == ERR_PTR(-EPROBE_DEFER))
return -EPROBE_DEFER;
is a simpler test for one particular error-pointer value.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/12] hwrng: bcm2835-rng: Manage an optional clock
Date: Wed, 8 Nov 2017 19:23:03 +0000 [thread overview]
Message-ID: <20171108192303.GT9463@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1065382783.63901.1510168797132@email.1und1.de>
On Wed, Nov 08, 2017 at 08:19:57PM +0100, Stefan Wahren wrote:
> Hi Florian,
> > + /* Clock is optional on most platforms */
> > + priv->clk = devm_clk_get(dev, NULL);
> > +
>
> At least EPROBE_DEFER should be handled here:
>
> if (IS_ERR(priv->clk) && PTR_ERR(priv->clk) == -EPROBE_DEFER)
> return -EPROBE_DEFER;
if (priv->clk == ERR_PTR(-EPROBE_DEFER))
return -EPROBE_DEFER;
is a simpler test for one particular error-pointer value.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-11-08 19:23 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 0:44 [PATCH v2 00/12] bcm63xx-rng conversion to bcm2835-rng Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
[not found] ` <20171108004449.32730-1-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-08 0:44 ` [PATCH v2 01/12] hwrng: bcm2835-rng: Obtain base register via resource Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-29 6:30 ` [v2,01/12] hwrng: bcm2835 - " Herbert Xu
2017-11-29 6:30 ` Herbert Xu
2017-11-29 6:30 ` Herbert Xu
2017-11-29 6:30 ` Herbert Xu
2017-11-29 17:38 ` Florian Fainelli
2017-11-29 17:38 ` Florian Fainelli
2017-11-29 17:38 ` Florian Fainelli
2017-11-29 17:38 ` Florian Fainelli
2017-11-30 7:14 ` Herbert Xu
2017-11-30 7:14 ` Herbert Xu
2017-11-30 7:14 ` Herbert Xu
2017-11-30 7:14 ` Herbert Xu
2017-11-08 0:44 ` [PATCH v2 06/12] hwrng: bcm2835-rng: Rework interrupt masking Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 18:26 ` Eric Anholt
2017-11-08 18:26 ` Eric Anholt
2017-11-08 18:26 ` Eric Anholt
2017-11-08 18:26 ` Eric Anholt
2017-11-08 18:46 ` Stefan Wahren
2017-11-08 18:46 ` Stefan Wahren
2017-11-08 18:46 ` Stefan Wahren
[not found] ` <1086045224.63286.1510166797078-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2017-11-08 20:41 ` Eric Anholt
2017-11-08 20:41 ` Eric Anholt
2017-11-08 20:41 ` Eric Anholt
2017-11-08 0:44 ` [PATCH v2 08/12] hwrng: bcm2835-rng: Abstract I/O accessors Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
[not found] ` <20171108004449.32730-9-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-08 18:33 ` Eric Anholt
2017-11-08 18:33 ` Eric Anholt
2017-11-08 18:33 ` Eric Anholt
2017-11-08 18:33 ` Eric Anholt
2017-11-13 4:54 ` [v2,08/12] " Philippe Mathieu-Daudé
2017-11-08 0:44 ` [PATCH v2 09/12] hwrng: bcm2835-rng: Add Broadcom MIPS " Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` [PATCH v2 12/12] hwrng: bcm63xx-rng: Remove since bcm2835-rng takes over Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 18:36 ` Eric Anholt
2017-11-08 18:36 ` Eric Anholt
2017-11-08 18:36 ` Eric Anholt
2017-11-08 18:36 ` Eric Anholt
2017-11-08 0:44 ` [PATCH v2 02/12] hwrng: bcm2835-rng: Define a driver private context Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 18:22 ` Eric Anholt
2017-11-08 18:22 ` Eric Anholt
2017-11-08 18:22 ` Eric Anholt
2017-11-08 18:22 ` Eric Anholt
2017-11-08 0:44 ` [PATCH v2 03/12] hwrng: bcm2835-rng: Move enabling to hwrng::init Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` [PATCH v2 04/12] hwrng: bcm2835-rng: Implementation cleanup callback Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` [PATCH v2 05/12] hwrng: bcm2835-rng: Use device managed helpers Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 18:24 ` Eric Anholt
2017-11-08 18:24 ` Eric Anholt
2017-11-08 18:24 ` Eric Anholt
2017-11-08 18:24 ` Eric Anholt
2017-11-08 0:44 ` [PATCH v2 07/12] hwrng: bcm2835-rng: Manage an optional clock Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 18:31 ` Eric Anholt
2017-11-08 18:31 ` Eric Anholt
2017-11-08 18:31 ` Eric Anholt
2017-11-08 18:31 ` Eric Anholt
2017-11-08 19:19 ` Stefan Wahren
2017-11-08 19:19 ` Stefan Wahren
2017-11-08 19:19 ` Stefan Wahren
2017-11-08 19:23 ` Russell King - ARM Linux [this message]
2017-11-08 19:23 ` Russell King - ARM Linux
2017-11-08 0:44 ` [PATCH v2 10/12] dt-bindings: rng: Incorporate brcm,bcm6368.txt binding Florian Fainelli
2017-11-08 0:44 ` [PATCH v2 10/12] dt-bindings: rng: Incorporate brcm, bcm6368.txt binding Florian Fainelli
2017-11-08 0:44 ` [PATCH v2 10/12] dt-bindings: rng: Incorporate brcm,bcm6368.txt binding Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` [PATCH v2 11/12] hwrng: bcm2835-rng: Enable BCM2835 RNG to work on BCM63xx platforms Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
2017-11-08 0:44 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108192303.GT9463@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=freude@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=martin@kaiser.cx \
--cc=mpm@selenic.com \
--cc=prasannatsmkumar@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=sean.wang@mediatek.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.