All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver
Date: Wed, 8 Nov 2017 20:27:59 +0100	[thread overview]
Message-ID: <20171108192759.GA26904@Red> (raw)
In-Reply-To: <CAGb2v64zkEoy=_9D7g+GC5ZxYg_zuaTo3LL1e=4RXLnL0VDWaA@mail.gmail.com>

On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote:
> On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe
> <clabbe.montjoie@gmail.com> wrote:
> > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed.
> > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree.
> 
> The subject should say "add .... device node", not driver.
> 
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> > ---
> >  arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > index 19acae1b4089..68e5135410ec 100644
> > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > @@ -336,6 +336,14 @@
> >                         #interrupt-cells = <3>;
> >                         #gpio-cells = <3>;
> >
> > +                       emac_rgmii_pins: emac-rgmii-pins {
> > +                               pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7",
> > +                                      "PD11", "PD12", "PD13", "PD14", "PD18",
> > +                                      "PD19", "PD21", "PD22", "PD23";
> > +                               function = "gmac";
> > +                               drive-strength = <40>;
> > +                       };
> > +
> 
> You should mention this change in your commit log.
> 
> ChenYu
> 

Ok I will do it

Thanks
Regards

WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver
Date: Wed, 8 Nov 2017 20:27:59 +0100	[thread overview]
Message-ID: <20171108192759.GA26904@Red> (raw)
In-Reply-To: <CAGb2v64zkEoy=_9D7g+GC5ZxYg_zuaTo3LL1e=4RXLnL0VDWaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote:
> On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe
> <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed.
> > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree.
> 
> The subject should say "add .... device node", not driver.
> 
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Reviewed-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > index 19acae1b4089..68e5135410ec 100644
> > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > @@ -336,6 +336,14 @@
> >                         #interrupt-cells = <3>;
> >                         #gpio-cells = <3>;
> >
> > +                       emac_rgmii_pins: emac-rgmii-pins {
> > +                               pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7",
> > +                                      "PD11", "PD12", "PD13", "PD14", "PD18",
> > +                                      "PD19", "PD21", "PD22", "PD23";
> > +                               function = "gmac";
> > +                               drive-strength = <40>;
> > +                       };
> > +
> 
> You should mention this change in your commit log.
> 
> ChenYu
> 

Ok I will do it

Thanks
Regards
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: clabbe.montjoie@gmail.com (Corentin Labbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver
Date: Wed, 8 Nov 2017 20:27:59 +0100	[thread overview]
Message-ID: <20171108192759.GA26904@Red> (raw)
In-Reply-To: <CAGb2v64zkEoy=_9D7g+GC5ZxYg_zuaTo3LL1e=4RXLnL0VDWaA@mail.gmail.com>

On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote:
> On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe
> <clabbe.montjoie@gmail.com> wrote:
> > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed.
> > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree.
> 
> The subject should say "add .... device node", not driver.
> 
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> > ---
> >  arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > index 19acae1b4089..68e5135410ec 100644
> > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > @@ -336,6 +336,14 @@
> >                         #interrupt-cells = <3>;
> >                         #gpio-cells = <3>;
> >
> > +                       emac_rgmii_pins: emac-rgmii-pins {
> > +                               pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7",
> > +                                      "PD11", "PD12", "PD13", "PD14", "PD18",
> > +                                      "PD19", "PD21", "PD22", "PD23";
> > +                               function = "gmac";
> > +                               drive-strength = <40>;
> > +                       };
> > +
> 
> You should mention this change in your commit log.
> 
> ChenYu
> 

Ok I will do it

Thanks
Regards

  parent reply	other threads:[~2017-11-08 19:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 20:13 [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver Corentin Labbe
2017-11-07 20:13 ` Corentin Labbe
2017-11-07 20:13 ` [PATCH 2/2] ARM: sun8i: bananapi-m3: Enable dwmac-sun8i Corentin Labbe
2017-11-07 20:13   ` Corentin Labbe
2017-11-07 20:13   ` Corentin Labbe
2017-11-08  6:27 ` [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver Chen-Yu Tsai
2017-11-08  6:27   ` Chen-Yu Tsai
2017-11-08  7:48   ` Maxime Ripard
2017-11-08  7:48     ` Maxime Ripard
2017-11-08  7:48     ` Maxime Ripard
2017-11-08 19:30     ` Corentin Labbe
2017-11-08 19:30       ` Corentin Labbe
2017-11-08 19:27   ` Corentin Labbe [this message]
2017-11-08 19:27     ` Corentin Labbe
2017-11-08 19:27     ` Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108192759.GA26904@Red \
    --to=clabbe.montjoie@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.