[pinctrl:devel 152/153] drivers/gpio/gpiolib.c:1943:19: warning: 'struct lock_dep_class' declared inside parameter list

[pinctrl:devel 152/153] drivers/gpio/gpiolib.c:1943:19: warning: 'struct lock_dep_class' declared inside parameter list

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1784 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
head:   bfcadc85ef134881fce5f8635648e36de1ab4c9d
commit: 959bc7b22bd25a3a907fbb9b26a1d0cbdf98ef40 [152/153] gpio: Automatically add lockdep keys
config: m68k-m5475evb_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 959bc7b22bd25a3a907fbb9b26a1d0cbdf98ef40
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

>> drivers/gpio/gpiolib.c:1943:19: warning: 'struct lock_dep_class' declared inside parameter list
               struct lock_dep_class *lock_key)
                      ^
>> drivers/gpio/gpiolib.c:1943:19: warning: its scope is only this definition or declaration, which is probably not what you want
   drivers/gpio/gpiolib.c:1942:19: error: conflicting types for 'gpiochip_add_irqchip'
    static inline int gpiochip_add_irqchip(struct gpio_chip *gpiochip,
                      ^
   drivers/gpio/gpiolib.c:75:12: note: previous declaration of 'gpiochip_add_irqchip' was here
    static int gpiochip_add_irqchip(struct gpio_chip *gpiochip,
               ^
   drivers/gpio/gpiolib.c:75:12: warning: 'gpiochip_add_irqchip' used but never defined

vim +1943 drivers/gpio/gpiolib.c

  1941	
  1942	static inline int gpiochip_add_irqchip(struct gpio_chip *gpiochip,
> 1943					       struct lock_dep_class *lock_key)
  1944	{
  1945		return 0;
  1946	}
  1947	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6520 bytes --]

Re: [pinctrl:devel 152/153] drivers/gpio/gpiolib.c:1943:19: warning: 'struct lock_dep_class' declared inside parameter list

[Geert Uytterhoeven]

On Wed, Nov 8, 2017 at 3:38 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
> head:   bfcadc85ef134881fce5f8635648e36de1ab4c9d
> commit: 959bc7b22bd25a3a907fbb9b26a1d0cbdf98ef40 [152/153] gpio: Automatically add lockdep keys
> config: m68k-m5475evb_defconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 4.9.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 959bc7b22bd25a3a907fbb9b26a1d0cbdf98ef40
>         # save the attached .config to linux build tree
>         make.cross ARCH=m68k
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/gpio/gpiolib.c:1943:19: warning: 'struct lock_dep_class' declared inside parameter list
>                struct lock_dep_class *lock_key)
>                       ^

s/lock_dep_class/lock_class_key/

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [pinctrl:devel 152/153] drivers/gpio/gpiolib.c:1943:19: warning: 'struct lock_dep_class' declared inside parameter list

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

On Wed, Nov 08, 2017 at 04:04:05PM +0100, Geert Uytterhoeven wrote:
> On Wed, Nov 8, 2017 at 3:38 PM, kbuild test robot
> <fengguang.wu@intel.com> wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
> > head:   bfcadc85ef134881fce5f8635648e36de1ab4c9d
> > commit: 959bc7b22bd25a3a907fbb9b26a1d0cbdf98ef40 [152/153] gpio: Automatically add lockdep keys
> > config: m68k-m5475evb_defconfig (attached as .config)
> > compiler: m68k-linux-gcc (GCC) 4.9.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 959bc7b22bd25a3a907fbb9b26a1d0cbdf98ef40
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=m68k
> >
> > All warnings (new ones prefixed by >>):
> >
> >>> drivers/gpio/gpiolib.c:1943:19: warning: 'struct lock_dep_class' declared inside parameter list
> >                struct lock_dep_class *lock_key)
> >                       ^
> 
> s/lock_dep_class/lock_class_key/

Yeah, I just sent Linus a fixup patch for that. Sorry for not noticing
earlier. I was focussing my build tests on covering as many GPIO drivers
as possible but never actually thought of building this for
!GPIOLIB_IRQCHIP.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]